Re: [PATCH] Enable non-complex math builtins from C99 for Bionic

2013-08-21 Thread Alexander Ivchenko
his time I didn't miss anything. Is it ok? diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 6e27be2..02679f3 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,14 @@ +2013-08-21 Alexander Ivchenko + + * config/linux-android.c (linux_android_libc_has_function): Fix + checks for libc.

Re: [PATCH] Enable non-complex math builtins from C99 for Bionic

2013-08-22 Thread Alexander Ivchenko
fixes the issues with my initial patch. (Andreas patch still needs to be applied) Is it OK? diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 6e27be2..2d15fb1 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,17 @@ +2013-08-21 Alexander Ivchenko + + * config/linux-andr

Re: [PATCH] Intrinsics for fxsave[,64], xsave[,64], xsaveopt[,64]

2013-08-26 Thread Alexander Ivchenko
Hi, I've added references to fxsr, xsave and xsaveopt options and builtins to doc/[invoke,extend].texi. Is it OK? diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 29a30ee..3aad294 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,8 @@ +2013-08-23 Alexander Ivchenko + +

[bootstrap] Fix build for several targets (including pr58242)

2013-09-02 Thread Alexander Ivchenko
Hi, Several builds are broken after r201838. Here is the fix, awaiting review: http://gcc.gnu.org/ml/gcc-patches/2013-08/msg01245.html The targets that are broken now: 1) *linux* targets that do not include config/linux.h in their tm.h (e.g alpha-linux, ppc64-linux etc). For them we have: ../..

Re: [PATCH] Enable non-complex math builtins from C99 for Bionic

2013-09-04 Thread Alexander Ivchenko
Hi Maxim, 2013/9/4 Maxim Kuvyrkov : > On 23/08/2013, at 1:04 AM, Alexander Ivchenko wrote: > >> Ugh.. thanks, you are right. That points to another problem that I >> didn't see before: >> >> 3) *linux* targets that do not append to tm_p_file (s390x-*-linux*

Re: [bootstrap] Fix build for several targets (including pr58242)

2013-09-04 Thread Alexander Ivchenko
better to address this in the follow-up patch (I can work on that). and btw we define all supported by linux libcs (LIBC_GLIBC, LIBC_BIONIC, LIBC_UCLIBC) in linux.opts and we also add it to all *linux* targets thanks, Alexander 2013/9/3 Jakub Jelinek : > On Tue, Sep 03, 2013 at 09:25:31AM +04

[i386, doc] Add documentation for fxsr, xsave, xsaveopt

2013-09-10 Thread Alexander Ivchenko
Hi, I've added references to fxsr, xsave and xsaveopt options and builtins to doc/[invoke,extend].texi. Is it OK? doc_fxsr_xsave_fxsave.patch Description: Binary data

[libvtv] Remove Android from supported targets

2013-09-12 Thread Alexander Ivchenko
/ChangeLog index 3c344f9..f0a7471 100644 --- a/libvtv/ChangeLog +++ b/libvtv/ChangeLog @@ -1,3 +1,7 @@ +2013-09-12 Alexander Ivchenko + + * configure.tgt: Remove *-*-*android* from supported targets. + 2013-09-09 H.J. Lu PR other/58374 diff --git a/libvtv/configure.tgt b/libvtv

[PATCH] Intrinsics for fxsave[,64], xsave[,64], xsaveopt[,64]

2012-10-18 Thread Alexander Ivchenko
Hi, this patch adds new intrinsics for fxsave, fxsave64, xsave, xsave64, xsaveopt and xsaveopt64 instructions Bootstrapped on x86-64 Is it ok for trunk? Changelog entry: 2012-10-16 Alexander Ivchenko * gcc/common/config/i386/i386-common.c (OPTION_MASK_ISA_FXSAVE_SET): New

[c++] Fix pr58525

2013-10-07 Thread Alexander Ivchenko
Hi, __cxa_throw_bad_array_new_length and __cxa_throw_bad_array_new_length are generated with -fno-exceptions right now. The attached patch fixes that problem. Bootstrapped and regtested on x86_64-unknown-linux-gnu: 2013-10-07 Alexander Ivchenko * gcc/cp/call.c

Re: Patch ping (stage1-ish patches)

2013-11-27 Thread Alexander Ivchenko
Here is the patch series that had been posted in Sep that is aimed to isolate the Android support from targets that actually don't have that support (We discussed the need of it with Jakub here http://gcc.gnu.org/ml/gcc-patches/2013-09/msg00185.html): http://gcc.gnu.org/ml/gcc-patches/2013-09/msg0

Re: Fix for PR79987

2017-06-09 Thread Alexander Ivchenko
in this thread: just returning zero bounds for void vars. The standard does not specify that size anyways. What do you think? Alexander 2017-05-11 20:37 GMT+02:00 Ilya Enkovich : > 2017-05-11 0:05 GMT+03:00 Alexander Ivchenko : >> Didn't quite get your point. I though that the idea

[patch, testsuite] Applying non_bionic effective target to particular tests

2014-08-13 Thread Alexander Ivchenko
/testsuite/ChangeLog index 536485a..893f2b3 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,16 @@ +2014-08-13 Alexander Ivchenko + + * gcc.dg/builtins-59.c: Disable test for Bionic. + * gcc.dg/builtins-61.c: Likewise. + * gcc.dg/builtins-67.c: Likewise. + * gcc.dg

Re: [patch, testsuite] Applying non_bionic effective target to particular tests

2014-08-15 Thread Alexander Ivchenko
w, I don't think they would bring any value. I tested 'make check' on x86_64-unknown-linux-gnu and i686-pc-linux-android. 2014-08-15 Alexander Ivchenko * lib/target-supports.exp (error_h): New check. (libc_has_complex_functions): Ditto. (tgmath_h): Ditto.

Re: [patch, testsuite] Applying non_bionic effective target to particular tests

2014-08-15 Thread Alexander Ivchenko
2014-08-15 21:32 GMT+04:00 enh : > can you file bugs against bionic for stuff like this? use > b.android.com (and feel free to mail me to ensure that they get > noticed). Sure, I will do that. > one thing we'd like to do is get to a point where we're building > gcc/gdb et cetera without any local

Re: [c++] Fix pr58525

2013-11-08 Thread Alexander Ivchenko
ups, I did ping in the wrong thread about this issue. Sorry. Anyway, I noticed that after r204334 my patch cannot be applied without conflicts. Here is the updated one attached. Bootstrapped and regtested on x86_64-unknown-linux-gnu. 2013-11-08 Alexander Ivchenko * gcc/cp/call.c

Re: [c++] Fix pr58525

2013-11-14 Thread Alexander Ivchenko
*kind ping* thanks, Alexander 2013/11/8 Alexander Ivchenko : > ups, I did ping in the wrong thread about this issue. Sorry. > > > Anyway, I noticed that after r204334 my patch cannot be applied > without conflicts. > Here is the updated one attached. Bootstrapped and reg

[PATCH] Fix typo that broke ia64-hpux

2013-11-26 Thread Alexander Ivchenko
Hi, The patch addresses the issue Jan-Benedict's buildrobot found: http://gcc.gnu.org/ml/gcc/2013-11/msg00507.html diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 7704433..da9a3e2 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,7 @@ +2013-11-26 Alexander Ivc

Re: config/vxworks-dummy.h on arm

2014-06-13 Thread Alexander Ivchenko
Hi Jakub, Looking back into the patch, I don't see any reason to delete vxwoks-dummy.h, looks like it was my mistake - sorry about that. So looks like your patch fixes the issue correctly. Thanks, Alexander 2014-06-12 21:47 GMT+04:00 Jakub Jelinek : > Hi! > > Seems http://gcc.gnu.org/r197156 eff

Re: [Android] Enable ifuncs on Android

2014-11-13 Thread Alexander Ivchenko
-bool -linux_has_ifunc_p (void) -{ - return OPTION_BIONIC ? false : HAVE_GNU_INDIRECT_FUNCTION; -} That is what prevent us from doing so. We need to remove OPTION_BIONIC from that hook and that is what the patch does. 2014-11-14 8:32 GMT+04:00 H.J. Lu : > On Thu, Nov 13, 2014 at 8:27 PM, Andrew

Re: PATCH: Don't assume modern glibc for x86 Android targets

2014-11-14 Thread Alexander Ivchenko
should we also change this comment in gcc/configure? --enable-gnu-indirect-function enable the use of the @gnu_indirect_function to glibc systems So, if the patch that I sent for removing linux_has_ifunc_p is approved, we will just add "--en

Re: [Android] Enable ifuncs on Android

2014-11-24 Thread Alexander Ivchenko
*ping* thanks, Alexander 2014-11-14 19:49 GMT+03:00 H.J. Lu : > On Thu, Nov 13, 2014 at 8:59 PM, Jeff Law wrote: >> On 11/13/14 21:46, H.J. Lu wrote: >> >>> >>> Hi Jeff, >>> >>> I believe the patch is correct. Not all glibcs support IFUNC. It doesn't >>> mean >>> we should disable IFUNC for all

[Android] Enable ifuncs on Android

2014-11-12 Thread Alexander Ivchenko
-android is correct. diff --git a/gcc/ChangeLog b/gcc/ChangeLog index eac19cf..9932323 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,8 @@ +2014-11-11 Alexander Ivchenko + + * config/linux.c (linux_has_ifunc_p): Remove. + * config/linux.h (TARGET_HAS_IFUNC_P): Use the

[PATCH, testsuite] Add bind_pic_locally to certain tests

2014-11-12 Thread Alexander Ivchenko
cause __stack_chk_fail (that is scanned in them) is not emitted in position independent case. Patch is regtested on x86_64-unknown-linux-gnu. Is it OK? 2014-11-12 Alexander Ivchenko * c-c++-common/tm/safe-3.c: Add bind_pic_locally. * g++.dg/ipa/devirt-15.C: Ditto. * g

[MPX] Fix for PR77267

2016-08-25 Thread Alexander Ivchenko
The attached patched fixes the usage of MPX in presence of "-Wl,-as-needed" option. 'make checked' on MPX-enabled machine. "--push-state" and "--pop-state" are not supported by gold at the moment. But that's OK because using MPX with gold only recommended in static build. Would that be OK for tru

Re: [MPX] Fix for PR77267

2016-08-30 Thread Alexander Ivchenko
" -gt 2; then + ld_pushpopstate_support=yes +fi + elif test x$gcc_cv_ld != x; then +# Check if linker supports --push-state/--pop-state options +if $gcc_cv_ld --help 2>/dev/null | grep -- '--push-state' > /dev/null; then + ld_pushpopstate_support=yes +

Re: [MPX] Fix for PR77267

2016-08-31 Thread Alexander Ivchenko
2016-08-31 12:18 GMT+03:00 Ilya Enkovich : > 2016-08-30 21:53 GMT+03:00 Alexander Ivchenko : >> Would something like that count? >> >> I did not do the warning thing, cause the problem only appears when >> you provide the -Wl,-as-needed option to the linker. >> (In

Re: [MPX] Fix for PR77267

2016-09-05 Thread Alexander Ivchenko
Ok, thanks. The full updated patch is below. I also removed the '--whole-archive' thing from -static-libmpxwrappers case. Would that be possible to backport that patch to 6 branch as well? And could you please also address Sergey's comment on adding weak symbol that he's made in the bugzilla? dif

[CHKP] Attempt to fix PR79765 (multiversioning and instrumentation)

2017-05-08 Thread Alexander Ivchenko
Hi, I'm trying to fix the problem with function multiversioning and MPX instrumentation (PR79765) and I face several issues. I would appreciate your advice: The first problem that arises is that multiversioning tries to make versions out of thunks, which do not have bodies. This is fixed with th

Re: [CHKP] Fix for PR79990

2017-05-09 Thread Alexander Ivchenko
Hi, Here is the latest version of the patch with all comments addressed: gcc/ChangeLog: 2017-05-09 Alexander Ivchenko * tree-chkp.c (chkp_get_hard_register_var_fake_base_address): New function. (chkp_get_hard_register_fake_addr_expr): Ditto. (chkp_build_addr_expr

Re: Fix for PR79987

2017-05-09 Thread Alexander Ivchenko
ue; } ..here the TREE_TYPE(arg)==void. Any ideas for a good workaround ? Alexander 2017-04-08 21:59 GMT+02:00 Ilya Enkovich : > 2017-04-04 18:34 GMT+03:00 Jeff Law : >> On 04/04/2017 09:07 AM, Alexander Ivchenko wrote: >>> >>> Hi, >>> >>> When

Re: Pointer Bounds Checker and trailing arrays (PR68270)

2016-12-21 Thread Alexander Ivchenko
(field) || TREE_CODE (DECL_FIELD_OFFSET (field)) == INTEGER_CST) && (!DECL_FIELD_BIT_OFFSET (field) 2016-12-21 21:00 GMT+03:00 Ilya Enkovich : > 2016-12-20 17:44 GMT+03:00 Alexander Ivchenko : >> 2016-11-26 0:28 GMT+03:00 Ilya Enkovich : >>> 2016-11-25 15:47 GMT+03:00 Alexander

PR78631 fix

2016-12-23 Thread Alexander Ivchenko
Hi Ilya, Would that patch be OK to submit? (it is HJ's one with added testcase) diff --git a/gcc/testsuite/gcc.target/i386/mpx/memcpy-1.c b/gcc/testsuite/gcc.target/i386/mpx/memcpy-1.c new file mode 100644 index 000..1691348 --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/mpx/memcpy-1.c @@

[COMMITTED] Add myself to MAINTAINERS (Write After Approval).

2016-12-26 Thread Alexander Ivchenko
Committed as r243927. Thanks, Alexander diff --git a/ChangeLog b/ChangeLog index 2e35b01..8b2c94d 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,7 @@ +2016-12-26 Alexander Ivchenko + + * MAINTAINERS (Write After Approval): Add myself. + 2016-12-21 Jakub Jelinek

Re: Calling 'abort' on bounds violations in libmpx

2016-12-26 Thread Alexander Ivchenko
Submitted as r243928. Thank you 2016-12-08 20:22 GMT+03:00 Ilya Enkovich : > 2016-12-08 12:21 GMT+03:00 Alexander Ivchenko : >> I've tested the patch on MPX HW, no new regressions. Attached the >> final version below, would that be ok to submit? > > The patch is OK. &

Re: Pointer Bounds Checker and trailing arrays (PR68270)

2016-12-27 Thread Alexander Ivchenko
Committed as r243936. Thank you, Alexander 2016-12-22 2:47 GMT+03:00 Ilya Enkovich : > 2016-12-21 22:18 GMT+03:00 Alexander Ivchenko : >> Right.. here is this updated chunk (otherwise no difference in the patch) >> >> diff --git a/gcc/tree-chkp.c b/gcc/tree-chkp.c >

Re: PR78631 fix

2016-12-27 Thread Alexander Ivchenko
Committed as r243942 with the ChangeLog entries thanks, Alexander 2016-12-23 21:48 GMT+03:00 Ilya Enkovich : > Hi, > > ChangeLog? Otherwise OK. > > Ilya > > 2016-12-23 14:02 GMT+03:00 Alexander Ivchenko : >> Hi Ilya, >> >> Would that patch be OK to subm

[CHKP] Fix for PR79990

2017-03-23 Thread Alexander Ivchenko
Hi, The patch below attempts to fix the PR. I checked that it did not break any of mpx.exp tests, but I did not run the full testing yet. Would like to know whether this approach is generally correct or not. The issue is that we have the hard reg vector variable: typedef int U __attribute__ ((ve

Re: [CHKP] Fix for PR79990

2017-04-02 Thread Alexander Ivchenko
(ptr_src, iter); else bounds = chkp_get_nonpointer_load_bounds (); break; @@ -4031,7 +4065,19 @@ chkp_process_stmt (gimple_stmt_iterator *iter, tree node, addr_first, byte_position (field)); } -else +else if (VAR_P (ptr) && DECL_HARD_

Fix for PR79987

2017-04-04 Thread Alexander Ivchenko
Is it OK? gcc/ChangeLog: 2017-04-04 Alexander Ivchenko * tree-chkp.c (chkp_get_bounds_for_decl_addr): assigning zero bounds to void variables gcc/testsuite/ChangeLog: 2017-04-04 Alexander Ivchenko * gcc.target/i386/mpx/PR79987.c: New test. diff --git a/gcc/testsuite/gc

Re: [CHKP] Fix for PR79990

2017-04-19 Thread Alexander Ivchenko
Hi, Thanks for the comments, that was a good idea to place all the logic inside of chkp_build_addr_expr function. I followed it and here is what I got: gcc/testsuite/ChangeLog: 2017-04-19 Alexander Ivchenko * gcc.target/i386/mpx/hard-reg-2-lbv.c: New test. * gcc.target/i386

Re: [CHKP] Fix for PR79990

2017-04-20 Thread Alexander Ivchenko
Thanks for correcting the usage of get_base_address. I fixed that. Plus addressed the comment about the avoiding the usage of chkp_find_bounds. gcc/testsuite/ChangeLog: 2017-04-20 Alexander Ivchenko * gcc.target/i386/mpx/hard-reg-2-lbv.c: New test. * gcc.target/i386/mpx/hard

[CHKP] Fix for PR79988

2017-04-20 Thread Alexander Ivchenko
Hi Ilya, The patch below is basically what Richard proposed in Bugzilla. This approach should produce the correct code for any address spaces, because it will just strip the address space part of the pointer in all bnd* instructions; Since we will do that consistently, all checks should be consist

Re: [CHKP] Fix for PR79990

2017-04-21 Thread Alexander Ivchenko
; 2017-04-20 12:27 GMT+03:00 Alexander Ivchenko : >> Thanks for correcting the usage of get_base_address. I fixed that. >> Plus addressed the comment about the avoiding the usage of >> chkp_find_bounds. >> >> >> gcc/testsuite/ChangeLog: >> >> 2017-04-2

Re: [PATCH] Avoid implicitly declared __mpxrt_stop in libmpx

2017-01-30 Thread Alexander Ivchenko
Hi Jakub, Thanks for noticing that. Of course the declaration had to be in the header for this case Alexander 2017-01-30 13:13 GMT+03:00 Jakub Jelinek : > Hi! > > On Mon, Dec 26, 2016 at 06:15:01PM +0300, Alexander Ivchenko wrote: >> Submitted as r243928. >> >> (__m

Pointer Bounds Checker and trailing arrays (PR68270)

2016-11-25 Thread Alexander Ivchenko
Hi, The patch below addresses PR68270. could you please take a look? 2016-11-25 Alexander Ivchenko * c-family/c.opt (flag_chkp_flexible_struct_trailing_arrays): Add new option. * tree-chkp.c (chkp_parse_array_and_component_ref): Forbid narrowing when

Calling 'abort' on bounds violations in libmpx

2016-11-29 Thread Alexander Ivchenko
Hi, Attached patch is addressing PR67520. Would that approach work for the problem? Should I also change the version of the library? 2016-11-29 Alexander Ivchenko * mpxrt/mpxrt-utils.c (set_mpx_rt_stop_handler): New function. (print_help): Add help for CHKP_RT_STOP_HANDLER environment

Re: Calling 'abort' on bounds violations in libmpx

2016-12-01 Thread Alexander Ivchenko
px, so I'm not sure what tests should I add. What do you think would be the right testing process here? 2016-11-29 20:22 GMT+03:00 Ilya Enkovich : > 2016-11-29 17:43 GMT+03:00 Alexander Ivchenko : >> Hi, >> >> Attached patch is addressing PR67520. Would that approach wo

Re: Calling 'abort' on bounds violations in libmpx

2016-12-08 Thread Alexander Ivchenko
I've tested the patch on MPX HW, no new regressions. Attached the final version below, would that be ok to submit? 2016-11-29 Alexander Ivchenko * mpxrt/libtool-version: New version. * mpxrt/mpxrt-utils.c (set_mpx_rt_stop_handler): New function. (print_help): Add hel

Re: Pointer Bounds Checker and trailing arrays (PR68270)

2016-12-20 Thread Alexander Ivchenko
2016-11-26 0:28 GMT+03:00 Ilya Enkovich : > 2016-11-25 15:47 GMT+03:00 Alexander Ivchenko : >> Hi, >> >> The patch below addresses PR68270. could you please take a look? >> >> 2016-11-25 Alexander Ivchenko >> >>* c-family/c.opt (flag_chkp_fl

[Android] Stop unconditional disabling of ifuncs for Bionic #2

2014-12-09 Thread Alexander Ivchenko
/ChangeLog b/gcc/ChangeLog index f22bba8..d4d09d0 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,8 @@ +2014-12-08 Alexander Ivchenko + + * config/linux.c (linux_has_ifunc_p): Remove. + * config/linux.h (TARGET_HAS_IFUNC_P): Use default version. + 2014-12-08 Ilya Tocar

Re: [testsuite] Disabling gcc.dg/cpp/trad/include.c for Android

2013-04-29 Thread Alexander Ivchenko
*ping* thanks, Alexander 2013/3/26 Alexander Ivchenko : > Hi, > > Could you please take a look at the attached fixinclude patch > that addresses the problem: > > " We have test fail for gcc.dg/cpp/trad/include.c on Android. The > reason for that is that > -ftradi

Re: [PATCH] Redesign pthread in LIB_SPEC for systems without libpthread

2013-04-29 Thread Alexander Ivchenko
*ping* thank you, Alexander 2013/4/15 Pavel Chupin : > On Tue, Apr 2, 2013 at 1:59 PM, Pavel Chupin wrote: >> On Mon, Apr 1, 2013 at 7:07 PM, Pavel Chupin >> wrote: >>> On Android pthread is integrated into libc. >>> Attached patch fixes configures for this case by trying to build test >>> wit

Re: [testsuite] Disabling gcc.dg/cpp/trad/include.c for Android

2013-04-29 Thread Alexander Ivchenko
2013/4/29 Mike Stump : > On Jan 9, 2013, at 7:14 AM, Alexander Ivchenko wrote: >> We have test fail for gcc.dg/cpp/trad/include.c on Android. The >> reason for that is that >> -ftraditional-cpp is not expected to work on Android due to variadic >> macro (like #de

[tree-ssa] fix for PR57385

2013-05-23 Thread Alexander Ivchenko
Hi, The following patch fixes PR57385 (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57385) diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 51e7b9e..cca61e7 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2013-05-24 Alexander Ivchenko + + PR tree-ssa/57385 + * tree

Re: [testsuite] Adding target nonpic to g++.dg/tm/pr47746.C

2013-05-24 Thread Alexander Ivchenko
*ping* 2013/4/11 Alexander Ivchenko : > Hi, > > The same motivation as for: > http://gcc.gnu.org/ml/gcc-cvs/2013-03/msg00786.html > > "Since -fpic option is turned on by default in Android we have certain test > fails. The reason for that is that those tests rel

Re: [PATCH,bionic] Add -foptimize-sincos

2013-05-24 Thread Alexander Ivchenko
Richard, the target hook (libc_has_function) for what you described is waiting for a review: http://gcc.gnu.org/ml/gcc-patches/2013-03/msg01201.html However, it doesn't have command line options support. Alexander 2013/5/24 Richard Biener : > On Fri, May 24, 2013 at 12:53 PM, Andrew Hsieh wrot

Re: [testsuite] Adding target nonpic to g++.dg/tm/pr47746.C

2013-05-27 Thread Alexander Ivchenko
*ping* Alexander 2013/4/18 Patrick Marlier : > Hi Alexander, > > On Thu, Apr 18, 2013 at 12:49 PM, Alexander Ivchenko > wrote: >> I'm trying it on linux/x86_64 on trunk. Testing just by adding -fpic >> to the dg-options: >> >> --- a/gcc/testsuite/g++

Re: [testsuite] Adding target nonpic to g++.dg/tm/pr47746.C

2013-05-27 Thread Alexander Ivchenko
Oh, sorry. Missed the last msg from Mike in that thread. 2013/5/27 Alexander Ivchenko : > *ping* > > Alexander > > 2013/4/18 Patrick Marlier : >> Hi Alexander, >> >> On Thu, Apr 18, 2013 at 12:49 PM, Alexander Ivchenko >> wrote: >>> I'm tryin

Re: [PATCH] Enable non-complex math builtins from C99 for Bionic

2013-05-27 Thread Alexander Ivchenko
et () for example. This patch is related to that idea: in the target hook libc_has_function we can check whether the compiler should generate calls to a particular function or not. The command line support for each function could be the next step. Could you please take a look? thanks Alexan

[testsuite] Adding target nonpic to certain tests part. 2

2013-06-05 Thread Alexander Ivchenko
Hi, Another bunch of tests that fails with -fpic. from here: http://gcc.gnu.org/ml/gcc-patches/2013-01/msg00539.html "Since -fpic option is turned on by default in Android we have certain test fails. The reason for that is that those tests rely on the availability of functions, defined in them an

Re: [testsuite] Adding target nonpic to certain tests part. 2

2013-06-10 Thread Alexander Ivchenko
do you think? > > Thanks, > -- > Patrick > > On Wed, Jun 5, 2013 at 1:13 PM, Alexander Ivchenko wrote: >> Hi, >> >> Another bunch of tests that fails with -fpic. >> >> from here: http://gcc.gnu.org/ml/gcc-patches/2013-01/msg00539.html >> "

Re: [PATCH] Enable non-complex math builtins from C99 for Bionic

2013-06-19 Thread Alexander Ivchenko
;> 2013/4/23 Alexander Ivchenko : >>> *ping* >>> >>> thanks >>> Alexander >>> >>> 2013/3/28 Alexander Ivchenko : >>>> Hi, >>>> >>>> 4.8 is now branched, lets come back to the discussion that we had >>

[testsuite, android] Disabling thread_local4.C and thread_local4g.C for Android.

2013-06-20 Thread Alexander Ivchenko
benefit. <...>" The following patch switches those tests off for Android. diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index b8073d1..d217e4d 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2013-06-19 Alexander Ivchenko + +

Re: fixincludes 2013-05-23

2013-07-08 Thread Alexander Ivchenko
d have put it on the correct place (also had to change the place of obstack_lvalue_cast - it was not alphabetically correct). is the attached patch ok? All fixinclude tests pass. best regards, Alexander 2013/7/6 Bruce Korb : >> Alexander Ivchenko Mon, 29 Apr 2013 23:24:55 -0700 &

Re: [testsuite] Adding target nonpic to certain tests part. 2

2013-07-08 Thread Alexander Ivchenko
already did that for some tests before here: http://gcc.gnu.org/ml/gcc-patches/2013-03/msg00975.html So, considering that, it should be a pretty obvious fix. thanks, Alexander 2013/6/11 Alexander Ivchenko : > Yep, that also works for us. I updated the patch. Is it ok for trunk? > > --Al

Re: fixincludes 2013-05-23

2013-07-08 Thread Alexander Ivchenko
2013/7/8 Bruce Korb : > Hi, > > On Mon, Jul 8, 2013 at 5:05 AM, Alexander Ivchenko wrote: >> Hi Bruce, >> >> That was my original letter: >>>Hi, >>> >>>Could you please take a look at the attached fixinclude patch >>>that address

Re: [testsuite, android] Disabling thread_local4.C and thread_local4g.C for Android.

2013-07-12 Thread Alexander Ivchenko
*ping* Thank you, Alexander 2013/6/20 Alexander Ivchenko : > Hi, > > for Android: > > FAIL: g++.dg/tls/thread_local4.C -std=gnu++11 (test for excess errors) > Excess errors: > <>/gcc/testsuite/g++.dg/tls/thread_local4.C:31:26: error: > 'pthread_testcancel'

Re: [testsuite] Adding target nonpic to certain tests part. 2

2013-07-25 Thread Alexander Ivchenko
*Ping* Richard, you approved adding "target nonpic" last time, could you please take quick a look? I regularly encounter failing due to "AVAIL_OVERWRITABLE" tests on Android.. When people write tests they don't consider pic targets. thanks, Alexander 2013/7/8 Ale

Re: [testsuite, android] Disabling thread_local4.C and thread_local4g.C for Android.

2013-07-26 Thread Alexander Ivchenko
ce. Is it OK? thanks, Alexander 2013/7/14 Maxim Kuvyrkov : > On 13/07/2013, at 10:34 AM, Mike Stump wrote: > >> On Jun 20, 2013, at 4:30 AM, Alexander Ivchenko wrote: >>> for Android: >> >>> +2013-06-19 Alexander Ivchenko >>> + >>>

Re: [PATCH] Enable non-complex math builtins from C99 for Bionic

2013-07-28 Thread Alexander Ivchenko
2013/7/28 Michael Eager : > On 07/27/13 15:18, Alexander Ivchenko wrote: >> >> Hi Joseph, thanks for your comments. >> >> I updated the patch: > > >> >> 2013/7/9 Joseph S. Myers : > > >>> >>> * It looks rather like microblaze*

Re: [PATCH] Enable non-complex math builtins from C99 for Bionic

2013-07-30 Thread Alexander Ivchenko
Just to confirm that the patch successfully regtested on x86_64-unknown-linux-gnu. thanks, Alexander 2013/7/29 Alexander Ivchenko : > 2013/7/28 Michael Eager : >> On 07/27/13 15:18, Alexander Ivchenko wrote: >>> >>> Hi Joseph, thanks for your comments.

[testsuite, Android] Add to pr56407.c

2013-08-05 Thread Alexander Ivchenko
ChangeLog index f356d55..5c23650 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2013-08-05 Alexander Ivchenko + + * gcc.dg/torture/pr56407.c: Add include of stdlib.h. Remove + declaration of abort() and rand(). + 2013-08-04 Ed Smith-Rowland <

Re: [testsuite, Android] Add to pr56407.c

2013-08-06 Thread Alexander Ivchenko
rrect, because it doesn't have the external linkage. I added Elliott. Still, in C standart it is said that rand is defined in stdlib.h, and we don't include it in that testcase. thanks, Alexander 2013/8/5 Maxim Kuvyrkov : > On 5/08/2013, at 10:57 PM, Alexander Ivchenko wrote: > &

Re: [testsuite, Android] Add to pr56407.c

2013-08-06 Thread Alexander Ivchenko
Thanks Andreas, it seems clear now that Bionic rand function is not consistent with the standart. --Alexander 2013/8/6 Andreas Schwab : > Alexander Ivchenko writes: > >> Still, in C standart it is said that rand is defined in stdlib.h, and >> we don't include it in tha

Re: [PATCH] Redesign pthread in LIB_SPEC for systems without libpthread

2013-08-15 Thread Alexander Ivchenko
Could anybody please take a look? This is important for building gcc for android. ping^4 thanks, Alexander 2013/8/15 Alexander Ivchenko : > Could anybody please take a look? This is important for building gcc for > android. > > ping^4 > thanks, > Alexander > > > 2013/

Re: [testsuite] Adding -fno-pic to certain tests

2013-03-23 Thread Alexander Ivchenko
Hi, Finally got my hands on that: the attached patch adds the "target nonpic" for those tests that require the avaiability of functions defined in them. OK for trunk? thanks, Alexander 2013/1/10 Richard Biener : > On Thu, Jan 10, 2013 at 2:50 PM, Alexander Ivchenko > wrote:

Re: [testsuite] Disabling gcc.dg/cpp/trad/include.c for Android

2013-03-26 Thread Alexander Ivchenko
(x, y...)) in standard headers and traditional preprocessor cannot handle them." is it ok for trunk? thanks, Alexander 2013/1/9 Andrew Pinski : > On Wed, Jan 9, 2013 at 7:14 AM, Alexander Ivchenko wrote: >> Hi, >> >> We have test fail for gcc.dg/cpp/trad/include.c on

Re: [RFC PATCH] Implementing ifunc target hook

2013-03-26 Thread Alexander Ivchenko
.]) + HAVE_GNU_INDIRECT_FUNCTION was not defined on targets that don't have the support of IFUNC and the build of compiler could be broken. Now we define HAVE_GNU_INDIRECT_FUNCTION as 0 in those cases. ok for trunk? thanks, Alexander 2013/1/15 Maxim Kuvyrkov : > On 15/01/2013, at 4:55 AM, Al

Re: [testsuite] Adding -fno-pic to certain tests

2013-03-27 Thread Alexander Ivchenko
Hi, Thank you for your review. Since the patch was aimed to fix tests and it is pretty small, is it posible to backport it to 4.8 branch? So we would not have those testfails on Android with new release. Alexander 2013/3/27 Kirill Yukhin : >> Ok with that change. > > Checked into trunk: http://

Re: [RFC PATCH] Implementing ifunc target hook

2013-04-02 Thread Alexander Ivchenko
tmake_file="$tmake_file arm/t-linux-androideabi" ;; esac I deleted the second encounter: diff --git a/gcc/ChangeLog b/gcc/ChangeLog index d18c6e9..0e1d5e4 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,7 @@ +2013-04-02 Alexander Ivchenko + + * c

[testsuite] Adding target nonpic to g++.dg/tm/pr47746.C

2013-04-11 Thread Alexander Ivchenko
tsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2013-04-11 Alexander Ivchenko + + * g++.dg/tm/pr47746.C: Add target nonpic. + 2013-04-11 Paolo Carlini PR c++/54216 diff --git a/gcc/testsuite/g++.dg/tm/pr47746.C b/gcc/testsuite/g++.dg/tm/pr47746.C index 7cd9e10

[testsuite, i386] Reimplementing array comparison in avx2-vpop-check.h

2013-04-11 Thread Alexander Ivchenko
Hi, Usually does not include but on bionic it is historically included. memcmp() reacts on a volatile argument differently, depending on whether is included or not. If it is included, then the compiler will generate a warning: warning: passing argument 2 of 'memcmp' discards 'volatile' qualifie

Re: [testsuite, i386] Reimplementing array comparison in avx2-vpop-check.h

2013-04-18 Thread Alexander Ivchenko
OK for trunk? thanks, Alexander 2013/4/11 Richard Biener : > On Thu, Apr 11, 2013 at 1:58 PM, Alexander Ivchenko > wrote: >> Hi, >> >> Usually does not include but on bionic it is >> historically included. memcmp() reacts on a volatile argument >> d

Re: [testsuite] Adding target nonpic to g++.dg/tm/pr47746.C

2013-04-18 Thread Alexander Ivchenko
*/ 4463| if (cgraph_function_body_availability (node) < AVAIL_AVAILABLE) 4464+>return true; 4465| (gdb) p cgraph_function_body_availability (node) $54 = AVAIL_OVERWRITABLE Sure I can file a PR If you think that the test was not supposed to fail with -fpic thanks, Alexander 2013/4/18 Patrick Marl

Re: [PATCH] Enable non-complex math builtins from C99 for Bionic

2013-04-23 Thread Alexander Ivchenko
*ping* thanks Alexander 2013/3/28 Alexander Ivchenko : > Hi, > > 4.8 is now branched, lets come back to the discussion that we had > before. I updated the patch a little > bit since we now have linux-protos.h and linux-android.c files. > > I tried to preserve the avaia

Fix build of *86*-linux-android with "--enable-shared"

2014-08-03 Thread Alexander Ivchenko
is check after we added "-pthread" to CFLAGS. This patch addresses this as well. diff --git a/libcilkrts/ChangeLog b/libcilkrts/ChangeLog index 3881c82..ab10a0b 100644 --- a/libcilkrts/ChangeLog +++ b/libcilkrts/ChangeLog @@ -1,3 +1,15 @@ +2014-08-01 Alexander Ivchenko + + * configure.a

Remove unnecessary and harmful fixincludes for Android

2014-08-04 Thread Alexander Ivchenko
44 --- a/fixincludes/ChangeLog +++ b/fixincludes/ChangeLog @@ -1,3 +1,10 @@ +2014-08-04 Alexander Ivchenko + + * inclhack.def (stdio_va_list): Disable fix for *android*. + (complier_h_tradcpp): Remove. + * fixincl.x: Regenerate. + * tests/base/linux/compiler.h: Remove. + 2014-04-22 Rainer Orth

Re: Remove unnecessary and harmful fixincludes for Android

2014-08-05 Thread Alexander Ivchenko
Hi Andrew, Joseph, thanks for looking at the patch. See my comments and updated patch below. 2014-08-05 0:54 GMT+04:00 Andrew Pinski : > On Mon, Aug 4, 2014 at 8:29 AM, Alexander Ivchenko wrote: >> Hi, >> >> The following patch disables "stdio_va_list" fix: stdio.

Re: Fix build of *86*-linux-android with "--enable-shared"

2014-08-06 Thread Alexander Ivchenko
Thanks for looking at this. Bootstrapped and reg-tested on x86_64-unknown-linux-gnu. 2014-08-06 0:18 GMT+04:00 Jeff Law : > On 08/04/14 00:08, Alexander Ivchenko wrote: >> >> Hi, >> >> libcilkrts is compiled with "-nostdlib", that means we have to >>

Re: Remove unnecessary and harmful fixincludes for Android

2014-08-06 Thread Alexander Ivchenko
effee..b69897b 100644 --- a/fixincludes/ChangeLog +++ b/fixincludes/ChangeLog @@ -1,3 +1,9 @@ +2014-08-04 Alexander Ivchenko + + * inclhack.def (complier_h_tradcpp): Remove. + * fixincl.x: Regenerate. + * tests/base/linux/compiler.h: Remove. + 2014-04-22 Rainer

Fix PR60644

2014-03-26 Thread Alexander Ivchenko
angeLog index eb0d6ec..65efef0 100644 --- a/libcilkrts/ChangeLog +++ b/libcilkrts/ChangeLog @@ -1,3 +1,12 @@ +2014-03-26 Alexander Ivchenko + + PR bootstrap/60644 + + * include/cilk/metaprogramming.h: Change ANDROID to __ANDROID__. + * include/cilk/reducer_min_max.h: Ditto. + * runtime/bug.h: Ditto

Re: Fix PR60644

2014-03-27 Thread Alexander Ivchenko
Adding Balaji. --Alexander 2014-03-26 18:56 GMT+04:00 Alexander Ivchenko : > Hi, > > In gcc/config/linux-android.h we have "builtin_define ("__ANDROID__");" > So "ANDROID" as in libcilkrts now is not the correct macro to check. > > Bootstrapped a

Re: Fix PR60644

2014-04-04 Thread Alexander Ivchenko
*ping* --Alexander 2014-03-27 13:43 GMT+04:00 Alexander Ivchenko : > Adding Balaji. > > --Alexander > > 2014-03-26 18:56 GMT+04:00 Alexander Ivchenko : >> Hi, >> >> In gcc/config/linux-android.h we have "builtin_define ("__ANDROID__");" &g

Re: Fix PR60644

2014-04-04 Thread Alexander Ivchenko
2014-04-04 14:19 GMT+04:00 Richard Biener : > On Fri, Apr 4, 2014 at 12:03 PM, Alexander Ivchenko > wrote: >> *ping* > > I wonder whether this is consistend between compilers (note GCC is not > upstream here?). So eventually all places should be ANDROID || __ANDROID__? &

Re: Fix PR60644

2014-04-09 Thread Alexander Ivchenko
ping.. 2014-04-04 15:28 GMT+04:00 Alexander Ivchenko : > 2014-04-04 14:19 GMT+04:00 Richard Biener : >> On Fri, Apr 4, 2014 at 12:03 PM, Alexander Ivchenko >> wrote: >>> *ping* >> >> I wonder whether this is consistend between compilers (note GCC is not &g

Re: Fix PR60644

2014-04-09 Thread Alexander Ivchenko
AM >> To: Iyer, Balaji V >> Cc: Alexander Ivchenko; Richard Biener; GCC Patches >> Subject: Re: Fix PR60644 >> >> On Wed, Apr 09, 2014 at 01:23:59PM +, Iyer, Balaji V wrote: >> > >> > >> > > -Original Message- >> >

Re: [PATCH] Enable non-complex math builtins from C99 for Bionic

2012-12-13 Thread Alexander Ivchenko
Hello! Could you please take a look at the attached patch that implements the target libc_has_function hook? I didn't change so far the default presence of c99, but rather tried to preserve the current behaviour of TARGET_C99_FUNCTIONS. Thank you, Alexander 2012/12/1 Joseph S. Myers : > On Fri,

[RFC PATCH] Implementing ifunc target hook

2012-12-26 Thread Alexander Ivchenko
Hi, Currently Android dynamic loader does not support indirect functions (And I don't think that it will someday). But there is no way for us to specify that for gcc, and for example, tests like gcc.dg/attr-ifunc-* are failing on android right now. The attached patch is indended to add the target

Re: [PATCH] Function Multiversioning Bug, checking for function versions

2012-12-27 Thread Alexander Ivchenko
I'm sorry - I didn't notice that it works only for c++ frontend. It works for me now! thanks, Alexander 2012/12/27 Sriraman Tallam : > On Thu, Dec 27, 2012 at 2:05 AM, Andreas Schwab wrote: >> diff --git a/gcc/ChangeLog b/gcc/ChangeLog >> index 148388d..575e03a 100644 >> --- a/gcc/ChangeLog >> +

  1   2   >