[PATCH] Pass correct memory attributes for build constant

2014-06-25 Thread Kito Cheng
Hi all: This patch is fix constant memory's symbol_ref don't have right alignment info since `exp` don't set alignment (and should not set alignment info for `exp`) , use `decl` to set_mem_attributes for right alignment info. ChangLog 2014-06-25 Kito Cheng k...@0xlab.org * varasm.c

Re: [PATCH] Pass correct memory attributes for build constant

2014-06-25 Thread Kito Cheng
lr, [sp], #4 bx lr ... On Thu, Jun 26, 2014 at 5:01 AM, Jeff Law l...@redhat.com wrote: On 06/25/14 09:35, Kito Cheng wrote: Hi all: This patch is fix constant memory's symbol_ref don't have right alignment info since `exp` don't set alignment (and should not set alignment

Re: [PATCH] Pass correct memory attributes for build constant

2014-06-30 Thread Kito Cheng
test.c: extern bar(unsigned char p[3][2]); void foo(int i) { unsigned char data[3][2] = {{1,1}, {1,0}, {1,1}}; bar(data); } First, note, I'm not an ARM expert. However, the first question I have is are we sure the initializer is always going to be suitably aligned? What guarantees

[PATCH] Fix typo in comment for IRA

2014-10-13 Thread Kito Cheng
Hi all: This patch contain lots typo fix for IRA module by aspell :) ChangeLog 2014-10-13 Kito Cheng k...@0xlab.org * ira.c: Fix typo in comment. * ira.h: Ditto. * ira-build.c: Ditto. * ira-color.c: Ditto. * ira-emit.c: Ditto. * ira-int.h

Re: [PATCH] Fix typo in comment for IRA

2014-10-13 Thread Kito Cheng
e00ad515d77fd491266b743548f3c0705731fb71 Mon Sep 17 00:00:00 2001 From: Kito Cheng k...@andestech.com Date: Fri, 22 Aug 2014 16:27:18 +0800 Subject: [PATCH] Fix typo in comment for IRA 2014-10-14 Kito Cheng k...@0xlab.org * ira.c: Fix typo in comment. * ira.h: Ditto. * ira-build.c: Ditto. * ira

[PATCH] Prevent out of bound access for multilib_options

2014-04-09 Thread Kito Cheng
`q` will out of bound access if `*q` already reach the end of multilib_options, so check it before increment to prevent condition check part out of bound access. btw, this bug is detected by address sanitizer. 2014-04-09 Kito Cheng k...@0xlab.org * gcc.c (used_arg): Prevent out of bound

Re: [PATCH] Prevent out of bound access for multilib_options

2014-04-09 Thread Kito Cheng
On Wed, Apr 9, 2014 at 10:03 PM, Jakub Jelinek ja...@redhat.com wrote: On Wed, Apr 09, 2014 at 10:00:38PM +0800, Kito Cheng wrote: `q` will out of bound access if `*q` already reach the end of multilib_options, so check it before increment to prevent condition check part out of bound access

Re: [PATCH] Prevent out of bound access for multilib_options

2014-04-09 Thread Kito Cheng
the `if` is not taken at gcc.c:7509 next, `q++` at gcc.c:7493, it's now `q` == multilib_options + strlen(multilib_options) + 1!!! and finally access `*q` for check `*q` != '\0', out of bound access. On Wed, Apr 9, 2014 at 10:21 PM, Kito Cheng kito.ch...@gmail.com wrote: for example: arm-elf-eabi

Re: [PATCH] Prevent out of bound access for multilib_options

2014-04-15 Thread Kito Cheng
Hi Jakub: Thanks your review and approve, however I don't have commit right yet, can you help me to commit it :) And here is updated patch in attachment, thanks! On Mon, Apr 14, 2014 at 8:12 PM, Jakub Jelinek ja...@redhat.com wrote: On Wed, Apr 09, 2014 at 10:00:38PM +0800, Kito Cheng wrote

Re: [PATCH] Change HONOR_REG_ALLOC_ORDER to a marco for C expression

2014-04-15 Thread Kito Cheng
Hi Vladimir: Although this patch is safe. I guess it could wait for stage 1 as right now we don't need this functionality. The patch is ok for the stage1 which is probably about a month away. ping is this patch ok now? thanks:) Thanks for the patch.

Re: [PATCH] Change HONOR_REG_ALLOC_ORDER to a marco for C expression

2014-04-16 Thread Kito Cheng
Hi Vladimir: thanks your replay and approve, however I don't have commit right yet, can you help to commit it? thanks! On Wed, Apr 16, 2014 at 8:10 PM, Vladimir Makarov vmaka...@redhat.com wrote: On 2014-04-15, 9:26 AM, Kito Cheng wrote: Hi Vladimir: Although this patch is safe. I guess

Re: [PATCH] Change HONOR_REG_ALLOC_ORDER to a marco for C expression

2014-05-02 Thread Kito Cheng
Hi Jeff: I fixed up some minor whitespace issues and committed your patch. Thanks for your help :)

[PATCH] Don't call init_caller_save if LRA enabled

2014-06-04 Thread Kito Cheng
LRA generate caller-save register store/restore during split register, not generate by caller-save.c:save_call_clobbered_regs, so initialize this module by init_caller_save is meaningless if LRA enabled 2014-06-05 Kito Cheng k...@0xlab.org * ira.c (ira): Don't call init_caller_save if LRA

[PATCH] Change HONOR_REG_ALLOC_ORDER to a marco for C expression

2014-02-26 Thread Kito Cheng
code size but get worse for performance such as nds32. so I think make it's became a C expression style marco is the solution, let back-end decide when we need HONOR_REG_ALLOC_ORDER instead of decide it during build time. 2014-02-26 Kito Cheng k...@0xlab.org * defaults.h

Re: [PATCH] Change HONOR_REG_ALLOC_ORDER to a marco for C expression

2014-02-26 Thread Kito Cheng
; +full_cost += add_cost; + } + } + if (min_cost cost) min_cost = cost; if (min_full_cost full_cost) On Wed, Feb 26, 2014 at 11:47 PM, Kito Cheng k...@0xlab.org wrote: This patch change the usage for HONOR_REG_ALLOC_ORDER, currently it's can define or not define only

Re: [PATCH] Change HONOR_REG_ALLOC_ORDER to a marco for C expression

2014-03-04 Thread Kito Cheng
Ping. On Thu, Feb 27, 2014 at 12:32 PM, Kito Cheng kito.ch...@gmail.com wrote: Hi all: Sorry for repeat patch content in last mail, here is the clean version for this patch. diff --git a/gcc/config/arm/arm.h b/gcc/config/arm/arm.h index 7ca47a7..1638332 100644 --- a/gcc/config/arm/arm.h

Re: [PATCH] Change HONOR_REG_ALLOC_ORDER to a marco for C expression

2014-03-06 Thread Kito Cheng
Although this patch is safe. I guess it could wait for stage 1 as right now we don't need this functionality. The patch is ok for the stage1 which is probably about a month away. Thanks for the patch. Got it, thanks for your review :) On Thu, Feb 27, 2014 at 12:32 PM, Kito Cheng

[PATCH] Update libgcc.texi to match implementation in libgcc/libgcc2.c

2014-10-27 Thread Kito Cheng
Hi all: This patch update `Bit operations` section in libgcc.text, most bit operation function is take an unsigned integer instead of signed integer in libgcc/libgcc2.c [1], and it seem more make sense :) ChangeLog 2014-10-28 Kito Cheng k...@0xlab.org * doc/libgcc.texi: Update text

Re: [PATCH] Update libgcc.texi to match implementation in libgcc/libgcc2.c

2014-11-04 Thread Kito Cheng
ping! On Tue, Oct 28, 2014 at 11:19 AM, Kito Cheng kito.ch...@gmail.com wrote: Hi all: This patch update `Bit operations` section in libgcc.text, most bit operation function is take an unsigned integer instead of signed integer in libgcc/libgcc2.c [1], and it seem more make sense

[PATCH] Steam out non-explicit -fno-tree-loop-distribute-patterns for LTO options

2014-08-27 Thread Kito Cheng
Hi all: This patch basically is extension for r210100[1], stream out non-explicit -fno-tree-loop-distribute-patterns since compile with `-flto -O3 -fno-builtin` still may gen builtin function call during LTO phase. LTO bootstrapped and tested on x86_64-unknown-linux-gnu. 2014-09-27 Kito Cheng

[PATCH] Don't init ira_spilled_reg_stack_slots in ira if using lra.

2014-08-27 Thread Kito Cheng
Hi all: This patch is clean up useless initialize for IRA with LRA. 2014-08-27 Kito Cheng k...@0xlab.org * ira.c (ira): Don't initialize ira_spilled_reg_stack_slots and ira_spilled_reg_stack_slots_num if using lra. (do_reload): Remove release

Re: [PATCH] Steam out non-explicit -fno-tree-loop-distribute-patterns for LTO options

2014-08-28 Thread Kito Cheng
at 4:42 PM, Kito Cheng kito.ch...@gmail.com wrote: Hi all: This patch basically is extension for r210100[1], stream out non-explicit -fno-tree-loop-distribute-patterns since compile with `-flto -O3 -fno-builtin` still may gen builtin function call during LTO phase. LTO bootstrapped

[PATCH] Move -fbuiltin from c.opt to common.opt and change it to common group

2014-08-28 Thread Kito Cheng
Hi all: -fno-builtin is seem not only for the c family front-end, but also used in LTO now, so move it to common.opt and change it to `Common`. From 47552b58a09ac9d944be1c35bb5c938f4cb8ec0f Mon Sep 17 00:00:00 2001 From: Kito Cheng k...@andestech.com Date: Thu, 14 Aug 2014 11:34:26 +0800 Subject

[PATCH] For -fno-builtin disable pattern recognition if not enabled explicitly in lto.

2014-08-28 Thread Kito Cheng
-08/msg02483.html [2] https://gcc.gnu.org/ml/gcc-patches/2014-08/msg02555.html From 80922e53ff41b1c08322a0d0ae5b6d947cb39353 Mon Sep 17 00:00:00 2001 From: Kito Cheng kito.ch...@gmail.com Date: Thu, 28 Aug 2014 18:06:48 +0800 Subject: [PATCH 2/2] For -fno-builtin disable pattern recognition

Re: [PATCH] Steam out non-explicit -fno-tree-loop-distribute-patterns for LTO options

2014-08-28 Thread Kito Cheng
rguent...@suse.de wrote: On Thu, 28 Aug 2014, Kito Cheng wrote: Hi Richard: I think preserve -fno-builtin is better than -fno-tree-loop-distribute-patterns too, However if we preserve -fno-builtin, the coming problem is should we preserve all -fbuiltin-* and do the check logic[1] in common

Re: [PATCH] Move -fbuiltin from c.opt to common.opt and change it to common group

2014-08-28 Thread Kito Cheng
Hi Richard: -fno-builtin is seem not only for the c family front-end, but also used in LTO now, so move it to common.opt and change it to `Common`. Please leave it in c-family and just add LTO to the set of supported languages. -fno-builtin isn't meaningful for other frontends and we just

Re: [PATCH] Move -fbuiltin from c.opt to common.opt and change it to common group

2014-08-29 Thread Kito Cheng
Hi Richard: -fno-builtin is seem not only for the c family front-end, but also used in LTO now, so move it to common.opt and change it to `Common`. Please leave it in c-family and just add LTO to the set of supported languages. -fno-builtin isn't meaningful for other frontends and we

[PATCH] Add header guard to several header files.

2014-08-31 Thread Kito Cheng
Hi all: This patch is add header guard to several header files :) From 1647c5d3ee3a7e086f57863b2503d11c1a699f00 Mon Sep 17 00:00:00 2001 From: Kito Cheng kito.ch...@gmail.com Date: Fri, 22 Aug 2014 17:34:49 +0800 Subject: [PATCH] Add header guard to several header files. 2014-09-01 Kito Cheng

Re: [PATCH] Add header guard to several header files.

2014-08-31 Thread Kito Cheng
Oops, ChangeLog here: ChangeLog 2014-09-01 Kito Cheng k...@0xlab.org except.h: Fix header guard. addresses.h: Add missing header guard. cfghooks.h: Likewise. collect-utils.h: Likewise. collect2-aix.h: Likewise. conditions.h: Likewise. cselib.h: Likewise

[PATCH] Add missing size directive for arm-*-elf

2014-08-31 Thread Kito Cheng
ld .comment .comment ld .ARM.attributes .ARM.attributes g F .text 0018 foo ChangeLog 2014-09-01 Kito Cheng k...@0xlab.org * config/arm/unknown-elf.h (ASM_OUTPUT_ALIGNED_DECL_LOCAL): Add size directive. From

Re: [PATCH] Add header guard to several header files.

2014-09-01 Thread Kito Cheng
Hi Joseph: Thanks for your review, I've reverted the part of gsyslimits.h, here is updated patch and ChangeLog :) bootstrap ok for x86_64 2014-09-01 Kito Cheng k...@0xlab.org except.h: Fix header guard. addresses.h: Add missing header guard. cfghooks.h: Likewise. collect

Re: [PATCH] Don't init ira_spilled_reg_stack_slots in ira if using lra.

2014-09-03 Thread Kito Cheng
ping! On Wed, Aug 27, 2014 at 10:49 PM, Kito Cheng kito.ch...@gmail.com wrote: Hi all: This patch is clean up useless initialize for IRA with LRA. 2014-08-27 Kito Cheng k...@0xlab.org * ira.c (ira): Don't initialize ira_spilled_reg_stack_slots

Re: [PATCH] Add header guard to several header files.

2014-09-08 Thread Kito Cheng
ping! On Tue, Sep 2, 2014 at 12:37 AM, Kito Cheng kito.ch...@gmail.com wrote: Hi Joseph: Thanks for your review, I've reverted the part of gsyslimits.h, here is updated patch and ChangeLog :) bootstrap ok for x86_64 2014-09-01 Kito Cheng k...@0xlab.org except.h: Fix header guard

Re: [PATCH] Add missing size directive for arm-*-elf

2014-09-08 Thread Kito Cheng
ping! On Mon, Sep 1, 2014 at 11:30 AM, Kito Cheng kito.ch...@gmail.com wrote: Hi all: In arm-*-elf target some variable will missing size directive, for example: foo.c: void foo (void) { static char bufbuf[8]; } $ arm-none-eabi-gcc ./foo.c -S -o - ... .align 2 bufbuf.4078

Re: [PATCH] Add missing size directive for arm-*-elf

2014-09-09 Thread Kito Cheng
On Tue, Sep 9, 2014 at 10:06 PM, Andreas Schwab sch...@suse.de wrote: Kito Cheng kito.ch...@gmail.com writes: .align 2 bufbuf.4078: .space 8 ... .ident GCC: (GNU) 5.0.0 20140828 (experimental) And then the size info will missing: $ arm-none-eabi-objdump ./foo.o -t ./foo.o: file

Re: [PATCH] Add header guard to several header files.

2014-09-17 Thread Kito Cheng
Updated patch On Wed, Sep 17, 2014 at 9:17 PM, Kito Cheng kito.ch...@gmail.com wrote: Updated patch On Mon, Sep 8, 2014 at 9:46 PM, Kito Cheng kito.ch...@gmail.com wrote: ping! On Tue, Sep 2, 2014 at 12:37 AM, Kito Cheng kito.ch...@gmail.com wrote: Hi Joseph: Thanks for your review

Re: [PATCH] Add header guard to several header files.

2014-09-18 Thread Kito Cheng
Hi Joseph: Here is updated patch and ChangeLog, However I don't have commit write yet, can you help me to commit it? thanks btw, I has already signed FSF agreement:) 2014-09-19 Kito Cheng k...@0xlab.org except.h: Fix header guard. addresses.h: Add missing header guard

Fwd: [PATCH] Prevent crash when expand movstr fail when movstr pattern is defined

2014-01-10 Thread Kito Cheng
of expand_insn, check it done or not and just return NULL_RTX for generate a libcall if fail to expand movstr. 2014-01-11 Kito Cheng k...@0xlab.org * gcc/builtins.c (expand_movstr): Check movstr expand done or fail. diff --git a/gcc/builtins.c b/gcc/builtins.c index e3c32a9..fca51a1

Re: Patch committed: Fix ChangeLog entry

2014-01-21 Thread Kito Cheng
Thanks :) On Wed, Jan 22, 2014 at 1:15 AM, Richard Sandiford rsand...@linux.vnet.ibm.com wrote: Ian Lance Taylor i...@google.com writes: This patch moves to the gcc/ChangeLog file a gcc ChangeLog entry that was incorrectly added to the top-level ChangeLog file. Changes to ChangeLog files do

[PATCH] Remove CALLER_SAVE_PROFITABLE since nobody use it now

2014-08-18 Thread Kito Cheng
Hi all: This patch clean up CALLER_SAVE_PROFITABLE marco include doc since seem nobody use it. Bootstrap and regression testing running on x86_64-unknown-linux-gnu :) ChangLog 2014-08-18 Kito Cheng k...@0xlab.org * doc/tm.texi.in (CALLER_SAVE_PROFITABLE): Remove. * gcc/doc

[PATCH] Fix comment typo in ira.c

2014-08-18 Thread Kito Cheng
Hi Vladimir: Here is a tiny typo in comment, allono - allocno. ChangLog 2014-08-18 Kito Cheng k...@0xlab.org * ira.c: Fix typo in comment.

Re: [PATCH] Fix comment typo in ira.c

2014-08-18 Thread Kito Cheng
Oops, I forgot to attach patch in the previous mail. On Mon, Aug 18, 2014 at 10:51 PM, Kito Cheng kito.ch...@gmail.com wrote: Hi Vladimir: Here is a tiny typo in comment, allono - allocno. ChangLog 2014-08-18 Kito Cheng k...@0xlab.org * ira.c: Fix typo in comment. From

Re: [PATCH] Remove CALLER_SAVE_PROFITABLE since nobody use it now

2014-08-19 Thread Kito Cheng
then. (It should of course be poisoned in system.h when removing it, as standard when removing target macros.) Thanks, I add poison for CALLER_SAVE_PROFITABLE to system.h, updated patch attached. thanks for your review :) ChangLog 2014-08-19 Kito Cheng k...@0xlab.org * system.h

[PATCH] LRA: Fix caller-save store/restore instruction for large mode

2015-01-04 Thread Kito Cheng
for this on IRC, so I don't send the patch last year, however ARM guys seem got this problem too, so I think it's time to send this patch :) ChangeLog 2015-01-05 Kito Cheng k...@0xlab.org * lra-constraints.c (split_reg): Fix caller-save store/restore instruction generation. From

Re: [PATCH] LRA: Fix caller-save store/restore instruction for large mode

2015-01-07 Thread Kito Cheng
Hi Jeff: It's updated patch,bootstrapped and run regression tested on arm-eabi, arm-none-linux-uclibcgnueabi, x86_64-unknown-linux-gnu and nds32le-elf without introducing regression. Thanks for your review :) 2015-01-07 Kito Cheng k...@0xlab.org PR target/64348 * lra

Re: [PATCH] LRA: Fix caller-save store/restore instruction for large mode

2015-01-08 Thread Kito Cheng
Hi Jeff: After discussion with Bin, he prefer just use gcc.c-torture/execute/scal-to-vec1.c instead of introduce new one, do you have any further comment on this patch? On Thu, Jan 8, 2015 at 9:29 AM, Bin.Cheng amker.ch...@gmail.com wrote: On Wed, Jan 7, 2015 at 8:28 PM, Kito Cheng kito.ch

Re: [PATCH] LRA: Fix caller-save store/restore instruction for large mode

2015-01-07 Thread Kito Cheng
into gcc.target/arm/ :) /* { dg-do compile } */ /* { dg-options -O3 -fPIC -marm -mcpu=cortex-a8 } */ On Wed, Jan 7, 2015 at 4:50 PM, Bin.Cheng amker.ch...@gmail.com wrote: On Wed, Jan 7, 2015 at 4:03 PM, Kito Cheng kito.ch...@gmail.com wrote: Hi Jeff: It's updated patch,bootstrapped and run regression

Re: [patch] fix regrename pass to ensure renamings produce valid insns

2015-06-29 Thread Kito Cheng
Hi all: This patch seem will broken when disable assert checking for c6x Index: gcc/config/c6x/c6x.c === --- gcc/config/c6x/c6x.c (revision 225104) +++ gcc/config/c6x/c6x.c (working copy) @@ -3516,7 +3516,7 @@

Drop -Wswitch-bool warning in function.c

2015-07-08 Thread Kito Cheng
Bootstrapped regression-tested on x86_64-linux-gnu :) 2015-07-08 Kito Cheng kito.ch...@gmail.com * function.c (stack_protect_epilogue): Use if rather than switch for check targetm.have_stack_protect_test(). From 0306990aac578167872a80ab55085d335e2bea14 Mon Sep 17 00:00:00 2001

Re: Drop -Wswitch-bool warning in function.c

2015-07-08 Thread Kito Cheng
, Jul 8, 2015 at 9:30 PM, Marek Polacek pola...@redhat.com wrote: On Wed, Jul 08, 2015 at 04:49:19PM +0800, Kito Cheng wrote: Bootstrapped regression-tested on x86_64-linux-gnu :) 2015-07-08 Kito Cheng kito.ch...@gmail.com * function.c (stack_protect_epilogue): Use if rather than

Re: Drop -Wswitch-bool warning in function.c

2015-07-08 Thread Kito Cheng
Hi Jeff: Thanks your review and approve, however I don't have commit right yet, can you help me to commit it :) thanks On Thu, Jul 9, 2015 at 5:00 AM, Jeff Law l...@redhat.com wrote: On 07/08/2015 02:49 AM, Kito Cheng wrote: Bootstrapped regression-tested on x86_64-linux-gnu :) 2015-07-08

Re: Init df for split pass since some target use REG_NOTE in split pattern

2016-07-25 Thread Kito Cheng
mode, offset); operands[1] = simplify_gen_subreg ( SImode, operands[1], DImode, offset); }) On Tue, Jul 26, 2016 at 3:48 AM, Jeff Law <l...@redhat.com> wrote: > On 07/25/2016 12:35 PM, Richard Biener wrote: >> >> On July 25, 2016 5:56:29 PM GMT+02:00, Jeff

Init df for split pass since some target use REG_NOTE in split pattern

2016-07-25 Thread Kito Cheng
Hi all: Some target(for example i386, sh and h8300) use find_regno_note in split pattern but df infrastructure seem not initialize at split pass, so it may got wrong note since it's out-of-date. ChangeLog 2016-07-25 Kito Cheng <kito.ch...@gmail.com> * gcc/recog.c (split_all

Re: Init df for split pass since some target use REG_NOTE in split pattern

2016-07-27 Thread Kito Cheng
Hi Jeff: > This seems better suited as a generic optimization than hidden away in a > backend. > > AFAICT you're just noticing a word of the output operand is dead and eliding > the load/store for that word. > > In fact, I'm a bit surprised nothing has optimized this away by the time > reload/LRA

Re: Init df for split pass since some target use REG_NOTE in split pattern

2016-08-09 Thread Kito Cheng
Hi Steven: You are right, I have build arm toolchain today, it's crash when building libgcc since there is no valid CFG in split_all_insns_noflow. Hi Jeff: Maybe we need split_reg_dead_p and split_reg_unused_p like peephole2 have peep2_reg_dead_p? On Wed, Aug 10, 2016 at 3:54 AM, Steven

Check fpic is ok for target in pr69102.c

2016-07-05 Thread Kito Cheng
Hi all: pr69102.c use -fPIC flag in dg-options but not check is available for target, so I add "dg-require-effective-target fpic" for it. ChangeLog 2016-07-05 Kito Cheng <kito.ch...@gmail.com> * gcc.c-torture/compile/pr69102.c: Require fp

Re: Check fpic is ok for target in pr69102.c

2016-07-05 Thread Kito Cheng
Hi Mike: thanks for your review :) On Wed, Jul 6, 2016 at 2:54 AM, Mike Stump <m...@mrs.kithrup.com> wrote: > On Jul 5, 2016, at 1:39 AM, Kito Cheng <kito.ch...@gmail.com> wrote: >> >> pr69102.c use -fPIC flag in dg-options but not check is available for >> targe

Re: [PATCH] PR79079 Fix __builtin_mul_overflow code gen for !TRULY_NOOP_TRUNCATION target

2017-01-17 Thread Kito Cheng
Hi Jakub: Got it, thanks, however I don't have commit right yet, can you commit it? On Tue, Jan 17, 2017 at 6:13 PM, Jakub Jelinek <ja...@redhat.com> wrote: > On Tue, Jan 17, 2017 at 06:09:29PM +0800, Kito Cheng wrote: >> Hi Jakub: >> >> Thanks for your review, attach

Re: [PATCH] PR79079 Fix __builtin_mul_overflow code gen for !TRULY_NOOP_TRUNCATION target

2017-01-17 Thread Kito Cheng
-branch ? gcc/ChangeLog: 2017-01-16 Kito Cheng <kito.ch...@gmail.com> Kuan-Lin Chen <kuanlinche...@gmail.com> PR target/PR79079 * internal-fn.c (expand_mul_overflow): Use convert_modes instead of gen_lowpart. On Mon, Jan 16, 2017 at 6:13 PM, Mat

Re: [PATCH] Fix PR78230

2016-11-08 Thread Kito Cheng
This change also verified with gcc 6.1 and 5.4 it can pass with gcc 6.1 and make gcc 5.4 ICE after this change. On Wed, Nov 9, 2016 at 10:43 AM, Kito Cheng <kito.ch...@gmail.com> wrote: > gcc/testsuite/ChangeLog: > > 2016-11-09 Kito Cheng <kito.ch...@gmail.com> > &

[PATCH] Fix PR78230

2016-11-08 Thread Kito Cheng
gcc/testsuite/ChangeLog: 2016-11-09 Kito Cheng <kito.ch...@gmail.com> PR target/78230 * gcc.dg/torture/pr66178.c (test): Use uintptr_t instead of int. (test2) Ditto. From 73ff22745720ecfc2a33148f68ff7e0f36c1144b Mon Sep 17 00:00:00 2001 From: Kito Cheng &l

Re: [PATCH] Fix PR78230

2016-11-22 Thread Kito Cheng
Hi Jeff: Thanks your review and approve, however I don't have commit right yet, can you help me to commit it :) thanks On Wed, Nov 23, 2016 at 1:04 AM, Jeff Law <l...@redhat.com> wrote: > > On 11/08/2016 07:43 PM, Kito Cheng wrote: >> >> gcc/testsuite/ChangeLog: >

[PATCH] PR79079 Fix __builtin_mul_overflow code gen for !TRULY_NOOP_TRUNCATION target

2017-01-15 Thread Kito Cheng
-12.c/builtin-arith-overflow-p-12.c and no introduce new regression on x86-64 and riscv32 gcc/ChangeLog: 2017-01-16 Kito Cheng <kito.ch...@gmail.com> Kuan-Lin Chen <kuanlinche...@gmail.com> PR target/PR79079 * gcc/internal-fn.c (expand_mul_ov

Re: [PATCH] Add RISC-V Maintainers

2017-03-19 Thread Kito Cheng
ping. On Thu, Feb 9, 2017 at 2:50 AM, Palmer Dabbelt <pal...@dabbelt.com> wrote: > 2017-02-08 Palmer Dabbelt <pal...@dabbelt.com> > > * MAINTAINERS (CPU Port Maintainers): Add Kito Cheng, Palmer Dabbelt, > and Andrew Waterman as the RISC-V maintainers.

Re: FIx riscv port building with the trunk

2017-03-13 Thread Kito Cheng
Hi Jeff: It's make older gcc version can't build RISC-V port, how about use gcc_fallthrough instead? diff --git a/gcc/config/riscv/riscv.c b/gcc/config/riscv/riscv.c index f4c1f23..d1af07f5 100644 --- a/gcc/config/riscv/riscv.c +++ b/gcc/config/riscv/riscv.c @@ -2089,13 +2089,13 @@

Re: [PATCH] [RISCV] Add RTEMS support

2017-07-27 Thread Kito Cheng
Hi Sebastian: LGTM, I've test riscv32-rtems-gcc is buildable. Thanks for you patch :) Hi Palmer: Could you help to commit this patch ? Thanks. On Thu, Jul 27, 2017 at 7:05 PM, Sebastian Huber wrote: > gcc/ > * config.gcc (riscv*-*-elf*): Add

Re: [patches] Re: [PATCH] RISC-V: Implement __umulsidi3, umul_ppmm and __muluw3

2017-11-19 Thread Kito Cheng
>> 2017-11-17 Kito Cheng <kito.ch...@gmail.com> >> >> * longlong.h [__riscv] (__umulsidi3): Define. >> [__riscv] (umul_ppmm) Likewise. >> [__riscv] (__muluw3) Likewise. > > > Apparently the point of this is that by definin

Re: [PATCH] RISC-V: Fix interrupt support for -g.

2018-07-02 Thread Kito Cheng
Hi Jim: Does it possible just combine those pattern into simple_return pattern, and then check the function type and output correct return instruction in riscv_output_return? On Tue, Jul 3, 2018 at 8:22 AM Jim Wilson wrote: > > This fixes a problem found by someone trying to use the new RISC-V

Re: [PATCH] RISC-V: Fix interrupt support for -g.

2018-07-02 Thread Kito Cheng
Hi Jim: It's no problem with current approach, I just think it can simplify the .md file. Thanks :) On Tue, Jul 3, 2018 at 11:22 AM Jim Wilson wrote: > > On Mon, Jul 2, 2018 at 8:04 PM, Kito Cheng wrote: > > Does it possible just combine those pattern into simple_return

[PATCH] RISC-V: Support for FreeBSD

2018-01-28 Thread Kito Cheng
Hi all: This patch enable RISC-V support FreeBSD, Ruslan (RISC-V FreeBSD maintainer) and me has been tested on FreeBSD 12 for building kernel and whole user space programs/libraries. gcc/ChangeLog 2018-01-29 Ruslan Bukin <b...@bsdpad.com> Kito Cheng <kito.ch...@

Re: [patches] Re: [PATCH] RISC-V: Support for FreeBSD

2018-01-29 Thread Kito Cheng
luded in the > patch. Oh, okay, I guess it's something port from older freebsd riscv-gcc, I should update that, thanks. On Tue, Jan 30, 2018 at 4:28 AM, Jim Wilson <j...@sifive.com> wrote: > On 01/28/2018 07:26 PM, Kito Cheng wrote: >> >> gcc/ChangeLog >

[PATCH v2] RISC-V: Support for FreeBSD

2018-02-17 Thread Kito Cheng
...@gnu.org again. gcc/ChangeLog 2018-01-29 Ruslan Bukin <b...@bsdpad.com> Kito Cheng <kito.ch...@gmail.com> * config.gcc (riscv*-*-freebsd*): New. * config/riscv/freebsd.h: New. libgcc/ChangeLog 2018-01-29 Ruslan Bukin <b...@bsdpad.com>

Re: [PATCH v2] RISC-V: Support for FreeBSD

2018-02-21 Thread Kito Cheng
Hi Jim: > I saw the email. I checked the FSF copyright list and see that it > hasn't been recorded yet. The FSF copyright clerk sometimes takes a > few weeks to respond. Hopefully this will be competed on the FSF side > soon. I don't family with copyright matters, so we can't commit this

[PATCH] RISC-V: Report error if function declare with different

2018-07-06 Thread Kito Cheng
Hi all: This patch implemented TARGET_MERGE_DECL_ATTRIBUTES hook to check the interrupter is all compatible, tested with rv32ima and rv64ima elf toolchain. gcc/ChangeLog 2018-07-06 Kito Cheng * config/riscv/riscv.c (enum riscv_privilege_levels): Add UNKNOWN_MODE

Re: [PATCH] RISC-V: Report error if function declare with different

2018-07-12 Thread Kito Cheng
ping. On Fri, Jul 6, 2018 at 4:38 PM Kito Cheng wrote: > > Hi all: > > This patch implemented TARGET_MERGE_DECL_ATTRIBUTES hook to check the > interrupter is all compatible, tested with rv32ima and rv64ima elf > toolchain. > > gcc/ChangeLog > 2018-07-06 Kito Cheng

Re: [PATCH v2] RISC-V: Support for FreeBSD

2018-04-05 Thread Kito Cheng
Hi Jim: Theodore Teah sent an mail say "Your assignment/disclaimer process with the FSF is currently complete.". Could you help us to commit that? Thanks :) On Fri, Feb 23, 2018 at 2:33 AM, Jim Wilson <j...@sifive.com> wrote: > On Wed, Feb 21, 2018 at 10:34 PM, Kito Cheng &l

[PATCH] RISC-V: Make sure stack is always aligned during adjusting

2018-04-18 Thread Kito Cheng
-6.c -O2 -ffast-math -floop-nest-opt imize -o - -S ... .type main, @function main: li t1,-81920 addisp,sp,-36 # <-- stack not aligned here! ... gcc/ChangeLog: 2018-04-18 Kito Cheng <kito.ch...@gmail.com> * config/riscv/riscv.c (riscv_first_s

[PATCH] RISC-V: Pass --no-relax to linker if -mno-relax is present.

2018-04-18 Thread Kito Cheng
Hi all: Palmer has been added -mno-relax option before, I propose it should also pass to linker during link phase. ChangeLog: 2018-04-18 Kito Cheng <kito.ch...@gmail.com> * config/riscv/elf.h (LINK_SPEC): Pass --no-relax if -mno-relax is present. * config/riscv/l

[PATCH v2] RISC-V: Make sure stack is always aligned during adjusting

2018-04-19 Thread Kito Cheng
It's v2 patch for fixing stack align for rv32*c target. gcc/ChangeLog: 2018-04-18 Kito Cheng <kito.ch...@gmail.com> * config/riscv/riscv.c (riscv_first_stack_step): Round up min step to make sure stack always aligned. v1: https://gcc.gnu.org/ml/gcc-patches/2018-04/ms

Re: [patches] Re: [PATCH] RISC-V: Pass --no-relax to linker if -mno-relax is present.

2018-04-18 Thread Kito Cheng
in the latest release yet? On Thu, Apr 19, 2018 at 8:51 AM, Jim Wilson <j...@sifive.com> wrote: > On Wed, Apr 18, 2018 at 3:10 AM, Kito Cheng <kito.ch...@gmail.com> wrote: >> * config/riscv/elf.h (LINK_SPEC): Pass --no-relax if >> -mno-relax is present. >>

Re: [patches] Re: [PATCH] Update soft-fp from glibc.

2018-11-07 Thread Kito Cheng
Hi Joseph: I don't have commit right, could you help me to commit that, thanks :) On Thu, Nov 8, 2018 at 1:14 AM Joseph Myers wrote: > > This patch is OK. > > -- > Joseph S. Myers > jos...@codesourcery.com

[PATCH] Update soft-fp from glibc.

2018-11-07 Thread Kito Cheng
. - 69a01461ee1417578d2ba20aac935828b50f1118 soft-fp/extended.h soft-fp/half.h soft-fp/single.h soft-fp/double.h soft-fp/quad.h - Do not use packed structures in soft-fp. - 049375e2b5fc707436fd5d80337c253beededb2d libgcc/ChangeLog 2018-11-07 Kito Cheng * soft-fp/adddf3.c: Update from glibc

Re: [PATCH] RISC-V: Fix unordered float compare for Signaling NaN.

2018-10-02 Thread Kito Cheng
Wilson wrote: > > On Tue, Oct 2, 2018 at 7:23 PM Kito Cheng wrote: > > This patch is fixing the wrong behavior for unordered float compare > > for Signaling NaN, current implementation will suppress the FP > > exception flags unconditionally, however signaling NaN should

[PATCH] RISC-V: Fix unordered float compare for Signaling NaN.

2018-10-02 Thread Kito Cheng
Kito Cheng gcc/ * config/riscv/riscv.md (f_quiet4): Handle signaling NaN correctly. testsuite/gcc.target/riscv/fcompare_snan.c: New file. --- gcc/config/riscv/riscv.md | 41 - .../gcc.target/riscv/fcompare_snan.c | 45 +++ 2

[PATCH 2/7] [NDS32] Fix testsuite for nds32 target

2019-03-25 Thread Kito Cheng
From: Kito Cheng Chung-Ju Wu Shiva Chen ChangeLog: gcc/testsuite/ * gcc.c-torture/execute/20010122-1.c: Add -malways-save-lp for nds32. * gcc.c-torture/execute/pr60822.c: Add -mcmodel=large for nds32. * gcc.c-torture/execute/pr79286.c: Ditto

[PATCH 1/7] [NDS32] Provide one valid nds32 assembly instruction to check assembler debugging options and features.

2019-03-25 Thread Kito Cheng
From: Chung-Ju Wu Chung-Ju Wu ChangeLog gcc/ * configure.ac: Add nds32 target for dwarf2 debug_line checking. * configure: Regenerated. --- gcc/configure| 2 +- gcc/configure.ac | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/configure

[PATCH 3/7] [NDS32] Rewrite PIC/TLS patterns.

2019-03-25 Thread Kito Cheng
From: Monk Chiang Monk Chiang Kito Cheng Shiva Chen ChangeLog gcc/ * config/nds32/nds32-md-auxiliary.c (nds32_legitimize_pic_address): Use new PIC pattern. (nds32_legitimize_tls_address): Use new TLS pattern. (nds32_output_symrel): New. * config

[PATCH 5/7] [NDS32] Refine force unwind, linux kernel only using RT_SIGRETURN.

2019-03-25 Thread Kito Cheng
From: Monk Chiang Monk Chiang ChangeLog libgcc/ * config/nds32/linux-unwind.h (SIGRETURN): Remove. (RT_SIGRETURN): Update. (nds32_fallback_frame_state): Update. --- libgcc/config/nds32/linux-unwind.h | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff

[PATCH 4/7] [NDS32] nds32*-linux target using init_array/finit_array for ctor/dtor.

2019-03-25 Thread Kito Cheng
From: Monk Chiang Monk Chiang ChangeLog * config.gcc (nds32*-*-linux*): Set gcc_cv_initfini_array to yes. --- gcc/config.gcc | 1 + 1 file changed, 1 insertion(+) diff --git a/gcc/config.gcc b/gcc/config.gcc index 3eb2e80..a6d63dd 100644 --- a/gcc/config.gcc +++ b/gcc/config.gcc @@

[PATCH 7/7] [NDS32] Fix nds32_split_ashiftdi3 with large shift amount

2019-03-25 Thread Kito Cheng
From: Kito Cheng Kito Cheng Shiva Chen ChangeLog: gcc/ * config/nds32/nds32-md-auxiliary.c (nds32_split_ashiftdi3): Fix wrong code gen with large shift amount. gcc/testsuite/ * gcc.target/nds32/ashiftdi3.c: New. --- gcc/config/nds32/nds32-md-auxiliary.c | 21

[PATCH 6/7] [NDS32] Handle subreg correctly in wext_odd_dep_p.

2019-03-25 Thread Kito Cheng
From: Kito Cheng Kito Cheng Shiva Chen ChangeLog: gcc/ * config/nds32/nds32-pipelines-auxiliary.c (wext_odd_dep_p): Handle subreg. gcc/testsuite * gcc.target/nds32/wext-dep.c: New. --- gcc/config/nds32/nds32-pipelines-auxiliary.c | 16 gcc

[PATCH v2 1/2] RISC-V: Accept version, supervisor ext and more than one NSE for -march.

2019-02-26 Thread Kito Cheng
From: Kito Cheng Kito Cheng Monk Chiang ChangeLog: gcc: * common/config/riscv/riscv-common.c: Include config/riscv/riscv-protos.h. (INCLUDE_STRING): Defined. (RISCV_DONT_CARE_VERSION): Defined. (riscv_subset_t): Declare. (riscv_subset_t

[PATCH v2 0/2] RISC-V: Support ELF attribute for GCC

2019-02-26 Thread Kito Cheng
This version 2 of patch series for of RISC-V ELF attribute[1], first version can be found in[2-4]. Most changes between last version is typo fixing and coding sytle fix, and a missing re-generated configure file. [1] https://github.com/riscv/riscv-elf-psabi-doc/pull/71 [2] [PATCH 0/2] RISC-V:

[PATCH v2 2/2] RISC-V: Support ELF attribute

2019-02-26 Thread Kito Cheng
From: Kito Cheng This patch added a configure time option, --with-riscv-attribute=[yes|no|default], run time option, -mriscv-attribute to control the output of ELF attribute. This feature is only enabled by default for ELF/Bare mental target configuration. Kito Cheng Monk Chiang

[PATCH] [NDS32] Fix nds32_split_ashiftdi3 with large shift amount

2019-02-22 Thread Kito Cheng
From: Kito Cheng ChangeLog: gcc/ * config/nds32/nds32-md-auxiliary.c (nds32_split_ashiftdi3): Fix wrong code gen with large shift amount. --- gcc/config/nds32/nds32-md-auxiliary.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/gcc

[PATCH] RISC-V: Update testcase.

2019-03-18 Thread Kito Cheng
From: Kito Cheng gcc.target/riscv/arch-1.c getting failed after r269586, because it wrapping all option names in gcc internal messages with %< and %>, it make option name will print with single quote, and then mis-match the result in the test case. gcc/testsuite: Kito Cheng Cha

[PATCH 1/2] RISC-V: Accept version, supervisor ext and more than one NSE for -march.

2019-02-12 Thread Kito Cheng
From: Kito Cheng Kito Cheng Monk Chiang ChangeLog: gcc: * common/config/riscv/riscv-common.c: Include config/riscv/riscv-protos.h. (INCLUDE_STRING): Defined. (RISCV_DONT_CARE_VERSION): Defined. (riscv_subset_t): Declare. (riscv_subset_list

[PATCH 2/2] RISC-V: Support ELF attribute

2019-02-12 Thread Kito Cheng
From: Kito Cheng This patch added a configure time option, --with-riscv-attribute=[yes|no|default], run time option, -mriscv-attribute to control the output of ELF attribute. This feature is only enabled by default for ELF/Bare mental target configuration. Kito Cheng Monk Chiang ChangeLog

[PATCH 0/2] RISC-V: Support ELF attribute for GCC.

2019-02-12 Thread Kito Cheng
This patch series is implementation of RISC-V ELF attribute[1], it consists of two part, first part is improve the -march string parser, in order to support arch string with version and all kind of extension in the RISC-V ISA spec v2.2[2], and second part is attribute directive generation,

[PATCH, committed] Add myself to MAINTAINERS

2019-07-08 Thread Kito Cheng
ChangeLog: 2019-07-08 Kito Cheng * MAINTAINERS (Write After Approval): Add myself. --- MAINTAINERS (revision 273194) +++ MAINTAINERS (revision 273195) @@ -651,6 +651,7 @@ Jon Ziegler Roman Zippel Josef Zlomek

  1   2   >