RE: [PATCH] [ARC] New option handling, refurbish multilib support.

2016-11-15 Thread Claudiu Zissulescu
> This looks fine. Thanks for all your effort revising this patch. > > Andrew > Committed r242425. Thank you for your review, Claudiu

RE: [PATCH] [ARC] New option handling, refurbish multilib support.

2016-11-14 Thread Claudiu Zissulescu
> HEAD binutils supports '.cpu NPS400' and HEAD GCC also correctly emits > '.cpu NPS400' (when -mcpu=nps400 is passed). After your change we no > longer correctly emit '.cpu NPS400'. > Sorry for this miss-understanding. Updating the patch to emit .cpu NSPS400. Thanks, Claudiu

Re: [PATCH] [ARC] New option handling, refurbish multilib support.

2016-11-14 Thread Andrew Burgess
* Claudiu Zissulescu [2016-11-10 12:02:34 +0100]: > Hi, > > Please find the revised patch which includes the refurbishing of > mmpy-option option, and a new comment on DEFAULT_arc_fpu_build > define. As for the last suggestion, my proposal is to have a latter >

RE: [PATCH] [ARC] New option handling, refurbish multilib support.

2016-11-04 Thread Claudiu Zissulescu
Andrew, > you create the TargetVariable arc_mpy_option, however, I think it > would be neater to fold this variable into the mmpy-option as it was > before, but, changing the type to Enum. This would allow the big > option checking switch to be removed from arc-common.c, which I think > is a win

Re: [PATCH] [ARC] New option handling, refurbish multilib support.

2016-11-03 Thread Andrew Burgess
* Claudiu Zissulescu [2016-10-31 16:46:17 +0100]: > Please find the updated patch. > > What is new: > - The .def files are having a comment block on how to add new lines. > - The arc_seen_option is not used. > - The arc_cpu* variables are not used. > > Please

RE: [PATCH] [ARC] New option handling, refurbish multilib support.

2016-10-13 Thread Claudiu Zissulescu
Hi Andrew, > Sorry it's taken s long to review this patch. > This is understandable, it is a quite large patch and changes a lot of items. > In general I like this, and think it's a step in the right direction. > I have a few pretty minor concerns, but hopefully nothing too > contentious. >

Re: [PATCH] [ARC] New option handling, refurbish multilib support.

2016-10-12 Thread Andrew Burgess
* Claudiu Zissulescu [2016-10-10 15:26:47 +0200]: > Hi Andrew, > > This is updated patch of the original sent to mailing list some while ago. > > What is new: > - Do not use MULTILIB_REUSE as its semantic changed, and the old one was > causing issues