Re: [PATCH v4] PR preprocessor/83173: Enhance -fdump-internal-locations output

2018-11-27 Thread David Malcolm
On Tue, 2018-11-27 at 14:37 +, Mike Gulick wrote: > On 11/27/18 9:27 AM, David Malcolm wrote: > > [...] > > > > > I can commit them for you if you like. Please can you repost the > > latest version of the patches as one kit, for clarity, so I can > > commit > > them. > > > > Do you want

Re: [PATCH v4] PR preprocessor/83173: Enhance -fdump-internal-locations output

2018-11-27 Thread Mike Gulick
On 11/27/18 9:27 AM, David Malcolm wrote: [...] > > I can commit them for you if you like. Please can you repost the > latest version of the patches as one kit, for clarity, so I can commit > them. > Do you want me to repost them as a patch series, or as a single patch? > Thanks > Dave >

Re: [PATCH v4] PR preprocessor/83173: Enhance -fdump-internal-locations output

2018-11-27 Thread David Malcolm
On Tue, 2018-11-27 at 14:10 +, Mike Gulick wrote: > On 11/26/18 8:29 PM, David Malcolm wrote: > > On Mon, 2018-11-26 at 22:17 +, Mike Gulick wrote: > > > On 11/13/18 3:12 PM, David Malcolm wrote: > > > > On Tue, 2018-11-13 at 14:54 -0500, Mike Gulick wrote: > > > > > 2018-11-13 Mike

Re: [PATCH v4] PR preprocessor/83173: Enhance -fdump-internal-locations output

2018-11-27 Thread Mike Gulick
On 11/26/18 8:29 PM, David Malcolm wrote: > On Mon, 2018-11-26 at 22:17 +, Mike Gulick wrote: >> On 11/13/18 3:12 PM, David Malcolm wrote: >>> On Tue, 2018-11-13 at 14:54 -0500, Mike Gulick wrote: 2018-11-13 Mike Gulick >>> >>> [...] >>> * gcc/diagnostic-core.h (num_digits):

Re: [PATCH v4] PR preprocessor/83173: Enhance -fdump-internal-locations output

2018-11-26 Thread David Malcolm
On Mon, 2018-11-26 at 22:17 +, Mike Gulick wrote: > On 11/13/18 3:12 PM, David Malcolm wrote: > > On Tue, 2018-11-13 at 14:54 -0500, Mike Gulick wrote: > > > 2018-11-13 Mike Gulick > > > > [...] > > > > > * gcc/diagnostic-core.h (num_digits): Add extern definition. > > > > FWIW you

Re: [PATCH v4] PR preprocessor/83173: Enhance -fdump-internal-locations output

2018-11-26 Thread Mike Gulick
On 11/13/18 3:12 PM, David Malcolm wrote: > On Tue, 2018-11-13 at 14:54 -0500, Mike Gulick wrote: >> 2018-11-13 Mike Gulick > > [...] > >> * gcc/diagnostic-core.h (num_digits): Add extern definition. > > FWIW you moved the decl to diagnostic.h, but didn't update the above > ChangeLog

Re: [PATCH v4] PR preprocessor/83173: Enhance -fdump-internal-locations output

2018-11-13 Thread David Malcolm
On Tue, 2018-11-13 at 14:54 -0500, Mike Gulick wrote: > 2018-11-13 Mike Gulick [...] > * gcc/diagnostic-core.h (num_digits): Add extern definition. FWIW you moved the decl to diagnostic.h, but didn't update the above ChangeLog entry. [...] > diff --git a/libcpp/location-example.txt