Re: [Patch, Fortran] PR 84273: Reject allocatable passed-object dummy argument (proc_ptr_47.f90)
2018-02-12 8:22 GMT+01:00 Richard Biener : >> 2018-02-10 0:21 GMT+01:00 Steve Kargl : >> > On Fri, Feb 09, 2018 at 06:13:34PM +0100, Janus Weil wrote: >> >> >> >> the attached patch fixes some checking code for PASS arguments in >> >> procedure-pointer components, which does not properly account for the >> >> fact that the PASS argument needs to be polymorphic. >> >> >> >> [The reason for this issue is probably that PPCs were mostly >> >> implemented before polymorphism was available. The corresponding >> >> pass-arg checks for TBPs are ok.] >> >> >> >> The patch also fixes an invalid test case (which was detected thanks >> >> to Neil Carlson). It regtests cleanly on x86_64-linux-gnu. Ok for >> >> trunk? >> > >> > The patch looks ok to me. Trunk is in regression and doc >> > fixes only mode, so you'll probably need to ping Jakub or >> > Richard (ie., release engineer) for an ok. >> >> would you mind if I applied this patch to trunk at the current stage? >> It was approved by Steve and Paul, is rather simple and low-risk ... > > Go ahead. Thanks! Committed as r257590. Cheers, Janus
Re: [Patch, Fortran] PR 84273: Reject allocatable passed-object dummy argument (proc_ptr_47.f90)
On Sun, 11 Feb 2018, Janus Weil wrote: > Dear release managers, > > 2018-02-10 0:21 GMT+01:00 Steve Kargl : > > On Fri, Feb 09, 2018 at 06:13:34PM +0100, Janus Weil wrote: > >> > >> the attached patch fixes some checking code for PASS arguments in > >> procedure-pointer components, which does not properly account for the > >> fact that the PASS argument needs to be polymorphic. > >> > >> [The reason for this issue is probably that PPCs were mostly > >> implemented before polymorphism was available. The corresponding > >> pass-arg checks for TBPs are ok.] > >> > >> The patch also fixes an invalid test case (which was detected thanks > >> to Neil Carlson). It regtests cleanly on x86_64-linux-gnu. Ok for > >> trunk? > > > > The patch looks ok to me. Trunk is in regression and doc > > fixes only mode, so you'll probably need to ping Jakub or > > Richard (ie., release engineer) for an ok. > > would you mind if I applied this patch to trunk at the current stage? > It was approved by Steve and Paul, is rather simple and low-risk ... Go ahead. Richard.
Re: [Patch, Fortran] PR 84273: Reject allocatable passed-object dummy argument (proc_ptr_47.f90)
Dear release managers, 2018-02-10 0:21 GMT+01:00 Steve Kargl : > On Fri, Feb 09, 2018 at 06:13:34PM +0100, Janus Weil wrote: >> >> the attached patch fixes some checking code for PASS arguments in >> procedure-pointer components, which does not properly account for the >> fact that the PASS argument needs to be polymorphic. >> >> [The reason for this issue is probably that PPCs were mostly >> implemented before polymorphism was available. The corresponding >> pass-arg checks for TBPs are ok.] >> >> The patch also fixes an invalid test case (which was detected thanks >> to Neil Carlson). It regtests cleanly on x86_64-linux-gnu. Ok for >> trunk? > > The patch looks ok to me. Trunk is in regression and doc > fixes only mode, so you'll probably need to ping Jakub or > Richard (ie., release engineer) for an ok. would you mind if I applied this patch to trunk at the current stage? It was approved by Steve and Paul, is rather simple and low-risk ... Cheers, Janus
Re: [Patch, Fortran] PR 84273: Reject allocatable passed-object dummy argument (proc_ptr_47.f90)
Hi guys, 2018-02-10 12:46 GMT+01:00 Paul Richard Thomas : > As Steve said, welcome back! thanks for the warm welcome :) > I hope that you will post the news of this fix and the correction of > the testcases on clf. Talking of which, have you posted the problems > that others have found as PRs? Well, I have opened PR 84094 as a collector for such things (and a few dependencies). Neil Carson has put a great amount of work into analyzing some of the issues that came up and compiled a very helpful list at: https://github.com/nncarlson/gfortran.dg/issues I have not sifted through the extensive c.l.f. thread (which may contain further possible issues posted by people who lack the skills to use any kind of bug tracker), any I don't have the intention (read:time) to do that. > It was one of my long deferred tasks to make a start on validating the > testsuite and to remove non-standard features. The biggest issue in this respect is probably the frequent use of the non-std "call abort". All of those could simply be replaced by "stop 1" AFAICS, and if there is consensus that this is a useful thing to do, I'd be willing to take care of it. (Feedback welcome here). Cheers, Janus
Re: [Patch, Fortran] PR 84273: Reject allocatable passed-object dummy argument (proc_ptr_47.f90)
Hi Janus, As Steve said, welcome back! I hope that you will post the news of this fix and the correction of the testcases on clf. Talking of which, have you posted the problems that others have found as PRs? It was one of my long deferred tasks to make a start on validating the testsuite and to remove non-standard features. Thanks for the patch. Paul On 9 February 2018 at 23:21, Steve Kargl wrote: > On Fri, Feb 09, 2018 at 06:13:34PM +0100, Janus Weil wrote: >> >> the attached patch fixes some checking code for PASS arguments in >> procedure-pointer components, which does not properly account for the >> fact that the PASS argument needs to be polymorphic. >> >> [The reason for this issue is probably that PPCs were mostly >> implemented before polymorphism was available. The corresponding >> pass-arg checks for TBPs are ok.] >> >> The patch also fixes an invalid test case (which was detected thanks >> to Neil Carlson). It regtests cleanly on x86_64-linux-gnu. Ok for >> trunk? > > Janus, > > The patch looks ok to me. Trunk is in regression and doc > fixes only mode, so you'll probably need to ping Jakub or > Richard (ie., release engineer) for an ok. > > PS: Welcome back! We can definitely use your talent. > > -- > Steve -- "If you can't explain it simply, you don't understand it well enough" - Albert Einstein
Re: [Patch, Fortran] PR 84273: Reject allocatable passed-object dummy argument (proc_ptr_47.f90)
On Fri, Feb 09, 2018 at 06:13:34PM +0100, Janus Weil wrote: > > the attached patch fixes some checking code for PASS arguments in > procedure-pointer components, which does not properly account for the > fact that the PASS argument needs to be polymorphic. > > [The reason for this issue is probably that PPCs were mostly > implemented before polymorphism was available. The corresponding > pass-arg checks for TBPs are ok.] > > The patch also fixes an invalid test case (which was detected thanks > to Neil Carlson). It regtests cleanly on x86_64-linux-gnu. Ok for > trunk? Janus, The patch looks ok to me. Trunk is in regression and doc fixes only mode, so you'll probably need to ping Jakub or Richard (ie., release engineer) for an ok. PS: Welcome back! We can definitely use your talent. -- Steve