Re: C++ PATCH to fix wrong-code with constexpr call table cache (PR c++/83116)

2017-12-18 Thread Jason Merrill
OK. On Mon, Dec 18, 2017 at 2:56 PM, Marek Polacek wrote: > On Mon, Dec 18, 2017 at 01:07:18PM -0500, Jason Merrill wrote: >> On Mon, Dec 18, 2017 at 10:09 AM, Marek Polacek wrote: >> > Here the problem was that cxx_eval_call_expression can cache the

Re: C++ PATCH to fix wrong-code with constexpr call table cache (PR c++/83116)

2017-12-18 Thread Marek Polacek
On Mon, Dec 18, 2017 at 01:07:18PM -0500, Jason Merrill wrote: > On Mon, Dec 18, 2017 at 10:09 AM, Marek Polacek wrote: > > Here the problem was that cxx_eval_call_expression can cache the result of a > > constexpr call in constexpr_call_table, but we have to be careful, after

Re: C++ PATCH to fix wrong-code with constexpr call table cache (PR c++/83116)

2017-12-18 Thread Jason Merrill
On Mon, Dec 18, 2017 at 10:09 AM, Marek Polacek wrote: > Here the problem was that cxx_eval_call_expression can cache the result of a > constexpr call in constexpr_call_table, but we have to be careful, after > store_init_value the result might be invalid. So I believe we