glibc-2.2{8,9} multiarch build failure on x86_64 with gcc 9

gcc 9 when configured for fortran installs ISO_Fortran_Binding.h in gfor_cdir = $(libdir)/gcc/$(target_alias)/$(gcc_version)$(MULTISUBDIR)/include For x86_64's 32-bit architecture support, this creates a subdirectory named 'include' inside $(libsubdir)/32 which didn't use to exist in gcc

Re: glibc-2.2{8,9} multiarch build failure on x86_64 with gcc 9

On Wed, May 01, 2019 at 02:36:10PM -0400, Carlos O'Donell wrote: > On 5/1/19 2:24 PM, Arvind Sankar wrote: > > gcc 9 when configured for fortran installs ISO_Fortran_Binding.h in > > gfor_cdir = > > $(libdir)/gcc/$(target_alias)/$(gcc_version)$(MULTISUBDIR)/include &g

Re: glibc-2.2{8,9} multiarch build failure on x86_64 with gcc 9

On Wed, May 01, 2019 at 02:48:30PM -0400, Arvind Sankar wrote: > On Wed, May 01, 2019 at 02:36:10PM -0400, Carlos O'Donell wrote: > > On 5/1/19 2:24 PM, Arvind Sankar wrote: > > > gcc 9 when configured for fortran installs ISO_Fortran_Binding.h in > > > gfor_

Re: glibc-2.2{8,9} multiarch build failure on x86_64 with gcc 9

gcc 9 when configured for fortran installs ISO_Fortran_Binding.h in gfor_cdir = $(libdir)/gcc/$(target_alias)/$(gcc_version)$(MULTISUBDIR)/include For x86_64's 32-bit architecture support, this creates a subdirectory named 'include' inside $(libsubdir)/32 which didn't use to exist in gcc

Re: GCC-9.0.1-RC-20190426 excessive memory usage with -ggdb

On Sun, Apr 28, 2019 at 10:59:45PM -0400, Arvind Sankar wrote: > While building clang-8.0.0 or firefox-66.0.3 on a gentoo system (x86_64) > gcc 9 release candidate runs out of memory with -O2 -ggdb. Gcc 8.3.0 > succeeds without issues. For clang there are about 5-6 compilations > wher

GCC-9.0.1-RC-20190426 excessive memory usage with -ggdb

While building clang-8.0.0 or firefox-66.0.3 on a gentoo system (x86_64) gcc 9 release candidate runs out of memory with -O2 -ggdb. Gcc 8.3.0 succeeds without issues. For clang there are about 5-6 compilations where the memory usage seems to grow without bound (I have 128Gb RAM + 128Gb swap and at

Re: Use predicates for RTL objects

On Wed, Aug 07, 2019 at 12:33:53PM -0500, Segher Boessenkool wrote: > On Wed, Aug 07, 2019 at 12:15:29PM -0400, Arvind Sankar wrote: > > I would also like to get some comments on the following idea to make the > > code checks more readable: I am thinking of adding > > boo

Use predicates for RTL objects

Hi, I have posted a patch series [1] for converting some of the RTL code to use predicate macros, as described in the suggestions for beginner GCC projects [2]. Segher was kind enough to give some comments on the initial posting [3]. The code has been bootstrapped natively on x86_64, and I have

Re: Use predicates for RTL objects

On Wed, Aug 07, 2019 at 01:05:51PM -0500, Segher Boessenkool wrote: > On Wed, Aug 07, 2019 at 01:39:53PM -0400, Arvind Sankar wrote: > > On Wed, Aug 07, 2019 at 12:33:53PM -0500, Segher Boessenkool wrote: > > > On Wed, Aug 07, 2019 at 12:15:29PM -0400, Arvind Sankar wrote: &g

Copyright assignment forms

Hi, I would like to begin contributing to the GCC project, and Segher suggested that I should take care of the copyright assignment forms. I am reaching out to obtain them. I am currently unemployed so there's no issue with an employer. Thanks

Re: Use predicates for RTL objects

On Thu, Aug 08, 2019 at 08:31:28AM -0600, Jeff Law wrote: > True, but they could be. When David was working in this space a few > years ago I concluded that the main value in sub-classing the various > RTL operators just wansn't worth the effort. Instead we focused on > starting to tear apart

Re: Use predicates for RTL objects

On Thu, Aug 08, 2019 at 03:04:53PM +, Michael Matz wrote: > Hi, > > On Wed, 7 Aug 2019, Arvind Sankar wrote: > > > => x->is_a (REG) > > Oh god, please no. Currently at least the RTL parts of GCC still have > mostly a consistent and obvious styl

Re: Use predicates for RTL objects

On Thu, Aug 08, 2019 at 10:04:14AM -0500, Segher Boessenkool wrote: > On Wed, Aug 07, 2019 at 02:58:12PM -0400, Arvind Sankar wrote: > > > > > code does is cheap. With "x->is_a (PLUS)", who knows what is > > > > > happening > > > That's no

Re: Use predicates for RTL objects

On Thu, Aug 08, 2019 at 08:14:01PM +0200, Jakub Jelinek wrote: > On Thu, Aug 08, 2019 at 01:12:33PM -0400, Arvind Sankar wrote: > > On Thu, Aug 08, 2019 at 03:04:53PM +, Michael Matz wrote: > > > Hi, > > > > > > On Wed, 7 Aug 2019, Arvind Sankar wrote: &g

Re: Use predicates for RTL objects

On Thu, Aug 08, 2019 at 01:26:42PM -0500, Segher Boessenkool wrote: > LABEL_REF_P works out nicely because it is referring to something that > is data, is not an operator. "Leaves" in an RTL expression, if you want > to look at it that way. > > Predicates for other RTX codes aren't always as

[RFC PATCH] Enhancements to profiledbootstrap

Hi, I've been playing some with the PGO build infrastructure and have a few changes I thought I'd share and get feedback on whether they're completely crazy or not. I'm not terribly familiar with the innards of the build infra, so would appreciate any comments and suggestions. First, a recap of

Re: Use predicates for RTL objects

On Fri, Aug 02, 2019 at 12:49:56PM -0500, Segher Boessenkool wrote: > On Fri, Aug 02, 2019 at 01:38:21PM -0400, Arvind Sankar wrote: > > Hi, I have taken a crack at the beginner GCC project mentioned at > > https://gcc.gnu.org/projects/beginner.html to replace uses of GET_CO

Re: [PATCH] Fix typo LIBGCCJIT_SYMLINK -> LIBGCCJIT_SONAME_SYMLINK

Hi any feedback on this? Thanks. On Tue, Jul 23, 2019 at 02:49:13PM -0400, Arvind Sankar wrote: > There seems to be a typo in gcc/jit/Make-lang.in where it references an > undefined LIBGCCJIT_SYMLINK instead of LIBGCCJIT_SONAME_SYMLINK. > --- > gcc/jit/Make-lang.in | 5 ++--- >

[PATCH] Fix typo LIBGCCJIT_SYMLINK -> LIBGCCJIT_SONAME_SYMLINK

Resending and adding the jit list. There seems to be a typo in gcc/jit/Make-lang.in where it references an undefined LIBGCCJIT_SYMLINK instead of LIBGCCJIT_SONAME_SYMLINK. --- gcc/jit/Make-lang.in | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/gcc/jit/Make-lang.in

Re: Use predicates for RTL objects

On Mon, Aug 05, 2019 at 01:29:26PM -0500, Segher Boessenkool wrote: > On Mon, Aug 05, 2019 at 02:14:50PM -0400, Arvind Sankar wrote: > > On Mon, Aug 05, 2019 at 12:48:46PM -0500, Segher Boessenkool wrote: > > > > -/* Predicate yielding true iff X is an

Re: Use predicates for RTL objects

gelog) comments: > > On Mon, Aug 05, 2019 at 01:09:10PM -0400, Arvind Sankar wrote: > > * gcc/alias.c, gcc/asan.c, gcc/bb-reorder.c, gcc/bt-load.c: Use > > predicate macros for rtx_code comparisons. > > Many of your changelog lines are much too long. Don't use more than

[PATCH v2 08/18] Use CONST_VECTOR_P macro. Autogenerated patch by running ../contrib/rtl-pred.sh CONST_VECTOR

2019-08-05 Arvind Sankar gcc/ChangeLog: * common.md: Convert GET_CODE (..) == CONST_VECTOR to CONST_VECTOR_P (..). * config/aarch64/aarch64.c: Likewise. * config/alpha/alpha.c: Likewise. * config/arc/arc.c: Likewise. * config/arc

[PATCH v2 07/18] Add CONST_VECTOR_P rtx_code predicate.

2019-08-05 Arvind Sankar gcc/ChangeLog: * rtl.h: Add a predicate macro for checking CONST_VECTOR. 1 file changed, 3 insertions(+) diff --git a/gcc/rtl.h b/gcc/rtl.h index 28b5a82d651..45e2b85867d 100644 --- a/gcc/rtl.h +++ b/gcc/rtl.h @@ -818,6 +818,9 @@ struct GTY

[PATCH v2 10/18] Use CONST_STRING_P macro. Autogenerated patch by running ../contrib/rtl-pred.sh CONST_STRING

2019-08-05 Arvind Sankar gcc/ChangeLog: * config/avr/avr.c: Convert GET_CODE (..) == CONST_STRING to CONST_STRING_P (..). * dwarf2out.c: Likewise. * genattrtab.c: Likewise. * gensupport.c: Likewise. 4 files changed, 15 insertions(+), 15

[PATCH v2 05/18] Use CONST_FIXED_P macro. Autogenerated patch by running ../contrib/rtl-pred.sh CONST_FIXED

2019-08-05 Arvind Sankar gcc/ChangeLog: * cfgexpand.c: Convert GET_CODE (..) == CONST_FIXED to CONST_FIXED_P. * config/spu/spu.c: Likewise. * varasm.c: Likewise. 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/gcc/cfgexpand.c b/gcc

[PATCH v2 15/18] Use LABEL_REF_P macro.

2019-08-05 Arvind Sankar gcc/ChangeLog: * rtlanal.c: Convert GET_CODE (..) == LABEL_REF to LABEL_REF_P (..). 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gcc/rtlanal.c b/gcc/rtlanal.c index cb6c8902353..a8becc85047 100644 --- a/gcc/rtlanal.c +++ b/gcc

[PATCH v2 09/18] Add CONST_STRING_P rtx_code predicate.

2019-08-05 Arvind Sankar gcc/ChangeLog: * rtl.h: Add a predicate macro for checking CONST_STRING. 1 file changed, 3 insertions(+) diff --git a/gcc/rtl.h b/gcc/rtl.h index 45e2b85867d..d02772b65be 100644 --- a/gcc/rtl.h +++ b/gcc/rtl.h @@ -821,6 +821,9 @@ struct GTY

[PATCH v2 03/18] Use CONST_INT_P macro.

2019-08-05 Arvind Sankar gcc/ChangeLog: * combine-stack-adj.c: Convert GET_CODE (..) == CONST_INT to CONST_INT_P (..). 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gcc/combine-stack-adj.c b/gcc/combine-stack-adj.c index 3638a1b10ee..f98a0d54c98 100644

[PATCH v2 04/18] Use CONST_WIDE_INT_P macro. Autogenerated patch by running ../contrib/rtl-pred.sh CONST_WIDE_INT_P

2019-08-05 Arvind Sankar gcc/ChangeLog: * config/darwin.c: Convert GET_CODE (..) == CONST_WIDE_INT to CONST_WIDE_INT_P (..). * config/s390/s390.c: Likewise. * rtlanal.c: Likewise. 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/gcc

[PATCH v2 01/18] Fix CONST_DOUBLE_AS_FLOAT_P comment.

2019-08-05 Arvind Sankar gcc/ChangeLog: * rtl.h: Fix comment for CONST_DOUBLE_AS_FLOAT_P and move it together with the other CONST_DOUBLE predicates. 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gcc/rtl.h b/gcc/rtl.h index 039ab05f951..28b5a82d651 100644

Re: Use predicates for RTL objects

Here's the patches split up. The ones that say autogenerated were generated from the script below. I haven't included that as a patch yet since not sure about the copyright/licensing boilerplate to insert in it. contrib/rtl-pred.sh: #!/bin/sh #

Re: Use predicates for RTL objects

On Thu, Aug 08, 2019 at 10:42:06AM -0600, Jeff Law wrote: > On 8/5/19 12:29 PM, Segher Boessenkool wrote: > > On Mon, Aug 05, 2019 at 02:14:50PM -0400, Arvind Sankar wrote: > >> On Mon, Aug 05, 2019 at 12:48:46PM -0500, Segher Boessenkool wrote: > >>> First: do y

[PATCH v2 14/18] Use LABEL_REF_P macro. Autogenerated patch by running ../contrib/rtl-pred.sh LABEL_REF

2019-08-05 Arvind Sankar gcc/ChangeLog: * alias.c: Convert GET_CODE (..) == LABEL_REF to LABEL_REF_P (..). * bb-reorder.c: Likewise. * cfgbuild.c: Likewise. * cfgexpand.c: Likewise. * cfgrtl.c: Likewise. * combine.c: Likewise

[PATCH v2 06/18] Use CONST_DOUBLE_P macro. Autogenerated patch by running ../contrib/rtl-pred.sh CONST_DOUBLE

2019-08-05 Arvind Sankar gcc/ChangeLog: * config/aarch64/aarch64.c: Convert GET_CODE (..) == CONST_DOUBLE to CONST_DOUBLE_P (..). * config/aarch64/aarch64.md: Likewise. * config/arc/arc.c: Likewise. * config/arc/arc.md: Likewise

[PATCH v2 17/18] Use SYMBOL_REF_P macro.

2019-08-05 Arvind Sankar gcc/ChangeLog: * dwarf2out.c: Convert GET_CODE (..) == SYMBOL_REF to SYMBOL_REF_P (..). 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gcc/dwarf2out.c b/gcc/dwarf2out.c index b2b4f6d82b2..ea38963d177 100644 --- a/gcc/dwarf2out.c

[PATCH v2 18/18] Use DEBUG_INSN_P macro. Autogenerated patch by running ../contrib/rtl-pred.sh DEBUG_INSN_P

2019-08-05 Arvind Sankar gcc/ChangeLog: * reload1.c: Convert GET_CODE (..) == DEBUG_INSN to DEBUG_INSN_P (..). * reorg.c: Likewise. 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/gcc/reload1.c b/gcc/reload1.c index 1a68d0567fc..d30badc0c4f

Re: [PATCH 0/3] add support for POD struct convention (PR 61339)

Hi, SVN rev 273311 appears to have been committed without regenerating gcc/config*? Thanks.

Re: [PATCH 0/3] add support for POD struct convention (PR 61339)

On Tue, Jul 23, 2019 at 10:31:16AM -0600, Martin Sebor wrote: > On 7/23/19 10:11 AM, Arvind Sankar wrote: > > Hi, SVN rev 273311 appears to have been committed without regenerating > > gcc/config*? > > That commit wasn't meant to change the configure script since > th

[PATCH] Fix typo LIBGCCJIT_SYMLINK -> LIBGCCJIT_SONAME_SYMLINK

There seems to be a typo in gcc/jit/Make-lang.in where it references an undefined LIBGCCJIT_SYMLINK instead of LIBGCCJIT_SONAME_SYMLINK. --- gcc/jit/Make-lang.in | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/gcc/jit/Make-lang.in b/gcc/jit/Make-lang.in index

[PATCH] Use GCC_PICFLAG to collect host-specific PICFLAG from ../config/picflag.m4

The gcc configure script does not use the config/picflag.m4 macro to customize PICFLAG according to the host when using --enable-host-shared. Fix configure.ac to do so. Tested bootstrap on x86_64-linux-gnu. 2019-07-22 Arvind Sankar * gcc/configure.ac: Use GCC_PICFLAG. --- gcc

Re: [PATCH] Use GCC_PICFLAG to collect host-specific PICFLAG from ../config/picflag.m4

On Wed, Jun 10, 2020 at 04:27:27PM -0600, Jeff Law wrote: > On Mon, 2019-07-22 at 12:39 -0400, Arvind Sankar wrote: > > The gcc configure script does not use the config/picflag.m4 macro to > > customize PICFLAG according to the host when using --enable-host-shared. > > >