Re: ERR: file not changed in a patch:"gcc/cp/cp-tree.c"
On 5/19/20 9:31 PM, Martin Sebor wrote: On 5/19/20 1:26 PM, Martin Liška wrote: On 5/19/20 9:19 PM, Martin Sebor via Gcc wrote: Yep, that was it. It's one of those things that you can stare at for minutes before you notice it. Thank you for the report, it's 1:0 for the hook ;) Next time, please CC me to a similar issue with the hook. I didn't know we were keeping score, otherwise I would have kept this silly blunder to myself ;-) Heh, that was just a joke. By the way, thanks for working on the automation! I can't wait for this ChangeLog hassle (at least some of it) to finally go away. Thanks. Me to, that's why I invested some time in that. It's waste of time to manipulate the ChangeLog entries. This commit took me four attempts: the first two failed due to ChangeLog conflicts, and the last because of this mistake. Martin
Re: ERR: file not changed in a patch:"gcc/cp/cp-tree.c"
On 5/19/20 1:26 PM, Martin Liška wrote: On 5/19/20 9:19 PM, Martin Sebor via Gcc wrote: Yep, that was it. It's one of those things that you can stare at for minutes before you notice it. Thank you for the report, it's 1:0 for the hook ;) Next time, please CC me to a similar issue with the hook. I didn't know we were keeping score, otherwise I would have kept this silly blunder to myself ;-) By the way, thanks for working on the automation! I can't wait for this ChangeLog hassle (at least some of it) to finally go away. This commit took me four attempts: the first two failed due to ChangeLog conflicts, and the last because of this mistake. Martin
Re: ERR: file not changed in a patch:"gcc/cp/cp-tree.c"
On 5/19/20 9:19 PM, Martin Sebor via Gcc wrote: Yep, that was it. It's one of those things that you can stare at for minutes before you notice it. Thank you for the report, it's 1:0 for the hook ;) Next time, please CC me to a similar issue with the hook. Martin
Re: ERR: file not changed in a patch:"gcc/cp/cp-tree.c"
On 5/19/20 1:11 PM, Marek Polacek wrote: On Tue, May 19, 2020 at 01:03:09PM -0600, Martin Sebor via Gcc wrote: I'm having trouble with the commit hook that tries to enforce ChangeLog contents. It fails with an error that doesn't make sense to me: the file it complains isn't mentioned clearly is listed there and I can't tell what about how it's mentioned the hook is having a problem with. Thanks Martin $ git push Enumerating objects: 23, done. Counting objects: 100% (23/23), done. Delta compression using up to 16 threads Compressing objects: 100% (12/12), done. Writing objects: 100% (12/12), 2.41 KiB | 2.41 MiB/s, done. Total 12 (delta 11), reused 0 (delta 0) remote: *** ChangeLog format failed: remote: ERR: file not changed in a patch:"gcc/cp/cp-tree.c" remote: ERR: changed file not mentioned in a ChangeLog:"gcc/cp/tree.c" remote: remote: Please see: https://gcc.gnu.org/codingconventions.html#ChangeLogs remote: remote: error: hook declined to update refs/heads/master To git+ssh://gcc.gnu.org/git/gcc.git ! [remote rejected] master -> master (hook declined) error: failed to push some refs to 'git+ssh://mse...@gcc.gnu.org/git/gcc.git' $ head gcc/cp/ChangeLog 2020-05-18 Martin Sebor PR c++/94923 * call.c ((maybe_warn_class_memaccess): Use is_byte_access_type. * cp-tree.h (is_dummy_object): Return bool. (is_byte_access_type): Declare new function. * cp-tree.c (is_dummy_object): Return bool. There's no cp/cp-tree.c; does it work with just "tree.c" in the ChangeLog? Yep, that was it. It's one of those things that you can stare at for minutes before you notice it. Martin
Re: ERR: file not changed in a patch:"gcc/cp/cp-tree.c"
On 5/19/20 1:03 PM, Martin Sebor wrote: I'm having trouble with the commit hook that tries to enforce ChangeLog contents. It fails with an error that doesn't make sense to me: the file it complains isn't mentioned clearly is listed there and I can't tell what about how it's mentioned the hook is having a problem with. Got it! The file name corresponding to cp-tree.h is, of course, tree.c and not cp-tree.c. This is not to be confused with the C front end where it would be c-tree.c (if it existed there). Thanks Martin $ git push Enumerating objects: 23, done. Counting objects: 100% (23/23), done. Delta compression using up to 16 threads Compressing objects: 100% (12/12), done. Writing objects: 100% (12/12), 2.41 KiB | 2.41 MiB/s, done. Total 12 (delta 11), reused 0 (delta 0) remote: *** ChangeLog format failed: remote: ERR: file not changed in a patch:"gcc/cp/cp-tree.c" remote: ERR: changed file not mentioned in a ChangeLog:"gcc/cp/tree.c" remote: remote: Please see: https://gcc.gnu.org/codingconventions.html#ChangeLogs remote: remote: error: hook declined to update refs/heads/master To git+ssh://gcc.gnu.org/git/gcc.git ! [remote rejected] master -> master (hook declined) error: failed to push some refs to 'git+ssh://mse...@gcc.gnu.org/git/gcc.git' $ head gcc/cp/ChangeLog 2020-05-18 Martin Sebor PR c++/94923 * call.c ((maybe_warn_class_memaccess): Use is_byte_access_type. * cp-tree.h (is_dummy_object): Return bool. (is_byte_access_type): Declare new function. * cp-tree.c (is_dummy_object): Return bool. (is_byte_access_type): Define new function. 2020-05-19 Patrick Palka
Re: ERR: file not changed in a patch:"gcc/cp/cp-tree.c"
On Tue, 2020-05-19 at 13:03 -0600, Martin Sebor via Gcc wrote: > I'm having trouble with the commit hook that tries to enforce > ChangeLog contents. It fails with an error that doesn't make > sense to me: the file it complains isn't mentioned clearly is > listed there and I can't tell what about how it's mentioned > the hook is having a problem with. If it's a bug in the hook, it would probably be helpful if you posted the commit that it refused to accept. It looks to me like when the hook parsed the patch part of your commit that it erroneously decided the hunks changing gcc/cp/cp-tree.c were actually to "gcc/cp/tree.c" - but that's guesswork on my part. Hope this is helpful Dave > Thanks > Martin > > $ git push > Enumerating objects: 23, done. > Counting objects: 100% (23/23), done. > Delta compression using up to 16 threads > Compressing objects: 100% (12/12), done. > Writing objects: 100% (12/12), 2.41 KiB | 2.41 MiB/s, done. > Total 12 (delta 11), reused 0 (delta 0) > remote: *** ChangeLog format failed: > remote: ERR: file not changed in a patch:"gcc/cp/cp-tree.c" > remote: ERR: changed file not mentioned in a > ChangeLog:"gcc/cp/tree.c" > remote: > remote: Please see: > https://gcc.gnu.org/codingconventions.html#ChangeLogs > remote: > remote: error: hook declined to update refs/heads/master > To git+ssh://gcc.gnu.org/git/gcc.git > ! [remote rejected] master -> master (hook declined) > error: failed to push some refs to > 'git+ssh://mse...@gcc.gnu.org/git/gcc.git' > > $ head gcc/cp/ChangeLog > 2020-05-18 Martin Sebor > > PR c++/94923 > * call.c ((maybe_warn_class_memaccess): Use > is_byte_access_type. > * cp-tree.h (is_dummy_object): Return bool. > (is_byte_access_type): Declare new function. > * cp-tree.c (is_dummy_object): Return bool. > (is_byte_access_type): Define new function. > > 2020-05-19 Patrick Palka >
Re: ERR: file not changed in a patch:"gcc/cp/cp-tree.c"
On Tue, May 19, 2020 at 01:03:09PM -0600, Martin Sebor via Gcc wrote: > I'm having trouble with the commit hook that tries to enforce > ChangeLog contents. It fails with an error that doesn't make > sense to me: the file it complains isn't mentioned clearly is > listed there and I can't tell what about how it's mentioned > the hook is having a problem with. > > Thanks > Martin > > $ git push > Enumerating objects: 23, done. > Counting objects: 100% (23/23), done. > Delta compression using up to 16 threads > Compressing objects: 100% (12/12), done. > Writing objects: 100% (12/12), 2.41 KiB | 2.41 MiB/s, done. > Total 12 (delta 11), reused 0 (delta 0) > remote: *** ChangeLog format failed: > remote: ERR: file not changed in a patch:"gcc/cp/cp-tree.c" > remote: ERR: changed file not mentioned in a ChangeLog:"gcc/cp/tree.c" > remote: > remote: Please see: https://gcc.gnu.org/codingconventions.html#ChangeLogs > remote: > remote: error: hook declined to update refs/heads/master > To git+ssh://gcc.gnu.org/git/gcc.git > ! [remote rejected] master -> master (hook declined) > error: failed to push some refs to > 'git+ssh://mse...@gcc.gnu.org/git/gcc.git' > > $ head gcc/cp/ChangeLog > 2020-05-18 Martin Sebor > > PR c++/94923 > * call.c ((maybe_warn_class_memaccess): Use is_byte_access_type. > * cp-tree.h (is_dummy_object): Return bool. > (is_byte_access_type): Declare new function. > * cp-tree.c (is_dummy_object): Return bool. There's no cp/cp-tree.c; does it work with just "tree.c" in the ChangeLog?
