Re: [Gegl-developer] API change for samplers to pass inverse Jacobian data to samplers
On Mon, Jun 29, 2009 at 4:47 PM, Martin Nordholtsense...@gmail.com wrote: It'll be fine to put it in gegl-matrix.c I have added the typedef, but now I have the issue of adding this GeglMatrix2 as a property of the sampler. I notice that there are g_object_class_install_property ( ) lines that use g_param_spec_pointer () and g_param_spec_object () to specify a GParamSpec. What is the correct method call for a GeglMatrix2? Adam Turcotte ___ Gegl-developer mailing list Gegl-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gegl-developer
Re: [Gegl-developer] API change for samplers to pass inverse Jacobian data to samplers
On 07/02/2009 10:34 PM, Sven Neumann wrote: Hi, On Thu, 2009-07-02 at 16:27 -0400, Adam Turcotte wrote: I have added the typedef, but now I have the issue of adding this GeglMatrix2 as a property of the sampler. I notice that there are g_object_class_install_property ( ) lines that use g_param_spec_pointer () and g_param_spec_object () to specify a GParamSpec. What is the correct method call for a GeglMatrix2? You should make GeglMatrix2 a boxed type and use g_param_spec_boxed() for it. gegl-utils.c has code that does this for GeglRectangle. Or he can just do as GeglProcessor does for its GeglRectangle property and use g_param_spec_pointer() and copy the data on a set/get. / Martin ___ Gegl-developer mailing list Gegl-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gegl-developer
Re: [Gegl-developer] API change for samplers to pass inverse Jacobian data to samplers
On 06/25/2009 10:50 PM, Adam Turcotte wrote: My question at the moment is: what is the best way to pass this data to the sampler? I feel bad about you not getting a reply, so I want to give a reply even though it's not a super helpful one: Use whatever way you can come up with and that works for you. If it turns out we don't like your approach for whatever reason, we'll take it from there. Best regards, Martin ___ Gegl-developer mailing list Gegl-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gegl-developer
Re: [Gegl-developer] API change for samplers to pass inverse Jacobian data to samplers
Martin Nordhotls wrote: Personally I don't see the point in duplicating a matrix lib in every software, i.e. I question the introduction of GeglMatrix3 in the first place, I mean there certainly must be high quality libs for matrix operations out there, but that's a different story... IMHO, when all you are dealing with are 3x3 matrices (which are not arbitrary 3x3, since they represent affine + perspective transformations), it is likely that a general purpose matrix library would be slower. Even more so with 2x2. So, my vote is actually for not library. Nicolas Robidoux ___ Gegl-developer mailing list Gegl-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gegl-developer
Re: [Gegl-developer] API change for samplers to pass inverse Jacobian data to samplers
On 06/29/2009 09:53 PM, Nicolas Robidoux wrote: IMHO, when all you are dealing with are 3x3 matrices (which are not arbitrary 3x3, since they represent affine + perspective transformations), it is likely that a general purpose matrix library would be slower. Even more so with 2x2. So, my vote is actually for not library. I'd expect any high quality matrix library to provide optimized routines and data structures for 3x3 matrices. / Martin ___ Gegl-developer mailing list Gegl-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gegl-developer
Re: [Gegl-developer] API change for samplers to pass inverse Jacobian data to samplers
On Mon, Jun 29, 2009 at 3:44 PM, Martin Nordholtsense...@gmail.com wrote: Since GeglMatrix3 exists, GeglMatrix2 also should exist for consistency. Should GeglMatrix2 also reside within gegl-matrix.c, or should it be separate? I can quickly create GeglMatrix2 for the purposes of passing Jacobian information. Adam Turcotte ___ Gegl-developer mailing list Gegl-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gegl-developer
