[gem5-dev] changeset in gem5: stats: Bump stats to match current behaviour

2015-12-02 Thread Andreas Hansson
changeset 135c16fa409d in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=135c16fa409d description: stats: Bump stats to match current behaviour diffstat: tests/long/fs/10.linux-boot/ref/x86/linux/pc-o3-timing/stats.txt |14 +-

Re: [gem5-dev] Review Request 3027: proto, probe: Add elastic trace probe to o3 cpu

2015-12-02 Thread Radhika Jagtap
> On Dec. 1, 2015, 5:31 p.m., Nilay Vaish wrote: > > src/cpu/o3/probe/elastic_trace.cc, lines 72-75 > > > > > > I think these checks are needless. Two reasons. First, since the > > python params do not have default values,

Re: [gem5-dev] Review Request 3090: cpu: Support virtual addr in elastic traces

2015-12-02 Thread Radhika Jagtap
> On Dec. 1, 2015, 5:58 p.m., Nilay Vaish wrote: > > src/cpu/o3/probe/elastic_trace.hh, lines 357-359 > > > > > > Do we really need this? I would rather always trace the virtual > > address as well. I don't think there

Re: [gem5-dev] Review Request 3089: cpu: Create record type enum for elastic traces

2015-12-02 Thread Radhika Jagtap
> On Dec. 1, 2015, 6:21 p.m., Nilay Vaish wrote: > > src/cpu/o3/probe/elastic_trace.cc, lines 917-922 > > > > > > I am not completely sure, but for safety sake, are you allowed to > > return a reference here? What's the

Re: [gem5-dev] Review Request 3031: config: Enable elastic trace capture and replay in se/fs

2015-12-02 Thread Radhika Jagtap
> On Nov. 6, 2015, 7:50 a.m., Nilay Vaish wrote: > > configs/example/etrace_replay.py, lines 107-109 > > > > > > I think these are the only lines that extra > > over what se.py has. Why not just move these to se.py? >

[gem5-dev] Cron <m5test@zizzer> /z/m5/regression/do-regression quick

2015-12-02 Thread Cron Daemon
* build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/o3-timing passed. * build/ALPHA_MOESI_hammer/tests/opt/quick/se/60.rubytest/alpha/linux/rubytest-ruby-MOESI_hammer passed. * build/ALPHA_MOESI_hammer/tests/opt/quick/se/00.hello/alpha/linux/simple-timing-ruby-MOESI_hammer

Re: [gem5-dev] Review Request 3101: DrainManager/Checkpoint changes in SystemC coupling

2015-12-02 Thread Andrew Bardsley
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3101/#review7673 --- Ship it! I'm happy. Andreas S, are you happy this covers the

Re: [gem5-dev] Review Request 3090: cpu: Support virtual addr in elastic traces

2015-12-02 Thread Curtis Dunham
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3090/ --- (Updated Dec. 3, 2015, 1:31 a.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3031: config: Enable elastic trace capture and replay in se/fs

2015-12-02 Thread Curtis Dunham
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3031/ --- (Updated Dec. 3, 2015, 1:34 a.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3028: mem: Add instruction sequence number to request

2015-12-02 Thread Curtis Dunham
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3028/ --- (Updated Dec. 3, 2015, 1:31 a.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3029: cpu: Add TraceCPU to playback elastic traces

2015-12-02 Thread Curtis Dunham
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3029/ --- (Updated Dec. 3, 2015, 1:31 a.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3027: proto, probe: Add elastic trace probe to o3 cpu

2015-12-02 Thread Curtis Dunham
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3027/ --- (Updated Dec. 3, 2015, 1:30 a.m.) Review request for Default. Repository: gem5