Re: [gem5-dev] Review Request 3189: gpu: AMD's baseline GPU model

2016-01-07 Thread Andreas Hansson
> On Oct. 30, 2015, 10:27 p.m., Andreas Hansson wrote: > > Impressive! > > > > Should it not be src/dev/gpu rather than src/gpu? > > > > Also, could you please make it a subdirectory in the gpu dir (as from > > above). There are more GPUs in this world...in fact there is already the > >

Re: [gem5-dev] Review Request 3189: gpu: AMD's baseline GPU model

2016-01-07 Thread Tony Gutierrez
> On Oct. 30, 2015, 3:27 p.m., Andreas Hansson wrote: > > Impressive! > > > > Should it not be src/dev/gpu rather than src/gpu? > > > > Also, could you please make it a subdirectory in the gpu dir (as from > > above). There are more GPUs in this world...in fact there is already the > >

Re: [gem5-dev] Review Request 3262: ext: Replace gzstream with iostream3 from zlib to avoid LGPL

2016-01-07 Thread Matthew Poremba
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3262/#review7837 --- Ship it! Tested this using some pre-existing gzipped traces and it

Re: [gem5-dev] Review Request 3189: gpu: AMD's baseline GPU model

2016-01-07 Thread Tony Gutierrez
> On Nov. 10, 2015, 11:51 a.m., Andreas Sandberg wrote: > > This is indeed very impressive! However, as it is, this patch is basically > > the definition of unreviewable. Could you split it into a handful of > > different patches for review purposes? ReviewBoard makes all kinds of > >

Re: [gem5-dev] Review Request 3189: gpu: AMD's baseline GPU model

2016-01-07 Thread Andreas Hansson
> On Nov. 10, 2015, 7:51 p.m., Andreas Sandberg wrote: > > This is indeed very impressive! However, as it is, this patch is basically > > the definition of unreviewable. Could you split it into a handful of > > different patches for review purposes? ReviewBoard makes all kinds of > >

Re: [gem5-dev] Review Request 3228: dist: Distributed Ethernet link support for distributed gem5 simulations

2016-01-07 Thread Curtis Dunham
> On Jan. 7, 2016, 11:14 p.m., Steve Reinhardt wrote: > > Why was this patch committed? There are no ship-its, and there was no > > warning. I was complaining about minor things to buy myself a little time, > > and also because I hoped the changes between the similar files would be > >

Re: [gem5-dev] Review Request 3228: dist: Distributed Ethernet link support for distributed gem5 simulations

2016-01-07 Thread Steve Reinhardt
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3228/#review7830 --- Why was this patch committed? There are no ship-its, and there was no

Re: [gem5-dev] Review Request 3228: dist: Distributed Ethernet link support for distributed gem5 simulations

2016-01-07 Thread Steve Reinhardt
> On Jan. 7, 2016, 3:14 p.m., Steve Reinhardt wrote: > > Why was this patch committed? There are no ship-its, and there was no > > warning. I was complaining about minor things to buy myself a little time, > > and also because I hoped the changes between the similar files would be > >

Re: [gem5-dev] Review Request 3189: gpu: AMD's baseline GPU model

2016-01-07 Thread Andreas Hansson
> On Nov. 10, 2015, 7:51 p.m., Andreas Sandberg wrote: > > This is indeed very impressive! However, as it is, this patch is basically > > the definition of unreviewable. Could you split it into a handful of > > different patches for review purposes? ReviewBoard makes all kinds of > >

[gem5-dev] Cron <m5test@zizzer> /z/m5/regression/do-regression quick

2016-01-07 Thread Cron Daemon
* build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/minor-timing passed. * build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/o3-timing passed. * build/ALPHA/tests/opt/quick/se/00.hello/alpha/tru64/simple-atomic passed. *

Re: [gem5-dev] Review Request 3261: scons: Enable -Wextra by default

2016-01-07 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3261/ --- (Updated Jan. 7, 2016, 4:32 p.m.) Review request for Default. Repository: gem5

[gem5-dev] TLB and page table latency

2016-01-07 Thread Parvathy N
Hi all How can i find the TLB and pagetable latency cycles for DTLB miss in X86 architecture . I couldnt find it in TLB script file. Thanks in advance Parvathy ___ gem5-dev mailing list gem5-dev@gem5.org

Re: [gem5-dev] Fixes ready to go

2016-01-07 Thread Joel Hestness
Hi Andreas, My only real input is that it would probably be good to get a review from AMD (Brad?) for the -Wextra change. Their significant incoming code could be affected. Joel On Thu, Jan 7, 2016 at 10:34 AM, Andreas Hansson wrote: > Hi all, > > I’d really like

Re: [gem5-dev] Review Request 3261: scons: Enable -Wextra by default

2016-01-07 Thread Steve Reinhardt
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3261/#review7821 --- Please hold off on committing this while we determine how significant

Re: [gem5-dev] Review Request 3205: mem: support for gpu-style RMWs in ruby

2016-01-07 Thread Tony Gutierrez
> On Jan. 6, 2016, 1:39 p.m., Andreas Hansson wrote: > > I still find that the design needs a far better explanation, and at least > > one simple example. I would suggest implementing the SwapReq as an atomic > > op (as I guess it is our only example). Also, surely we need to impose > >

Re: [gem5-dev] Review Request 3205: mem: support for gpu-style RMWs in ruby

2016-01-07 Thread Joel Hestness
> On Jan. 6, 2016, 9:39 p.m., Andreas Hansson wrote: > > I still find that the design needs a far better explanation, and at least > > one simple example. I would suggest implementing the SwapReq as an atomic > > op (as I guess it is our only example). Also, surely we need to impose > >

Re: [gem5-dev] Review Request 3205: mem: support for gpu-style RMWs in ruby

2016-01-07 Thread Andreas Hansson
> On Jan. 6, 2016, 9:39 p.m., Andreas Hansson wrote: > > I still find that the design needs a far better explanation, and at least > > one simple example. I would suggest implementing the SwapReq as an atomic > > op (as I guess it is our only example). Also, surely we need to impose > >

Re: [gem5-dev] Review Request 3227: pseudo inst, util: Add an optional key parameter for the initparam pseudo instruction

2016-01-07 Thread Curtis Dunham
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3227/ --- (Updated Jan. 7, 2016, 9:57 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3228: dist: Distributed Ethernet link support for distributed gem5 simulations

2016-01-07 Thread Curtis Dunham
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3228/ --- (Updated Jan. 7, 2016, 9:58 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3205: mem: support for gpu-style RMWs in ruby

2016-01-07 Thread Tony Gutierrez
> On Jan. 6, 2016, 1:39 p.m., Andreas Hansson wrote: > > I still find that the design needs a far better explanation, and at least > > one simple example. I would suggest implementing the SwapReq as an atomic > > op (as I guess it is our only example). Also, surely we need to impose > >

Re: [gem5-dev] Review Request 3205: mem: support for gpu-style RMWs in ruby

2016-01-07 Thread Brad Beckmann
> On Jan. 6, 2016, 9:39 p.m., Andreas Hansson wrote: > > I still find that the design needs a far better explanation, and at least > > one simple example. I would suggest implementing the SwapReq as an atomic > > op (as I guess it is our only example). Also, surely we need to impose > >

Re: [gem5-dev] Review Request 3261: scons: Enable -Wextra by default

2016-01-07 Thread Andreas Hansson
> On Jan. 7, 2016, 8:07 p.m., Steve Reinhardt wrote: > > Please hold off on committing this while we determine how significant the > > impact is on our outstanding patches (particularly the GPU model). We > > definitely support this in the long term, but might need a little more lead > >

[gem5-dev] changeset in gem5: dev: Distributed Ethernet link for distribute...

2016-01-07 Thread Gabor Dozsa
changeset 1640dd68b0a4 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=1640dd68b0a4 description: dev: Distributed Ethernet link for distributed gem5 simulations Distributed gem5 (abbreviated dist-gem5) is the result of the convergence effort between

[gem5-dev] changeset in gem5: pseudo inst, util: Add optional key to initpar...

2016-01-07 Thread Gabor Dozsa
changeset ab19693da8c9 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=ab19693da8c9 description: pseudo inst,util: Add optional key to initparam pseudo instruction The key parameter can be used to read out various config parameters from within the

[gem5-dev] changeset in gem5: config: Updates for distributed gem5 simulations

2016-01-07 Thread Gabor Dozsa
changeset 9d2364203316 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=9d2364203316 description: config: Updates for distributed gem5 simulations diffstat: configs/common/FSConfig.py| 36 +++ configs/common/Options.py | 31 ++

Re: [gem5-dev] Review Request 3228: dist: Distributed Ethernet link support for distributed gem5 simulations

2016-01-07 Thread Curtis Dunham
> On Dec. 31, 2015, 5:09 a.m., Steve Reinhardt wrote: > > Qre the dist_*.{cc,hh} files basically just renames (with internal symbol > > renames) of the equivalent multi_* files, or are there significant > > differences? Were they renamed with 'hg rename/mv'? > > > > I still haven't had time