[gem5-dev] Cron <m5test@zizzer> /z/m5/regression/do-regression quick

2016-01-08 Thread Cron Daemon
* build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/simple-timing passed. * build/ALPHA/tests/opt/quick/se/03.learning-gem5/alpha/linux/learning-gem5-p1-simple passed. * build/ALPHA/tests/opt/quick/se/00.hello/alpha/tru64/simple-timing passed. *

Re: [gem5-dev] Review Request 3231: dist: config file for distributed switch

2016-01-08 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3231/#review7846 --- configs/example/sw.py (line 1)

Re: [gem5-dev] Review Request 3205: mem: support for gpu-style RMWs in ruby

2016-01-08 Thread Curtis Dunham
> On Jan. 6, 2016, 9:39 p.m., Andreas Hansson wrote: > > I still find that the design needs a far better explanation, and at least > > one simple example. I would suggest implementing the SwapReq as an atomic > > op (as I guess it is our only example). Also, surely we need to impose > >

Re: [gem5-dev] Review Request 3189: gpu: AMD's baseline GPU model

2016-01-08 Thread Steve Reinhardt
> On Nov. 10, 2015, 11:51 a.m., Andreas Sandberg wrote: > > This is indeed very impressive! However, as it is, this patch is basically > > the definition of unreviewable. Could you split it into a handful of > > different patches for review purposes? ReviewBoard makes all kinds of > >

Re: [gem5-dev] Review Request 3189: gpu: AMD's baseline GPU model

2016-01-08 Thread Brad Beckmann
> On Nov. 13, 2015, 11:03 p.m., Joel Hestness wrote: > > src/mem/protocol/RubySlicc_Exports.sm, line 243 > > > > > > Please describe these more clearly. What is a CorePair? What do "TCP", > > "TCC", "SQC" stand for? Etc. >

Re: [gem5-dev] Review Request 3189: gpu: AMD's baseline GPU model

2016-01-08 Thread Brad Beckmann
> On Nov. 20, 2015, 7:59 p.m., Joel Hestness wrote: > > src/mem/protocol/RubySlicc_Types.sm, line 136 > > > > > > These don't appear to be defined or used anywhere. Can you please > > remove them? Sure thing. These can

Re: [gem5-dev] Review Request 3261: scons: Enable -Wextra by default

2016-01-08 Thread Andreas Hansson
> On Jan. 8, 2016, 11:11 p.m., Joe Gross wrote: > > Hey Andreas, this is a really good patch that should lead to code quality > > improvements. Thanks for posting it! It causes only a handful of syntax > > warnings in our code, so I think, from our perspective, you can go ahead > > and commit

Re: [gem5-dev] Review Request 3231: dist: config file for distributed switch

2016-01-08 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3231/#review7845 --- The description should be <80 char lines. I am also not sure about the

Re: [gem5-dev] Review Request 3205: mem: support for gpu-style RMWs in ruby

2016-01-08 Thread Tony Gutierrez
> On Jan. 6, 2016, 1:39 p.m., Andreas Hansson wrote: > > I still find that the design needs a far better explanation, and at least > > one simple example. I would suggest implementing the SwapReq as an atomic > > op (as I guess it is our only example). Also, surely we need to impose > >

Re: [gem5-dev] Review Request 3189: gpu: AMD's baseline GPU model

2016-01-08 Thread Brad Beckmann
> On Nov. 10, 2015, 7:51 p.m., Andreas Sandberg wrote: > > This is indeed very impressive! However, as it is, this patch is basically > > the definition of unreviewable. Could you split it into a handful of > > different patches for review purposes? ReviewBoard makes all kinds of > >

Re: [gem5-dev] Review Request 3230: dist, dev: add an ethernet switch model

2016-01-08 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3230/#review7843 --- src/dev/Ethernet.py (line 96)

Re: [gem5-dev] On ReviewBoard: dist-gem5, the integration of multi-gem5 and pd-gem5

2016-01-08 Thread Mohammad Alian
Hi everyone, To provide the full distributed simulation feature available to the public, we would like to commit the rest of dist-gem5 patches asap (by the end of next week, Jan-15, if there is no issues). Please have a look at these two patches: http://reviews.gem5.org/r/3230/

Re: [gem5-dev] Review Request 3262: ext: Replace gzstream with iostream3 from zlib to avoid LGPL

2016-01-08 Thread Andreas Hansson
> On Jan. 8, 2016, 12:32 a.m., Matthew Poremba wrote: > > Tested this using some pre-existing gzipped traces and it works fine by > > simply replacing class names and header includes. Thanks for the confirmation. - Andreas --- This is

Re: [gem5-dev] Review Request 3230: dist, dev: add an ethernet switch model

2016-01-08 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3230/#review7842 --- src/dev/Ethernet.py (line 88)