----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3230/#review7843 -----------------------------------------------------------
src/dev/Ethernet.py (line 96) <http://reviews.gem5.org/r/3230/#comment6772> Is this needed? Why not rely on the count of the vector port? src/dev/etherswitch.hh (line 16) <http://reviews.gem5.org/r/3230/#comment6773> Should this not appear at the top? src/dev/etherswitch.hh (line 70) <http://reviews.gem5.org/r/3230/#comment6774> A few of these methods should probably be const. Also, some comments would be great. src/dev/etherswitch.hh (line 152) <http://reviews.gem5.org/r/3230/#comment6775> Also in this file several methods should be const, and the level of comments is very poor. src/dev/etherswitch.hh (line 181) <http://reviews.gem5.org/r/3230/#comment6777> unordered_map? src/dev/etherswitch.hh (line 185) <http://reviews.gem5.org/r/3230/#comment6776> a pointer to a std::vector? src/dev/etherswitch.hh (line 192) <http://reviews.gem5.org/r/3230/#comment6779> const? src/dev/etherswitch.cc (line 16) <http://reviews.gem5.org/r/3230/#comment6780> Same as the previous file src/dev/etherswitch.cc (line 51) <http://reviews.gem5.org/r/3230/#comment6781> there is a count associated with the vector port, why not use that? src/dev/etherswitch.cc (line 529) <http://reviews.gem5.org/r/3230/#comment6782> This is not a very nice way to design things... It would be much better if this module was event based. Is there a reason why it is not? - Andreas Hansson On Nov. 19, 2015, 8:19 p.m., Mohammad Alian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3230/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2015, 8:19 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > This patch adds an ethernet switch model which is based on > http://reviews.gem5.org/r/2305/ > while fixing it's issues. > Although we provide this patch as part of distributed gem5 extenstion, > it can be used for any other configurations. > > > Diffs > ----- > > src/dev/Ethernet.py 2375b33bddc6 > src/dev/SConscript 2375b33bddc6 > src/dev/etherswitch.hh PRE-CREATION > src/dev/etherswitch.cc PRE-CREATION > > Diff: http://reviews.gem5.org/r/3230/diff/ > > > Testing > ------- > > several testing done with different benchmarks and different switch sizes > > > Thanks, > > Mohammad Alian > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
