Re: [gem5-dev] Review Request 3346: mem: Create a separate class for the cache write buffer

2016-03-08 Thread Andreas Hansson
> On March 4, 2016, 5:13 p.m., Steve Reinhardt wrote: > > Overall I think this specialization is good. I think the tuple return > > thing is very clunky though. It looks like getNextQueueEntry() is only > > called from getTimingPacket(), which in turn is only called from > >

Re: [gem5-dev] Review Request 3347: mem: Adjust cache queue reserve to more conservative values

2016-03-08 Thread Steve Reinhardt
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3347/#review8073 --- Ship it! Ship It! - Steve Reinhardt On March 8, 2016, 3:06 p.m.,

Re: [gem5-dev] Review Request 3347: mem: Adjust cache queue reserve to more conservative values

2016-03-08 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3347/ --- (Updated March 8, 2016, 11:06 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3346: mem: Create a separate class for the cache write buffer

2016-03-08 Thread Andreas Hansson
> On March 4, 2016, 5:13 p.m., Steve Reinhardt wrote: > > Overall I think this specialization is good. I think the tuple return > > thing is very clunky though. It looks like getNextQueueEntry() is only > > called from getTimingPacket(), which in turn is only called from > >

[gem5-dev] changeset in gem5: configs: Add a lat_mem_rd style test script

2016-03-08 Thread Andreas Hansson
changeset 2fd64ea0a7cb in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=2fd64ea0a7cb description: configs: Add a lat_mem_rd style test script This patch adds a config script that broadly replicates the behaviour of lat_mem_rd. The test is based on

[gem5-dev] changeset in gem5: syscall_emul: Fix erroneous use of delete

2016-03-08 Thread Andreas Hansson
changeset f85d49a098a7 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=f85d49a098a7 description: syscall_emul: Fix erroneous use of delete clang correctly points out an erroneous use of delete. diffstat: src/sim/syscall_emul.hh | 2 +- 1 files changed, 1

[gem5-dev] Review Request 3371: mem: Add priority to QueuedPrefetcher

2016-03-08 Thread Andreas Sandberg
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3371/ --- Review request for Default. Repository: gem5 Description --- Changeset

[gem5-dev] Review Request 3369: mem: Handful extra features for BasePrefetcher

2016-03-08 Thread Andreas Sandberg
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3369/ --- Review request for Default. Repository: gem5 Description --- Changeset

[gem5-dev] changeset in gem5: sim: Add voltage() function to clocked_object

2016-03-08 Thread David Guillen Fandos
changeset 3df33d41 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=3df33d41 description: sim: Add voltage() function to clocked_object Adding voltage function which returns the current voltage for a given clocked object. It's handy for power

[gem5-dev] Review Request 3368: mem: Add Program Counter to MemTraceProbe

2016-03-08 Thread Andreas Sandberg
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3368/ --- Review request for Default. Repository: gem5 Description --- Changeset

[gem5-dev] Review Request 3367: arm: Refactor the TLB test interface

2016-03-08 Thread Andreas Sandberg
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3367/ --- Review request for Default. Repository: gem5 Description --- Changeset

[gem5-dev] Review Request 3366: mem: Add unused prefetch counter in caches

2016-03-08 Thread Andreas Sandberg
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3366/ --- Review request for Default. Repository: gem5 Description --- Changeset

[gem5-dev] changeset in gem5: cpu: Change literal integer constants to mean...

2016-03-08 Thread Rekai Gonzalez Alberquilla
changeset 83c3e117464e in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=83c3e117464e description: cpu: Change literal integer constants to meaningful labels fu_pool and inst_queue were using -1 for "no such FU" and -2 for "all those FUs are busy at

Re: [gem5-dev] Review Request 3346: mem: Create a separate class for the cache write buffer

2016-03-08 Thread Steve Reinhardt
> On March 4, 2016, 9:13 a.m., Steve Reinhardt wrote: > > Overall I think this specialization is good. I think the tuple return > > thing is very clunky though. It looks like getNextQueueEntry() is only > > called from getTimingPacket(), which in turn is only called from > >

Re: [gem5-dev] Review Request 3346: mem: Create a separate class for the cache write buffer

2016-03-08 Thread Andreas Hansson
> On March 4, 2016, 5:13 p.m., Steve Reinhardt wrote: > > Overall I think this specialization is good. I think the tuple return > > thing is very clunky though. It looks like getNextQueueEntry() is only > > called from getTimingPacket(), which in turn is only called from > >