Re: [gem5-dev] Review Request 3580: cpu, mem, sim: Enable KVM support for Ruby

2016-08-04 Thread David Hashe
> On July 27, 2016, 2:32 p.m., Jason Lowe-Power wrote: > > Thanks for the patch. I'm happy to see the backing store made into a class > > instead of a simple pair. I have a patch to do something similar in my > > queue. > > > > A few things below. I still this this patch needs to be broken up

Re: [gem5-dev] Review Request 3580: cpu, mem, sim: Enable KVM support for Ruby

2016-08-04 Thread David Hashe
> On July 27, 2016, 4:43 p.m., Andreas Hansson wrote: > > I would really prefer if we didn't have to add this complexity. > > > > I thought we were pretty much in a position where we could remove the > > horrible shadow memory hack. Could we not pursue that route rather? It > > would be a

Re: [gem5-dev] Review Request 3580: cpu, mem, sim: Enable KVM support for Ruby

2016-08-04 Thread David Hashe
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3580/ --- (Updated Aug. 5, 2016, 1:39 a.m.) Review request for Default. Changes ---

Re: [gem5-dev] Review Request 3584: config: KVM acceleration for apu_se.py

2016-08-04 Thread David Hashe
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3584/ --- (Updated Aug. 5, 2016, 1:36 a.m.) Review request for Default. Changes ---

Re: [gem5-dev] Review Request 3535: gpu-compute: Adding context serialization methods to Wavefront

2016-08-04 Thread Andreas Hansson
> On June 30, 2016, 7:17 a.m., Andreas Hansson wrote: > > src/gpu-compute/wavefront.hh, line 389 > > > > > > Surely one of these should be const I do not see this being addressed. getContext should be const I would

Re: [gem5-dev] Review Request 3590: dev: Add a DmaCallback class to DmaDevice

2016-08-04 Thread Michael LeBeane
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3590/ --- (Updated Aug. 4, 2016, 6:44 p.m.) Review request for Default. Summary (updated)

[gem5-dev] Review Request 3604: base: Output all AddrRange parameters to config.ini

2016-08-04 Thread Matthew Poremba
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3604/ --- Review request for Default. Repository: gem5 Description --- Changeset

Re: [gem5-dev] Review Request 3585: misc: Remove FullSystem check for networking components

2016-08-04 Thread Andreas Hansson
> On Aug. 4, 2016, 4:48 p.m., Andreas Hansson wrote: > > How on earth would you use an Ethernet device without an OS and a driver > > stack? > > Michael LeBeane wrote: > A lot of the Ethernet networking code is fairly generic and can be used > to build non-ethernet device models. Some of

[gem5-dev] Review Request 3591: ruby: Allow multiple outstanding DMA requests

2016-08-04 Thread Michael LeBeane
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3591/ --- Review request for Default. Repository: gem5 Description --- Changeset

Re: [gem5-dev] Review Request 3585: misc: Remove FullSystem check for networking components

2016-08-04 Thread Michael LeBeane
> On Aug. 4, 2016, 4:48 p.m., Andreas Hansson wrote: > > How on earth would you use an Ethernet device without an OS and a driver > > stack? A lot of the Ethernet networking code is fairly generic and can be used to build non-ethernet device models. Some of these device models (high

Re: [gem5-dev] Review Request 3584: config: KVM acceleration for apu_se.py

2016-08-04 Thread Sooraj Puthoor
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3584/#review8572 --- Ship it! Looks good to me. - Sooraj Puthoor On July 26, 2016, 11:22

Re: [gem5-dev] Review Request 3588: ruby: convert atomic accesses to functional in RubyPort

2016-08-04 Thread Andreas Hansson
> On Aug. 4, 2016, 4:52 p.m., Andreas Hansson wrote: > > This is _very_ dangerous. > > > > The "functional" accessor functions are really only for debug access, and > > any writes happening on the functional interfaces do not really have a > > well-defined consistency model with respect to

Re: [gem5-dev] Review Request 3588: ruby: convert atomic accesses to functional in RubyPort

2016-08-04 Thread Michael LeBeane
> On Aug. 4, 2016, 4:52 p.m., Andreas Hansson wrote: > > This is _very_ dangerous. > > > > The "functional" accessor functions are really only for debug access, and > > any writes happening on the functional interfaces do not really have a > > well-defined consistency model with respect to

[gem5-dev] Review Request 3595: dev: Add m5 op to toggle synchronization for dist-gem5.

2016-08-04 Thread Michael LeBeane
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3595/ --- Review request for Default. Repository: gem5 Description --- Changeset

[gem5-dev] Review Request 3593: sim: Refactor quiesce and remove FS asserts

2016-08-04 Thread Michael LeBeane
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3593/ --- Review request for Default. Repository: gem5 Description --- Changeset

[gem5-dev] Review Request 3588: ruby: convert atomic accesses to functional in RubyPort

2016-08-04 Thread Michael LeBeane
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3588/ --- Review request for Default. Repository: gem5 Description --- Changeset

Re: [gem5-dev] Review Request 3585: misc: Remove FullSystem check for networking components

2016-08-04 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3585/#review8568 --- How on earth would you use an Ethernet device without an OS and a driver

[gem5-dev] Review Request 3586: dev: Exit correctly in dist-gem5

2016-08-04 Thread Michael LeBeane
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3586/ --- Review request for Default. Repository: gem5 Description --- Changeset

[gem5-dev] Review Request 3590: Add a DmaCallback class to DmaDevice

2016-08-04 Thread Michael LeBeane
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3590/ --- Review request for Default. Repository: gem5 Description --- Changeset

[gem5-dev] Review Request 3592: config: move dist-gem5 options to common config

2016-08-04 Thread Michael LeBeane
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3592/ --- Review request for Default. Repository: gem5 Description --- Changeset

[gem5-dev] Review Request 3594: x86: Force strict ordering for memory mapped m5ops

2016-08-04 Thread Michael LeBeane
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3594/ --- Review request for Default. Repository: gem5 Description --- Changeset

[gem5-dev] Review Request 3589: sim, syscall_emul: Add mmap to EmulatedDriver

2016-08-04 Thread Michael LeBeane
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3589/ --- Review request for Default. Repository: gem5 Description --- Changeset

[gem5-dev] Review Request 3587: gpu-compute: Fix bug with return in cfg

2016-08-04 Thread Michael LeBeane
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3587/ --- Review request for Default. Repository: gem5 Description --- Changeset

[gem5-dev] Review Request 3585: misc: Remove FullSystem check for networking components

2016-08-04 Thread Michael LeBeane
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3585/ --- Review request for Default. Repository: gem5 Description --- Changeset

[gem5-dev] Review Request 3602: mem: Add DRAM low-power functionality

2016-08-04 Thread Curtis Dunham
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3602/ --- Review request for Default. Repository: gem5 Description --- mem: Add DRAM

[gem5-dev] Review Request 3603: mem: add DRAM powerdown current

2016-08-04 Thread Curtis Dunham
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3603/ --- Review request for Default. Repository: gem5 Description --- mem: add DRAM

[gem5-dev] Review Request 3597: mem: add DRAM powerdown timing

2016-08-04 Thread Curtis Dunham
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3597/ --- Review request for Default. Repository: gem5 Description --- mem: add DRAM

[gem5-dev] Review Request 3598: mem: update DDR3 die revision

2016-08-04 Thread Curtis Dunham
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3598/ --- Review request for Default. Repository: gem5 Description --- mem: update

[gem5-dev] Review Request 3599: mem: Sort memory commands and update DRAMPower

2016-08-04 Thread Curtis Dunham
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3599/ --- Review request for Default. Repository: gem5 Description --- mem: Sort

[gem5-dev] Review Request 3600: mem: Modify drain to ensure banks and power are idled

2016-08-04 Thread Curtis Dunham
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3600/ --- Review request for Default. Repository: gem5 Description --- mem: Modify

[gem5-dev] Review Request 3601: mem: Add callback to compute stats prior to dump event

2016-08-04 Thread Curtis Dunham
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3601/ --- Review request for Default. Repository: gem5 Description --- mem: Add

[gem5-dev] Review Request 3596: mem: make DDR4 x16

2016-08-04 Thread Curtis Dunham
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3596/ --- Review request for Default. Repository: gem5 Description --- mem: make DDR4

[gem5-dev] changeset in gem5: x86, sim: add some syscalls to X86

2016-08-04 Thread Tony Gutierrez
changeset ba45735a726a in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=ba45735a726a description: x86, sim: add some syscalls to X86 this patch adds an implementation for the pwrite64 syscall and enables it for x86_64, and enables fstatfs for x86_64.

[gem5-dev] Cron <m5test@zizzer> /z/m5/regression/do-regression quick

2016-08-04 Thread Cron Daemon
* build/ALPHA/tests/opt/quick/se/20.eio-short/alpha/eio/simple-timing: CHANGED! * build/ALPHA/tests/opt/quick/se/30.eio-mp/alpha/eio/simple-atomic-mp: CHANGED! * build/ALPHA/tests/opt/quick/se/30.eio-mp/alpha/eio/simple-timing-mp: CHANGED! *