I'll start with converting as many from "quick" as I can. If/when I end up
creating my own, is there a convention for what they should be named and
where they should go?
Also, I'm having a bit of a problem with just 00.hello. I compiled the
source in tests/test-progs/hello/src into
I'll certainly add regressions for "hello" for each of the four models, and
I'll try to get other "quick" tests done the same way, too. I won't be
able to do all of them as m5threads hasn't been implemented for RISC-V, but
I'll do what I can. I can also do the "long" ones the same way, if time
Hi Alec,
Thanks for taking the time for writing tests. It's something that we as a
community need to get better at.
To respond to your questions:
- It is completely acceptable for you to include RISC-V only tests. In
fact, I think it's a necessity.
- Focusing just on the "quick" regressions
Hi Alec,
Thanks again for implementing RISC-V in gem5. It's an incredibly important
and timely addition!
As far as I can tell, the patches look good. Hopefully some other will
review them soon as well.
The only thing that's missing that I would really like to have before
pushing the patches is
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3627/#review8998
---
Ship it!
Seems reasonable to me.
- Jason Lowe-Power
On Sept. 29,
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3624/#review8997
---
Ship it!
Sorry for the delay. I finally got everything working and it
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3689/#review8996
---
Ship it!
I'd like to update these tests to do more than 100 "checks".
High guys,
We just noticed some interesting behavior in the branch prediction
infrastructure (bpred_unit.cc). I was wondering if some of you could
shed light on it.
When a branch is mispredicted at execute, all younger branches in the
history of branches are removed. Then, the predictor is
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3502/#review8995
---
Ship it!
thanks for getting this in shape
- Andreas Hansson
On Oct.
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3502/
---
(Updated Oct. 27, 2016, 11:25 a.m.)
Review request for Default.
Repository: gem5
> On Oct. 26, 2016, 7:22 p.m., Andreas Hansson wrote:
> > Somehow the patch is not displaying. Did you use hg postreview?
>
> Christian Menard wrote:
> Hi Andreas! Thanks for your reviews, I will give them a look soon. I
> wanted to do some cleaning up anyway as there are still some
> On Oct. 26, 2016, 7:22 p.m., Andreas Hansson wrote:
> > Somehow the patch is not displaying. Did you use hg postreview?
Hi Andreas! Thanks for your reviews, I will give them a look soon. I wanted to
do some cleaning up anyway as there are still some inconsistencies in master
and slave port.
* build/HSAIL_X86/tests/opt/quick/se/04.gpu/x86/linux/gpu-ruby-GPU_RfO:
CHANGED!
* build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/minor-timing: passed.
* build/ALPHA/tests/opt/quick/se/00.hello/alpha/tru64/simple-timing: passed.
*
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3689/
---
Review request for Default.
Repository: gem5
Description
---
Changeset
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3688/#review8992
---
src/arch/alpha/kernel_stats.cc
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3688/#review8991
---
I don't want this particular part to stall due to the larger discussion
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3688/
---
Review request for Default.
Repository: gem5
Description
---
Changeset
17 matches
Mail list logo