Re: [gem5-dev] Collaboration on Patches?

In my past experience with gerrit, anybody can overwrite anybody else's patch. That may not be true for our instance here, but I suspect it is. All you have to do is make sure the Change-Id: field is the same since that's how gerrit identifies changes. It's generally something to avoid since it

Re: [gem5-dev] Collaboration on Patches?

Hi Alec, First, I'm not sure if collaborating on a single changeset is a common use case for code review platforms. Though, I have run into a number of times where it would have been useful. Am I understanding your suggestion correctly? What you're envisioning is there would be a feature branch

[gem5-dev] Collaboration on Patches?

Hi Everyone, Is there a way to allow multiple people to collaborate on a patch? Right now it looks to me like the only person who can make changes to a patch is the owner, which means that others' contributions have to be manually added. Would it be possible for a person to create a personal

[gem5-dev] Change in gem5/gem5[master]: mem-cache: ReplacementPolicy specific replacement data

Hello Jason Lowe-Power, Nikos Nikoleris, I'd like you to reexamine a change. Please visit https://gem5-review.googlesource.com/9421 to look at the new patch set (#13). Change subject: mem-cache: ReplacementPolicy specific replacement data

[gem5-dev] Change in gem5/gem5[master]: docs: Fix power model doxygen

Hello Anouk Van Laer, I'd like you to reexamine a change. Please visit https://gem5-review.googlesource.com/9981 to look at the new patch set (#3). Change subject: docs: Fix power model doxygen .. docs: Fix power model

[gem5-dev] Change in gem5/gem5[master]: mem-cache: Create NRU Replacement Policy

Daniel Carvalho has submitted this change and it was merged. ( https://gem5-review.googlesource.com/9001 ) Change subject: mem-cache: Create NRU Replacement Policy .. mem-cache: Create NRU Replacement Policy Implementation

[gem5-dev] Change in gem5/gem5[master]: mem-cache: Create NRU Replacement Policy

Daniel Carvalho has uploaded a new patch set (#5). ( https://gem5-review.googlesource.com/9001 ) Change subject: mem-cache: Create NRU Replacement Policy .. mem-cache: Create NRU Replacement Policy Implementation of a Not

[gem5-dev] Change in gem5/gem5[master]: arch-arm: Fix masking in CPACR_EL1

Giacomo Travaglini has submitted this change and it was merged. ( https://gem5-review.googlesource.com/10046 ) Change subject: arch-arm: Fix masking in CPACR_EL1 .. arch-arm: Fix masking in CPACR_EL1 Some bits in CPACR_EL1

[gem5-dev] Change in gem5/gem5[master]: arch-arm: Mask out unsupported trapped exception handling bits

Giacomo Travaglini has submitted this change and it was merged. ( https://gem5-review.googlesource.com/10045 ) Change subject: arch-arm: Mask out unsupported trapped exception handling bits .. arch-arm: Mask out

[gem5-dev] Change in gem5/gem5[master]: arch-arm: Fix masking in CPACR_EL1

Hello Andreas Sandberg, I'd like you to do a code review. Please visit https://gem5-review.googlesource.com/10046 to review the following change. Change subject: arch-arm: Fix masking in CPACR_EL1 .. arch-arm: Fix

[gem5-dev] Change in gem5/gem5[master]: arch-arm: Mask out unsupported trapped exception handling bits

Hello Andreas Sandberg, I'd like you to do a code review. Please visit https://gem5-review.googlesource.com/10045 to review the following change. Change subject: arch-arm: Mask out unsupported trapped exception handling bits

[gem5-dev] Change in gem5/gem5[master]: arch-arm: Fix FPEXC32_EL2 to FPEXC mapping

Giacomo Travaglini has submitted this change and it was merged. ( https://gem5-review.googlesource.com/10043 ) Change subject: arch-arm: Fix FPEXC32_EL2 to FPEXC mapping .. arch-arm: Fix FPEXC32_EL2 to FPEXC mapping The

[gem5-dev] Change in gem5/gem5[master]: arch-arm: Adding MiscReg Priv (EL1) global flag

Giacomo Travaglini has submitted this change and it was merged. ( https://gem5-review.googlesource.com/10042 ) Change subject: arch-arm: Adding MiscReg Priv (EL1) global flag .. arch-arm: Adding MiscReg Priv (EL1) global flag

[gem5-dev] Change in gem5/gem5[master]: arch-arm: Correct masking of cp10 and cp11 in CPACR

Giacomo Travaglini has submitted this change and it was merged. ( https://gem5-review.googlesource.com/10044 ) Change subject: arch-arm: Correct masking of cp10 and cp11 in CPACR .. arch-arm: Correct masking of cp10 and cp11

[gem5-dev] Change in gem5/gem5[master]: arch-arm: Using explicit invalidation in TLB

Giacomo Travaglini has submitted this change and it was merged. ( https://gem5-review.googlesource.com/10041 ) Change subject: arch-arm: Using explicit invalidation in TLB .. arch-arm: Using explicit invalidation in TLB When

[gem5-dev] Change in gem5/gem5[master]: mem-cache: Create Skewed Assoc placement policy

Hello Jason Lowe-Power, Nikos Nikoleris, I'd like you to reexamine a change. Please visit https://gem5-review.googlesource.com/8886 to look at the new patch set (#4). Change subject: mem-cache: Create Skewed Assoc placement policy

[gem5-dev] Change in gem5/gem5[master]: mem-cache: Make CacheBlk set independent

Hello Jason Lowe-Power, Nikos Nikoleris, I'd like you to reexamine a change. Please visit https://gem5-review.googlesource.com/9961 to look at the new patch set (#2). Change subject: mem-cache: Make CacheBlk set independent

[gem5-dev] Change in gem5/gem5[master]: mem-cache: Revamp multiple size tracking for FALRU caches

Nikos Nikoleris has submitted this change and it was merged. ( https://gem5-review.googlesource.com/9826 ) Change subject: mem-cache: Revamp multiple size tracking for FALRU caches .. mem-cache: Revamp multiple size tracking

[gem5-dev] Change in gem5/gem5[master]: arch-arm: Correct masking of cp10 and cp11 in CPACR

Hello Andreas Sandberg, I'd like you to do a code review. Please visit https://gem5-review.googlesource.com/10044 to review the following change. Change subject: arch-arm: Correct masking of cp10 and cp11 in CPACR ..

[gem5-dev] Change in gem5/gem5[master]: arch-arm: Fix FPEXC32_EL2 to FPEXC mapping

Hello Nikos Nikoleris, I'd like you to do a code review. Please visit https://gem5-review.googlesource.com/10043 to review the following change. Change subject: arch-arm: Fix FPEXC32_EL2 to FPEXC mapping .. arch-arm:

[gem5-dev] Change in gem5/gem5[master]: arch-arm: Adding MiscReg Priv (EL1) global flag

Hello Nikos Nikoleris, Curtis Dunham, I'd like you to do a code review. Please visit https://gem5-review.googlesource.com/10042 to review the following change. Change subject: arch-arm: Adding MiscReg Priv (EL1) global flag

[gem5-dev] Change in gem5/gem5[master]: arch-arm: Using explicit invalidation in TLB

Hello Andreas Sandberg, I'd like you to do a code review. Please visit https://gem5-review.googlesource.com/10041 to review the following change. Change subject: arch-arm: Using explicit invalidation in TLB .. arch-arm:

[gem5-dev] Change in gem5/gem5[master]: base, dev: Fix port message for vnc and terminal

Hello Anouk Van Laer, I'd like you to do a code review. Please visit https://gem5-review.googlesource.com/10026 to review the following change. Change subject: base, dev: Fix port message for vnc and terminal .. base,

[gem5-dev] Change in gem5/gem5[master]: dev: Add support for a simple debug UART

Hello Giacomo Travaglini, I'd like you to do a code review. Please visit https://gem5-review.googlesource.com/10025 to review the following change. Change subject: dev: Add support for a simple debug UART .. dev: Add

[gem5-dev] Cron <m5test@zizzer> /z/m5/regression/do-regression quick

* build/RISCV/tests/opt/quick/se/02.insttest/riscv/linux-rv64c/simple-timing: FAILED! * build/RISCV/tests/opt/quick/se/02.insttest/riscv/linux-rv64c/o3-timing: FAILED! * build/RISCV/tests/opt/quick/se/02.insttest/riscv/linux-rv64c/minor-timing: FAILED! *

[gem5-dev] Change in gem5/gem5[master]: dev, arm: Add support for HYP & secure timers

Hello Curtis Dunham, I'd like you to do a code review. Please visit https://gem5-review.googlesource.com/10023 to review the following change. Change subject: dev, arm: Add support for HYP & secure timers .. dev, arm:

[gem5-dev] Change in gem5/gem5[master]: system-arm: Update gem5 timer interrupt specification

Hello Gabor Dozsa, I'd like you to do a code review. Please visit https://gem5-review.googlesource.com/10024 to review the following change. Change subject: system-arm: Update gem5 timer interrupt specification ..

[gem5-dev] Change in gem5/gem5[master]: arch-arm: Add support for semihosting STDIO redirection

Hello Anouk Van Laer, Giacomo Travaglini, I'd like you to do a code review. Please visit https://gem5-review.googlesource.com/10021 to review the following change. Change subject: arch-arm: Add support for semihosting STDIO redirection

[gem5-dev] Change in gem5/gem5[master]: arch-arm: Fix semihosting arg count for SYS_GET_CMDLINE

Hello Giacomo Travaglini, I'd like you to do a code review. Please visit https://gem5-review.googlesource.com/10022 to review the following change. Change subject: arch-arm: Fix semihosting arg count for SYS_GET_CMDLINE

[gem5-dev] Change in gem5/gem5[master]: mem-cache: Revamp multiple size tracking for FALRU caches

Hello Daniel Carvalho, I'd like you to reexamine a change. Please visit https://gem5-review.googlesource.com/9826 to look at the new patch set (#5). Change subject: mem-cache: Revamp multiple size tracking for FALRU caches

[gem5-dev] Change in gem5/gem5[master]: mem-cache: Revamp multiple size tracking for FALRU caches

Hello Daniel Carvalho, I'd like you to reexamine a change. Please visit https://gem5-review.googlesource.com/9826 to look at the new patch set (#4). Change subject: mem-cache: Revamp multiple size tracking for FALRU caches

[gem5-dev] Change in gem5/gem5[master]: dev, arm: Cleanup Pl050 interrupt handling

Andreas Sandberg has submitted this change and it was merged. ( https://gem5-review.googlesource.com/9769 ) Change subject: dev, arm: Cleanup Pl050 interrupt handling .. dev, arm: Cleanup Pl050 interrupt handling Add support

[gem5-dev] Change in gem5/gem5[master]: mem-cache: Revamp multiple size tracking for FALRU caches

Hello Daniel Carvalho, I'd like you to reexamine a change. Please visit https://gem5-review.googlesource.com/9826 to look at the new patch set (#3). Change subject: mem-cache: Revamp multiple size tracking for FALRU caches