Re: [gem5-dev] Making the verification bit sicky(ier) in gerrit

2020-03-31 Thread Bobby Bruce
Sounds like a great idea to me. I fail to see any downside. -- Dr. Bobby R. Bruce Room 2235, Kemper Hall, UC Davis Davis, CA, 95616 web: https://www.bobbybruce.net On Tue, Mar 31, 2020 at 7:03 PM Gabe Black wrote: > Hi folks. I (and probably many of you) have noticed that gerrit sometimes >

[gem5-dev] Making the verification bit sicky(ier) in gerrit

2020-03-31 Thread Gabe Black
Hi folks. I (and probably many of you) have noticed that gerrit sometimes decides something needs to be rebased when it doesn't really seem to, and that rebase ends up forcing a rerun of verification which delays getting a patch checked in, and incurs extra cost for gem5 for the compute resources

Re: [gem5-dev] m5 utility patch series

2020-03-31 Thread Gabe Black
Hi Jason, replies inline. On Tue, Mar 31, 2020 at 3:29 PM Jason Lowe-Power wrote: > Oh, one more comment... > > Do you think it's worth changing the name to "gem5" instead of "m5". Since > we're making big changes, it seems like now might be right time. > That's not a bad idea, although there

[gem5-dev] Change in gem5/gem5[develop]: util: Remove the subfunc arg from M5OP_FOREACH.

2020-03-31 Thread Gabe Black (Gerrit)
Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/27205 ) Change subject: util: Remove the subfunc arg from M5OP_FOREACH. .. util: Remove the subfunc arg from M5OP_FOREACH. Now that

[gem5-dev] Change in gem5/gem5[develop]: misc: Remove the now unused M5OP_FOREACH_ANNOTATION macro.

2020-03-31 Thread Gabe Black (Gerrit)
Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/27204 ) Change subject: misc: Remove the now unused M5OP_FOREACH_ANNOTATION macro. .. misc: Remove the now unused

Re: [gem5-dev] m5 utility patch series

2020-03-31 Thread Jason Lowe-Power
Oh, one more comment... Do you think it's worth changing the name to "gem5" instead of "m5". Since we're making big changes, it seems like now might be right time. Cheers, Jason On Tue, Mar 31, 2020 at 3:10 PM Jason Lowe-Power wrote: > Hey Gabe, > > First of all, thanks for this cleanup.

Re: [gem5-dev] m5 utility patch series

2020-03-31 Thread Jason Lowe-Power
Hey Gabe, First of all, thanks for this cleanup. We've needed to update this code for a long time! Do you have a pointer to what would be "new" documentation on the m5 ops tools? I was briefly going through your changes and it's not clear how you're envisioning people using this library now. For

Re: [gem5-dev] Removing kokoro runs

2020-03-31 Thread Bobby Bruce
Yes, We're using this migration to slowly drop support for GCC 4 ( https://gem5.atlassian.net/browse/GEM5-218), which i believe is causing these discrepencies. GCB runs on a Docker Image built with

Re: [gem5-dev] Removing kokoro runs

2020-03-31 Thread Giacomo Travaglini
Thanks Jason for the great effort you are putting on this, and for updating us on the current state. It’s not really relevant to our discussion, but while GCB and kokoro run the same tests, they do that under different building environments. An example is:

Re: [gem5-dev] Removing kokoro runs

2020-03-31 Thread Jason Lowe-Power
A couple of things... Bobby can correct me if I'm wrong. 1. GCB and kokoro should be running *the same tests*. So they should always have the same result. There's no need to wait for kokoro if you have a +1 from GCB. 2. The migration is still in progress. There are a couple of loose ends we need

Re: [gem5-dev] Removing kokoro runs

2020-03-31 Thread Ciro Santilli
Yes, I am logged in. From: Giacomo Travaglini Sent: Tuesday, March 31, 2020 3:29 PM To: Nils Asmussen ; gem5 Developer List ; Ciro Santilli ; Jason Lowe-Power ; Bobby Bruce Subject: RE: [gem5-dev] Removing kokoro runs Have you tried to login? Giacomo

Re: [gem5-dev] Removing kokoro runs

2020-03-31 Thread Giacomo Travaglini
Have you tried to login? Giacomo -Original Message- From: Nils Asmussen Sent: 31 March 2020 15:27 To: gem5 Developer List ; Ciro Santilli ; Jason Lowe-Power ; Bobby Bruce ; Giacomo Travaglini Subject: Re: [gem5-dev] Removing kokoro runs Hi, same for me. Google says the permission

Re: [gem5-dev] Removing kokoro runs

2020-03-31 Thread Nils Asmussen
Hi, same for me. Google says the permission "cloudbuild.builds.get" is missing. Best regards, Nils On 3/31/20 4:23 PM, Ciro Santilli wrote: > Since Giacomo started this thread, I would also want to chime in a related > question: are you able to see GCB run logs? > > E.g. at:

Re: [gem5-dev] Removing kokoro runs

2020-03-31 Thread Ciro Santilli
Since Giacomo started this thread, I would also want to chime in a related question: are you able to see GCB run logs? E.g. at: https://gem5-review.googlesource.com/c/public/gem5/+/27315 GCB links to

[gem5-dev] Change in gem5/gem5[develop]: arch-arm, dev-arm: WakeRequest implementation

2020-03-31 Thread Giacomo Travaglini (Gerrit)
Giacomo Travaglini has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/26810 ) Change subject: arch-arm, dev-arm: WakeRequest implementation .. arch-arm, dev-arm: WakeRequest implementation This

[gem5-dev] Change in gem5/gem5[develop]: util: Remove the annotation pseudo ops symbols from the m5 utility.

2020-03-31 Thread Gabe Black (Gerrit)
Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/27203 ) Change subject: util: Remove the annotation pseudo ops symbols from the m5 utility. .. util: Remove the annotation pseudo

[gem5-dev] Removing kokoro runs

2020-03-31 Thread Giacomo Travaglini
Hi, I have noticed we have started using the Google Cloud service to run our pre-submit regressions. At the moment this is happening in parallel with kokoro. Few things to point out: 1. It is actually possible now to submit a patch without kokoro. GCB is faster than kokoro and starts as

[gem5-dev] Change in gem5/gem5[develop]: tests: move threads test to the new framework

2020-03-31 Thread Ciro Santilli (Gerrit)
Ciro Santilli has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/27310 ) Change subject: tests: move threads test to the new framework .. tests: move threads test to the new framework

[gem5-dev] Change in gem5/gem5[develop]: tests: remove hello, already present in new framework

2020-03-31 Thread Ciro Santilli (Gerrit)
Ciro Santilli has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/27315 ) Change subject: tests: remove hello, already present in new framework .. tests: remove hello, already present

[gem5-dev] Change in gem5/gem5[develop]: tests: move page-access-wrap test to the new framework

2020-03-31 Thread Ciro Santilli (Gerrit)
Ciro Santilli has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/27314 ) Change subject: tests: move page-access-wrap test to the new framework .. tests: move page-access-wrap test to

[gem5-dev] Change in gem5/gem5[develop]: tests: move m5op_arm_A64.S to m5op_arm64.S

2020-03-31 Thread Ciro Santilli (Gerrit)
Ciro Santilli has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/27307 ) Change subject: tests: move m5op_arm_A64.S to m5op_arm64.S .. tests: move m5op_arm_A64.S to m5op_arm64.S This

[gem5-dev] Change in gem5/gem5[develop]: tests: move mwait test to the new framework

2020-03-31 Thread Ciro Santilli (Gerrit)
Ciro Santilli has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/27312 ) Change subject: tests: move mwait test to the new framework .. tests: move mwait test to the new framework

[gem5-dev] Change in gem5/gem5[develop]: tests: move pthread tests to the new framework

2020-03-31 Thread Ciro Santilli (Gerrit)
Ciro Santilli has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/27309 ) Change subject: tests: move pthread tests to the new framework .. tests: move pthread tests to the new

[gem5-dev] Change in gem5/gem5[develop]: tests: move chdir-print test to the new framework

2020-03-31 Thread Ciro Santilli (Gerrit)
Ciro Santilli has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/27313 ) Change subject: tests: move chdir-print test to the new framework .. tests: move chdir-print test to the new

[gem5-dev] Change in gem5/gem5[develop]: tests: move stack-print test to the new framework

2020-03-31 Thread Ciro Santilli (Gerrit)
Ciro Santilli has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/27311 ) Change subject: tests: move stack-print test to the new framework .. tests: move stack-print test to the new

[gem5-dev] Change in gem5/gem5[develop]: tests: generic Makefile for user and baremetal test programs

2020-03-31 Thread Ciro Santilli (Gerrit)
Ciro Santilli has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/27308 ) Change subject: tests: generic Makefile for user and baremetal test programs .. tests: generic Makefile for