[gem5-dev] Re: deprecating warn_once

2021-07-27 Thread Daniel Carvalho via gem5-dev
Hello, I like the idea of GEM5_ONCE, but as it would become part of the API users could definitely use in unforeseen ways (e.g., debugging). I am not saying this is a bad thing, but it is something to consider. Regards,Daniel ___ gem5-dev mailing list

[gem5-dev] Re: gem5 namespace

2021-06-27 Thread Daniel Carvalho via gem5-dev
namespaces! This will be useful. Cheers,Jason On Thu, May 6, 2021 at 7:06 AM Daniel Carvalho via gem5-dev wrote: Glad to see that we are reaching a consensus! Then we will create the "gem5" namespace, rename (most) macros to use a "GEM5_" prefix, and will rename all namespaces to

[gem5-dev] Re: RFC: run python Black on gem5 python code

2021-06-24 Thread Daniel Carvalho via gem5-dev
bout the style. > > > > > > Maybe the right thing to do would be to give it a shot but not make > it > > compulsory until we have a feeling for how much trouble it is. > > > > > > Gabe > > > > On Wed, Mar 3, 2021 at 11:24 AM Bobby Bruce via ge

[gem5-dev] Re: Build failed in Jenkins: compiler-checks #72

2021-05-13 Thread Daniel Carvalho via gem5-dev
+1 to raising the minimum GCC version to 7 (not sure about 7.3; 2018 may be too recent) and enabling C++17. Em quinta-feira, 13 de maio de 2021 19:58:49 BRT, Gabe Black via gem5-dev escreveu: I have no objection to moving the compiler versions up. I don't really know what benchmark

[gem5-dev] Re: Build failed in Jenkins: nightly #307

2021-05-11 Thread Daniel Carvalho via gem5-dev
Hi, Bobby, Previous to that patch, enabled() (now tracing()) checked if the flag was globally enabled and if it had been individually enabled, and the tracing check was done elsewhere (DTRACE(flag) did that). Now tracing() is checking both conditions AND if tracing is on, which is likely a

[gem5-dev] Re: gem5 namespace

2021-05-06 Thread Daniel Carvalho via gem5-dev
update > should be high priority. If we are going to be changing names, etc. in a way > that means external users of gem5 will have compiler errors, we should > probably provide backwards compatibility and warnings. Most of our users > are not software engineers and do not have as much

[gem5-dev] Re: gem5 namespace

2021-05-03 Thread Daniel Carvalho via gem5-dev
eing too focused on "standards" and not on enough on ease of use. It's not a problem if there are exceptions to guidance, if there's good reasons for the exceptions. On Mon, May 3, 2021 at 11:36 AM Daniel Carvalho via gem5-dev wrote: As mentioned by Gabe in the Jira issue, some of th

[gem5-dev] Re: gem5 namespace

2021-05-03 Thread Daniel Carvalho via gem5-dev
As mentioned by Gabe in the Jira issue, some of the namespaces using snake declared in the codebase case are defined as parts of a standard, and thus cannot be modified. Realistically, this means that if we wanted to follow a namespace naming convention, it'd be snake case: despite having way

[gem5-dev] Re: gem5 namespace

2021-05-02 Thread Daniel Carvalho via gem5-dev
R. Bruce Room 2235, Kemper Hall, UC Davis Davis, CA, 95616 web: https://www.bobbybruce.net On Sun, Apr 18, 2021 at 3:44 PM Daniel Carvalho via gem5-dev wrote: Overall, there are way more uses of "gem5" than "Gem5" in the codebase, and most of the instances that bre

[gem5-dev] Re: gem5 namespace

2021-04-18 Thread Daniel Carvalho via gem5-dev
ders to be in the gem5 namespace? If not, when is an > object in the gem5 namespace and when it is not? What about `using > namespace gem5`? Can/must all .cc files include this? > > Since this is a relatively big change to the coding standards which > could cause significant frustration to

[gem5-dev] gem5 namespace

2021-04-14 Thread Daniel Carvalho via gem5-dev
Hello, devs, We currently have a recurring issue, which is the lack of a gem5 namespace.This generates collision with other libraries and user code. A Jira ticket has been created to point out the issue last year: https://gem5.atlassian.net/jira/software/c/projects/GEM5/issues/GEM5-730 And

[gem5-dev] Re: RFC: run python Black on gem5 python code

2021-03-03 Thread Daniel Carvalho via gem5-dev
+1 Em quarta-feira, 3 de março de 2021 14:35:57 BRT, Jason Lowe-Power via gem5-dev escreveu: Hi all, Right now, we don't have an official style guide for python. Our style guide (http://www.gem5.org/documentation/general_docs/development/coding_style/) is very C++ focused. I would

[gem5-dev] Re: Build failed in Jenkins: Nightly #211

2021-02-06 Thread Daniel Carvalho via gem5-dev
Fix here: https://gem5-review.googlesource.com/c/public/gem5/+/40835 Bonus fix (not run by any CI): https://gem5-review.googlesource.com/c/public/gem5/+/40836/1Em sábado, 6 de fevereiro de 2021 21:19:30 BRT, jenkins-no-reply--- via gem5-dev escreveu: See

[gem5-dev] Re: Build failed in Jenkins: Nightly #208

2021-02-03 Thread Daniel Carvalho via gem5-dev
Fix here: https://gem5-review.googlesource.com/c/public/gem5/+/40555Em quarta-feira, 3 de fevereiro de 2021 17:18:14 BRT, jenkins-no-reply--- via gem5-dev escreveu: See Changes: [gabe.black] ext: Update

[gem5-dev] Re-join debug flags headers

2021-01-15 Thread Daniel Carvalho via gem5-dev
Hello all, I've uploaded a commit that re-joins the debug header files into a single one: https://gem5-review.googlesource.com/c/public/gem5/+/39255. This means that instead of having to include a different header for each and every debug flag used in a file, only one is needed. For example, in

[gem5-dev] Re: IWYU tool and include checking from scons

2021-01-13 Thread Daniel Carvalho via gem5-dev
I am in favor of running a tool like IWYU to fix the codebase (although I have never used it), but I am not sure if adding this to the build system is a good idea: our current contribution frequency (~1k commits/year?) likely does not generate enough extra/missing includes to require the

[gem5-dev] Re: For gem5 20.1: Remove "master" and replace with new "stable" default branch (?)

2020-08-29 Thread Daniel Carvalho via gem5-dev
+1 Seems like an excellent rename choice! Em sábado, 29 de agosto de 2020 02:58:57 GMT+2, Jason Lowe-Power via gem5-dev escreveu: +1 Thanks for getting the ball rolling on this, Bobby! On Fri, Aug 28, 2020 at 5:26 PM Bobby Bruce via gem5-dev wrote: Dear all, Back when we moved from

[gem5-dev] Namespace creation on develop branch

2020-08-27 Thread Daniel Carvalho via gem5-dev
Hello, This message only concerns those who use the *develop* branch. We have recently merged another patch creating a namespace (https://gem5-review.googlesource.com/c/public/gem5/+/33294). Due to a small issue with the SCons configuration, it does not trigger automatic recompilation of the

[gem5-dev] Re: Change in gem5/gem5[develop]: mem-cache: Create Compressor namespace

2020-08-25 Thread Daniel Carvalho via gem5-dev
Was about to send an e-mail with a heads up, but I guess I was too late. As reported here (https://gem5.atlassian.net/jira/software/c/projects/GEM5/issues/GEM5-753), it is not an issue caused by this patch itself. SCons does not trigger recompilation when a change modifies the cxx_class;

[gem5-dev] Re: [Suggestion] Replace gem5-users mailing-list with Discourse

2020-06-10 Thread Daniel Carvalho via gem5-dev
First of all, I don't know how Discourse works, but from what I saw on the online demo it looked like a forum. Therefore, our main use case would be as a place to ask/deposit questions. I believe that having a mailing list pushing mails down our throats compels people to answer: "Oh, I know the

[gem5-dev] Re: Ruby Prefetcher Segfaulting

2020-06-05 Thread Daniel Carvalho via gem5-dev
Hello Timothy, I believe this patch is fixing that: https://gem5-review.googlesource.com/c/public/gem5/+/29974 Regards,Daniel Em sexta-feira, 5 de junho de 2020 11:42:44 GMT+2, Timothy Hayes via gem5-dev escreveu: I’ve just rebased onto v20.0.0.1 and am finding that the