[gem5-dev] changeset in gem5: ruby: fix round robin arbiter in garnet2.0

2017-02-12 Thread Tushar Krishna
changeset 3c38d3e74980 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=3c38d3e74980 description: ruby: fix round robin arbiter in garnet2.0 The rr arbiter pointer in garnet was getting updated on every request, even if there is no grant. This was

Re: [gem5-dev] Review Request 3809: imported patch rr_arbiter_fix

2017-02-11 Thread Tushar Krishna
lly generated e-mail. To reply, visit: http://reviews.gem5.org/r/3809/#review9418 --- On Feb. 12, 2017, 4:36 a.m., Tushar Krishna wrote: > > --- > This is an automatically ge

[gem5-dev] Review Request 3809: imported patch rr_arbiter_fix

2017-02-11 Thread Tushar Krishna
it to update upon a grant. Diffs - src/mem/ruby/network/garnet2.0/SwitchAllocator.cc 79c3f6a60392 Diff: http://reviews.gem5.org/r/3809/diff/ Testing --- Thanks, Tushar Krishna ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org

Re: [gem5-dev] Review Request 3753: ruby: Check MessageBuffer space in garnet NetworkInterface

2017-01-10 Thread Tushar Krishna
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3753/#review9246 --- Ship it! Ship It! - Tushar Krishna On Jan. 10, 2017, 9:42 p.m

Re: [gem5-dev] Review Request 3753: ruby: Check MessageBuffer space in garnet NetworkInterface

2017-01-10 Thread Tushar Krishna
> On Jan. 10, 2017, 4:43 p.m., Tushar Krishna wrote: > > src/mem/ruby/network/garnet2.0/NetworkInterface.cc, line 150 > > <http://reviews.gem5.org/r/3753/diff/4/?file=64266#file64266line150> > > > > Hey Matt, > > There is a minor change I hav

Re: [gem5-dev] Review Request 3753: ruby: Check MessageBuffer space in garnet NetworkInterface

2017-01-10 Thread Tushar Krishna
The additional 1-cycle in NIC0 is going to be part of the src_queueing_delay so it is being accounted for. Does this make sense? If yes, can you update network delay to dequeue_time - enqueue_time - 1 ? And then ship it. Thanks, Tushar - Tushar

Re: [gem5-dev] Review Request 3753: ruby: Check MessageBuffer space in garnet NetworkInterface

2017-01-10 Thread Tushar Krishna
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3753/#review9242 --- Ship it! Ship It! - Tushar Krishna On Jan. 6, 2017, 11:59 p.m

Re: [gem5-dev] Review Request 3753: ruby: Check MessageBuffer space in garnet NetworkInterface

2016-12-09 Thread Tushar Krishna
> On Dec. 9, 2016, 5:03 a.m., Tushar Krishna wrote: > > src/mem/ruby/network/garnet2.0/NetworkInterface.cc, line 139 > > <http://reviews.gem5.org/r/3753/diff/2/?file=63961#file63961line139> > > > > If a flit is waiting for the output buffer to become free,

Re: [gem5-dev] Review Request 3753: ruby: Check MessageBuffer space in garnet NetworkInterface

2016-12-08 Thread Tushar Krishna
nstalled, then this variable becomes true. But if the stall queue is empty, unstalledMessage is returned false, which means stalledMessage is true .. which is not quite right. - Tushar Krishna On Dec. 9, 2016, 1:58 a.m., Matthew Poremba wrote: > > ---

Re: [gem5-dev] Review Request 3753: ruby: Check MessageBuffer space in garnet NetworkInterface

2016-12-08 Thread Tushar Krishna
e called from here or when the stall queue is read. ... The extLinkAvail piece of code is not needed. It gets subsumed here. - Tushar Krishna On Dec. 8, 2016, 11:34 p.m., Matthew Poremba wrote: > > --- > This is an automatically ge

Re: [gem5-dev] Review Request 3751: ruby: Check all VNETs for injection in garnet NetworkInterface

2016-12-08 Thread Tushar Krishna
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3751/#review9194 --- Ship it! Ship It! - Tushar Krishna On Dec. 8, 2016, 11:32 p.m

Re: [gem5-dev] Review Request 3711: ruby: Detect garnet network-level deadlock.

2016-12-01 Thread Tushar Krishna
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3711/#review9180 --- Ship it! Ship It! - Tushar Krishna On Dec. 1, 2016, 11:37 p.m

Re: [gem5-dev] Review Request 3711: ruby: Detect garnet network-level deadlock.

2016-11-27 Thread Tushar Krishna
711/#comment7888> 500,000 seems like a pretty large threshold value in my opinion, whatever be the size of the network. It means no packet left the router connected to the NI for 500K cycles. I think we can make it 50,000. - Tushar Krishna On Nov. 17, 2016, 6:37 p.m., Jieming Yin

[gem5-dev] changeset in gem5: config: fix typo in cluster topology.

2016-10-07 Thread Tushar Krishna
changeset 220fa4099b9a in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=220fa4099b9a description: config: fix typo in cluster topology. diffstat: configs/topologies/Cluster.py | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diffs (15 lines): diff -r

[gem5-dev] changeset in gem5: ruby: Add M5_VAR_USED before variables used o...

2016-10-06 Thread Tushar Krishna
changeset ebf2acd02fc5 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=ebf2acd02fc5 description: ruby: Add M5_VAR_USED before variables used only inside assert in garnet2.0. This removes errors when building gem5.fast diffstat:

[gem5-dev] changeset in gem5: ruby: garnet2.0

2016-10-06 Thread Tushar Krishna
changeset 10d59d546ea2 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=10d59d546ea2 description: ruby: garnet2.0 Revamped version of garnet with more optimized single-cycle routers, more configurability, and cleaner code. diffstat:

[gem5-dev] changeset in gem5: ruby: remove the original garnet code.

2016-10-06 Thread Tushar Krishna
changeset db895719c482 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=db895719c482 description: ruby: remove the original garnet code. Only garnet2.0 will be supported henceforth. diffstat: src/mem/ruby/network/garnet/BaseGarnetNetwork.cc

[gem5-dev] changeset in gem5: ruby: rename ALPHA_Network_test protocol to G...

2016-10-06 Thread Tushar Krishna
LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. +# +# Authors: Brad Beckmann +# Tushar Krishna + +import m5 +from m5.objects import * +from

[gem5-dev] changeset in gem5: config: make internal links in network topolo...

2016-10-06 Thread Tushar Krishna
OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY +# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. +# +# Authors: Tush

[gem5-dev] changeset in gem5: ruby: rename networktest to garnet_synthetic_...

2016-10-06 Thread Tushar Krishna
R BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY +# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. +# +# Author: Tushar Krishna + +import m

[gem5-dev] changeset in gem5: config: add port directions and per-router de...

2016-10-06 Thread Tushar Krishna
changeset 2365e9e396f7 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=2365e9e396f7 description: config: add port directions and per-router delay in topology. This patch adds port direction names to the links during topology creation, which can be used

[gem5-dev] changeset in gem5: config: add a separate config file for the ne...

2016-10-06 Thread Tushar Krishna
T, STRICT LIABILITY, OR TORT +# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. +# +# Authors: Tushar Krishna + +import math +import m5 +from m5.objects import * +from m5.defines import buildEnv +from m

Re: [gem5-dev] Review Request 3558: ruby: garnet2.0

2016-09-23 Thread Tushar Krishna
Thanks, Tushar - Tushar --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3558/#review8734 --- On Aug. 24, 2016, 3:24 p.m., Tushar Krishna wrote: > > ---

Re: [gem5-dev] Review Request 3555: config: make internal links in network topology unidirectional.

2016-08-24 Thread Tushar Krishna
tically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3555/#review8504 ----------- On Aug. 24, 2016, 3:22 p.m., Tushar Krishna wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://rev

Re: [gem5-dev] Review Request 3558: ruby: garnet2.0

2016-08-24 Thread Tushar Krishna
-CREATION src/mem/ruby/network/garnet2.0/InputUnit.cc PRE-CREATION src/mem/ruby/network/garnet2.0/NetworkInterface.hh PRE-CREATION src/mem/ruby/network/garnet2.0/NetworkInterface.cc PRE-CREATION Diff: http://reviews.gem5.org/r/3558/diff/ Testing --- Thanks, Tushar Krishna

Re: [gem5-dev] Review Request 3557: ruby: remove the original garnet code.

2016-08-24 Thread Tushar Krishna
/GarnetNetwork_d.cc d726d0cea027 src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.py d726d0cea027 src/mem/ruby/network/garnet/fixed-pipeline/InputUnit_d.hh d726d0cea027 Diff: http://reviews.gem5.org/r/3557/diff/ Testing --- Thanks, Tushar Krishna

Re: [gem5-dev] Review Request 3555: config: make internal links in network topology unidirectional.

2016-08-24 Thread Tushar Krishna
configs/topologies/Torus.py d726d0cea027 src/mem/ruby/network/BasicLink.hh d726d0cea027 src/mem/ruby/network/BasicLink.cc d726d0cea027 Diff: http://reviews.gem5.org/r/3555/diff/ Testing --- Thanks, Tushar Krishna ___ gem5-dev mailing list

Re: [gem5-dev] Review Request 3556: config: add port directions and per-router delay in topology.

2016-08-24 Thread Tushar Krishna
/3556/diff/ Testing --- Thanks, Tushar Krishna ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3554: config: add a separate config file for the network.

2016-08-24 Thread Tushar Krishna
--- Thanks, Tushar Krishna ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3550: ruby: rename networktest to garnet_synthetic_traffic.

2016-08-24 Thread Tushar Krishna
-CREATION src/cpu/testers/networktest/NetworkTest.py d726d0cea027 Diff: http://reviews.gem5.org/r/3550/diff/ Testing --- Thanks, Tushar Krishna ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3549: ruby: rename ALPHA_Network_test protocol to Garnet_standalone.

2016-08-24 Thread Tushar Krishna
/Garnet_standalone.py PRE-CREATION configs/ruby/Network_test.py d726d0cea027 src/mem/protocol/Garnet_standalone-cache.sm PRE-CREATION src/mem/protocol/Garnet_standalone-dir.sm PRE-CREATION Diff: http://reviews.gem5.org/r/3549/diff/ Testing --- Thanks, Tushar Krishna

[gem5-dev] Review Request: Topology: Set default value of mesh_rows to sqrt(num_routers)

2012-08-02 Thread Tushar Krishna
default value of mesh_rows to sqrt(num_routers) Diffs - configs/ruby/Ruby.py b4d0bdb52694 configs/topologies/Mesh.py b4d0bdb52694 configs/topologies/MeshDirCorners.py b4d0bdb52694 Diff: http://reviews.gem5.org/r/1337/diff/ Testing --- Thanks, Tushar Krishna

[gem5-dev] Review Request: NetworkTest: remove unnecessary memory allocation

2012-04-05 Thread Tushar Krishna
: remove unnecessary memory allocation Diffs - src/cpu/testers/networktest/networktest.cc 4148f9af0b70 Diff: http://reviews.gem5.org/r/1136/diff/ Testing --- Thanks, Tushar Krishna ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org

[gem5-dev] changeset in gem5: Garnet: Stats at vnet granularity + code cleanup

2012-03-19 Thread Tushar Krishna
changeset c739a3a829f5 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=c739a3a829f5 description: Garnet: Stats at vnet granularity + code cleanup This patch (1) Moves redundant code from fixed and flexible networks to BaseGarnetNetwork. (2)

[gem5-dev] changeset in gem5: GARNET: adding a fault model for resilient on...

2011-11-04 Thread Tushar Krishna
changeset df3b7a1e883f in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=df3b7a1e883f description: GARNET: adding a fault model for resilient on-chip network research. This patch adds a fault model, which provides the probability of a number of

Re: [gem5-dev] About OrionLink and wire

2011-10-25 Thread Tushar Krishna
These discussions might be better on the gem5-users list ... Can you re-send this email on that? I'll explain how you can separate out the power for different routers and ports ... On 10/25/2011 06:21 AM, lyh wrote: In a NoC, there are many routers. In general, some with more ports, some

Re: [gem5-dev] About OrionLink and wire

2011-10-24 Thread Tushar Krishna
They affect the capacitance. larger width -- larger cap larger spacing -- smaller cap What configuration did you run? I'll take a look ... On 10/24/2011 02:45 AM, lyh wrote: Thks for your quick answer. In the code, i have found that WIRE_WIDTH_SPACING has no effect on the static or dynamic

Re: [gem5-dev] modeling variable link bandwidth for garnet fixed-pipeline network

2011-10-21 Thread Tushar Krishna
Hi Lyh, Garnet requires the ni_flit_size to be same as bandwidth_factor which means you cannot use different bandwidth factors for different links .. However, if you specify different link latencies, you can mimic different bandwidths since flits will take more cycles on some links and fewer

Re: [gem5-dev] Review Request: GARNET: adding a fault model for resilient on-chip network research.

2011-07-08 Thread Tushar Krishna
wrote: This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/776/ Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, Nathan Binkert, Brad Beckmann, and Tushar Krishna. By Konstantinos Aisopos. Description GARNET: adding a fault model