Bobby R. Bruce has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/34275 )
Change subject: arch-arm: just return the fault in twoEqualRegInst{,Fp}
......................................................................
arch-arm: just return the fault in twoEqualRegInst{,Fp}
This prevents the code from using the uninitialized destReg when
running the ``if (imm >= eCount)`` branch, which will make GCC 10.2
report a -Werror=maybe-uninitialized error when building gem5.opt.
Change-Id: Ie6e7d3d47a1b65b840b2106263ecfc21eb6af26b
Signed-off-by: Iru Cai <mytbk920...@gmail.com>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/34275
Reviewed-by: Giacomo Travaglini <giacomo.travagl...@arm.com>
Maintainer: Giacomo Travaglini <giacomo.travagl...@arm.com>
Tested-by: kokoro <noreply+kok...@google.com>
---
M src/arch/arm/isa/insts/neon.isa
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Giacomo Travaglini: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/arch/arm/isa/insts/neon.isa
b/src/arch/arm/isa/insts/neon.isa
index d536d5b..1dfefe7 100644
--- a/src/arch/arm/isa/insts/neon.isa
+++ b/src/arch/arm/isa/insts/neon.isa
@@ -1417,8 +1417,8 @@
readDestCode = 'destElem = letoh(destReg.elements[i]);'
eWalkCode += '''
if (imm >= eCount) {
- fault = std::make_shared<UndefinedInstruction>(machInst, false,
- mnemonic);
+ return std::make_shared<UndefinedInstruction>(machInst, false,
+ mnemonic);
} else {
for (unsigned i = 0; i < eCount; i++) {
Element srcElem1 = letoh(srcReg1.elements[i]);
@@ -1519,8 +1519,8 @@
readDestCode = 'destReg = destRegs[i];'
eWalkCode += '''
if (imm >= eCount) {
- fault = std::make_shared<UndefinedInstruction>(machInst, false,
- mnemonic);
+ return std::make_shared<UndefinedInstruction>(machInst, false,
+ mnemonic);
} else {
for (unsigned i = 0; i < rCount; i++) {
float srcReg1 = srcRegs1[i];
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/34275
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ie6e7d3d47a1b65b840b2106263ecfc21eb6af26b
Gerrit-Change-Number: 34275
Gerrit-PatchSet: 2
Gerrit-Owner: Iru Cai <mytbk920...@gmail.com>
Gerrit-Reviewer: Bobby R. Bruce <bbr...@ucdavis.edu>
Gerrit-Reviewer: Giacomo Travaglini <giacomo.travagl...@arm.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s