Nikos Nikoleris has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/30094 )

Change subject: base: Fix ChannelAddr<->Addr conversation
......................................................................

base: Fix ChannelAddr<->Addr conversation

Previously calculating a ChannelAddr from an Addr and converting back
ignored that the start of the address range can be different than
0. After this change, ChannelAddr is always an address in the
continuous range [0, MaxChannelAddr).

Change-Id: Icd8b611c43da7f8ff102c1872b175be59ece7ae9
Signed-off-by: Nikos Nikoleris <nikos.nikole...@arm.com>
---
M src/base/channel_addr.hh
1 file changed, 2 insertions(+), 2 deletions(-)



diff --git a/src/base/channel_addr.hh b/src/base/channel_addr.hh
index 06fae72..56812c7 100644
--- a/src/base/channel_addr.hh
+++ b/src/base/channel_addr.hh
@@ -63,14 +63,14 @@
     constexpr ChannelAddr() : a(0) { }

     ChannelAddr(const AddrRange &range, Addr _a)
-        : a(range.removeIntlvBits(_a)) {}
+        : a(range.removeIntlvBits(_a) - range.start()) {}

     ChannelAddr(const ChannelAddr &) = default;
     ChannelAddr &operator=(const ChannelAddr &) = default;


     Addr getPA(const AddrRange &range) const {
-        return range.addIntlvBits(a);
+        return range.addIntlvBits(a) + range.start();
     }

     constexpr ChannelAddr operator|(const Type b) const {

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/30094
To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Icd8b611c43da7f8ff102c1872b175be59ece7ae9
Gerrit-Change-Number: 30094
Gerrit-PatchSet: 1
Gerrit-Owner: Nikos Nikoleris <nikos.nikole...@arm.com>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

Reply via email to