Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/52105 )
(
3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the
submitted one.
)Change subject: dev: Default the VirtIO device's endianness to little.
......................................................................
dev: Default the VirtIO device's endianness to little.
We only use VirtIO on simulated systems that are little endian now, and
if we use them on big endian systems in the future, the user can
explicitly configure that, rather than have it automatically change
which might be surprising.
Change-Id: Ie8de22541d409f2b2e5544237f472dae6714b437
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/52105
Reviewed-by: Andreas Sandberg <andreas.sandb...@arm.com>
Maintainer: Andreas Sandberg <andreas.sandb...@arm.com>
Tested-by: kokoro <noreply+kok...@google.com>
---
M src/dev/virtio/VirtIO.py
1 file changed, 19 insertions(+), 1 deletion(-)
Approvals:
Andreas Sandberg: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/dev/virtio/VirtIO.py b/src/dev/virtio/VirtIO.py
index b0ddb0e..93c31c6 100644
--- a/src/dev/virtio/VirtIO.py
+++ b/src/dev/virtio/VirtIO.py
@@ -51,7 +51,7 @@
subsystem = Param.UInt8(0x00, "VirtIO subsystem ID")
system = Param.System(Parent.any, "system object")
- byte_order = Param.ByteOrder(Parent.byte_order, "Device byte order")
+ byte_order = Param.ByteOrder('little', "Device byte order")
class VirtIODummyDevice(VirtIODeviceBase):
type = 'VirtIODummyDevice'
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/52105
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ie8de22541d409f2b2e5544237f472dae6714b437
Gerrit-Change-Number: 52105
Gerrit-PatchSet: 5
Gerrit-Owner: Gabe Black <gabe.bl...@gmail.com>
Gerrit-Reviewer: Andreas Sandberg <andreas.sandb...@arm.com>
Gerrit-Reviewer: Gabe Black <gabe.bl...@gmail.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
