Hoa Nguyen has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/57029 )
Change subject: mem-cache: Remove unused stats
......................................................................
mem-cache: Remove unused stats
hitLatency, demandHitLatency, and overallHitLatency are not used.
Change-Id: I55f4e3f357b8fba28ad878697260fddb38c9208e
Signed-off-by: Hoa Nguyen <hoangu...@ucdavis.edu>
---
M src/mem/cache/base.cc
M src/mem/cache/base.hh
2 files changed, 12 insertions(+), 35 deletions(-)
diff --git a/src/mem/cache/base.cc b/src/mem/cache/base.cc
index e268ae7..58a0f6c 100644
--- a/src/mem/cache/base.cc
+++ b/src/mem/cache/base.cc
@@ -2028,8 +2028,6 @@
("number of " + name + " hits").c_str()),
ADD_STAT(misses, statistics::units::Count::get(),
("number of " + name + " misses").c_str()),
- ADD_STAT(hitLatency, statistics::units::Tick::get(),
- ("number of " + name + " hit ticks").c_str()),
ADD_STAT(missLatency, statistics::units::Tick::get(),
("number of " + name + " miss ticks").c_str()),
ADD_STAT(accesses, statistics::units::Count::get(),
@@ -2086,15 +2084,6 @@
misses.subname(i, system->getRequestorName(i));
}
- // Hit latency statistics
- hitLatency
- .init(max_requestors)
- .flags(total | nozero | nonan)
- ;
- for (int i = 0; i < max_requestors; i++) {
- hitLatency.subname(i, system->getRequestorName(i));
- }
-
// Miss latency statistics
missLatency
.init(max_requestors)
@@ -2201,10 +2190,6 @@
"number of demand (read+write) hits"),
ADD_STAT(overallHits, statistics::units::Count::get(),
"number of overall hits"),
- ADD_STAT(demandHitLatency, statistics::units::Tick::get(),
- "number of demand (read+write) hit ticks"),
- ADD_STAT(overallHitLatency, statistics::units::Tick::get(),
- "number of overall hit ticks"),
ADD_STAT(demandMisses, statistics::units::Count::get(),
"number of demand (read+write) misses"),
ADD_STAT(overallMisses, statistics::units::Count::get(),
@@ -2339,17 +2324,6 @@
overallMissLatency.subname(i, system->getRequestorName(i));
}
- demandHitLatency.flags(total | nozero | nonan);
- demandHitLatency = SUM_DEMAND(hitLatency);
- for (int i = 0; i < max_requestors; i++) {
- demandHitLatency.subname(i, system->getRequestorName(i));
- }
- overallHitLatency.flags(total | nozero | nonan);
- overallHitLatency = demandHitLatency + SUM_NON_DEMAND(hitLatency);
- for (int i = 0; i < max_requestors; i++) {
- overallHitLatency.subname(i, system->getRequestorName(i));
- }
-
demandAccesses.flags(total | nozero | nonan);
demandAccesses = demandHits + demandMisses;
for (int i = 0; i < max_requestors; i++) {
diff --git a/src/mem/cache/base.hh b/src/mem/cache/base.hh
index 6fc7628..51cd2d1 100644
--- a/src/mem/cache/base.hh
+++ b/src/mem/cache/base.hh
@@ -1006,11 +1006,6 @@
@sa Packet::Command */
statistics::Vector misses;
/**
- * Total number of ticks per thread/command spent waiting for a
hit.
- * Used to calculate the average hit latency.
- */
- statistics::Vector hitLatency;
- /**
* Total number of ticks per thread/command spent waiting for a
miss.
* Used to calculate the average miss latency.
*/
@@ -1055,10 +1050,6 @@
statistics::Formula demandHits;
/** Number of hit for all accesses. */
statistics::Formula overallHits;
- /** Total number of ticks spent waiting for demand hits. */
- statistics::Formula demandHitLatency;
- /** Total number of ticks spent waiting for all hits. */
- statistics::Formula overallHitLatency;
/** Number of misses for demand accesses. */
statistics::Formula demandMisses;
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/57029
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I55f4e3f357b8fba28ad878697260fddb38c9208e
Gerrit-Change-Number: 57029
Gerrit-PatchSet: 1
Gerrit-Owner: Hoa Nguyen <hoangu...@ucdavis.edu>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
