Hello Ciro Santilli,

I'd like you to do a code review. Please visit

    https://gem5-review.googlesource.com/c/public/gem5/+/19817

to review the following change.


Change subject: configs: Add "root=" kernel option to the starter_fs parser
......................................................................

configs: Add "root=" kernel option to the starter_fs parser

This will allow to choose different locations from command line

Change-Id: Ia0ac8455fe7bd943ec0135bfb68001904ba8c288
Signed-off-by: Giacomo Travaglini <giacomo.travagl...@arm.com>
Reviewed-by: Ciro Santilli <ciro.santi...@arm.com>
---
M configs/example/arm/starter_fs.py
1 file changed, 4 insertions(+), 1 deletion(-)



diff --git a/configs/example/arm/starter_fs.py b/configs/example/arm/starter_fs.py
index 234c2ca..3c19031 100644
--- a/configs/example/arm/starter_fs.py
+++ b/configs/example/arm/starter_fs.py
@@ -179,7 +179,7 @@
         # memory layout.
         "norandmaps",
         # Tell Linux where to find the root disk image.
-        "root=/dev/vda1",
+        "root=%s" % args.root,
         # Mount the root disk read-write by default.
         "rw",
         # Tell Linux about the amount of physical memory present.
@@ -228,6 +228,9 @@
     parser.add_argument("--disk-image", type=str,
                         default=default_disk,
                         help="Disk to instantiate")
+    parser.add_argument("--root", type=str,
+                        default="/dev/vda1",
+                        help="Specify the kernel CLI root= argument")
     parser.add_argument("--script", type=str, default="",
                         help = "Linux bootscript")
     parser.add_argument("--cpu", type=str, choices=cpu_types.keys(),

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/19817
To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: Ia0ac8455fe7bd943ec0135bfb68001904ba8c288
Gerrit-Change-Number: 19817
Gerrit-PatchSet: 1
Gerrit-Owner: Giacomo Travaglini <giacomo.travagl...@arm.com>
Gerrit-Reviewer: Ciro Santilli <ciro.santi...@arm.com>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to