Tiago Mück has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/21929 )
Change subject: mem-ruby: fix possible MOESI_CMP deadlock
......................................................................
mem-ruby: fix possible MOESI_CMP deadlock
Freeing the L2 block only after local invalidates are acked in the OLSF
state may lead to a deadlock.
Change-Id: Ia4b60e5bc9e2d3315b874a8c6616478db6eb38c1
Signed-off-by: Tiago Mück <tiago.m...@arm.com>
---
M src/mem/ruby/protocol/MOESI_CMP_directory-L2cache.sm
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/mem/ruby/protocol/MOESI_CMP_directory-L2cache.sm
b/src/mem/ruby/protocol/MOESI_CMP_directory-L2cache.sm
index 8b6643e..ed91821 100644
--- a/src/mem/ruby/protocol/MOESI_CMP_directory-L2cache.sm
+++ b/src/mem/ruby/protocol/MOESI_CMP_directory-L2cache.sm
@@ -1912,6 +1912,9 @@
i_allocateTBE;
t_recordFwdXID;
ee_sendLocalInv;
+ gg_clearLocalSharers;
+ checkCacheNoSharersNoOwner;
+ rr_deallocateL2CacheBlock;
m_popRequestQueue;
}
@@ -1923,10 +1926,7 @@
transition(OLSF, All_Acks, I) {
c_sendDataFromTBEToFwdGETX;
- gg_clearLocalSharers;
s_deallocateTBE;
- checkCacheNoSharersNoOwner;
- rr_deallocateL2CacheBlock;
n_popTriggerQueue;
wa_wakeUpDependents;
}
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/21929
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: Ia4b60e5bc9e2d3315b874a8c6616478db6eb38c1
Gerrit-Change-Number: 21929
Gerrit-PatchSet: 1
Gerrit-Owner: Tiago Mück <tiago.m...@arm.com>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev
