Re: [gem5-dev] Review Request: syscall emulation: Clean up ioctl handling, and implement for x86.

2012-08-01 Thread Steve Reinhardt
On July 23, 2012, 11:12 a.m., Marc Orr wrote: src/sim/syscall_emul.hh, line 601 http://reviews.gem5.org/r/1318/diff/1/?file=28137#file28137line601 Why is this fatal being changed to a warn? I'm not necessarily against this, but I thought a lot of the effort and controversy

Re: [gem5-dev] Review Request: syscall emulation: Clean up ioctl handling, and implement for x86.

2012-08-01 Thread Ali Saidi
On July 23, 2012, 11:12 a.m., Marc Orr wrote: src/sim/syscall_emul.hh, line 601 http://reviews.gem5.org/r/1318/diff/1/?file=28137#file28137line601 Why is this fatal being changed to a warn? I'm not necessarily against this, but I thought a lot of the effort and controversy

Re: [gem5-dev] Review Request: syscall emulation: Clean up ioctl handling, and implement for x86.

2012-08-01 Thread Marc Orr
On July 23, 2012, 11:12 a.m., Marc Orr wrote: src/sim/syscall_emul.hh, line 601 http://reviews.gem5.org/r/1318/diff/1/?file=28137#file28137line601 Why is this fatal being changed to a warn? I'm not necessarily against this, but I thought a lot of the effort and controversy

Re: [gem5-dev] Review Request: syscall emulation: Clean up ioctl handling, and implement for x86.

2012-08-01 Thread Marc Orr
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1318/#review3186 --- Ship it! Ship It! - Marc Orr On July 22, 2012, 5:29 p.m., Steve

Re: [gem5-dev] Review Request: syscall emulation: Clean up ioctl handling, and implement for x86.

2012-07-23 Thread Marc Orr
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1318/#review3133 --- src/sim/syscall_emul.hh http://reviews.gem5.org/r/1318/#comment3289

[gem5-dev] Review Request: syscall emulation: Clean up ioctl handling, and implement for x86.

2012-07-22 Thread Steve Reinhardt
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1318/ --- Review request for Default. Description --- [Note: this is an updated version

Re: [gem5-dev] Review Request: syscall emulation: Clean up ioctl handling, and implement for x86.

2012-07-22 Thread Ali Saidi
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1318/#review3130 --- Ship it! Ship It! - Ali Saidi On July 22, 2012, 5:29 p.m., Steve