---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2312/#review5312
---
Ship it!
Looks good. Thanks for addressing the issues I raised earlier!
On Aug. 14, 2014, 9:28 a.m., Andreas Sandberg wrote:
src/mem/multi_level_page_table.hh, line 57
http://reviews.gem5.org/r/2312/diff/2/?file=40429#file40429line57
In general, I prefer having a abstract base classes for interfaces
since that makes documentation and compile-time
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2312/
---
(Updated Aug. 25, 2014, 9:08 p.m.)
Review request for Default.
Changes
---
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2312/#review5245
---
src/mem/multi_level_page_table.hh
On Aug. 14, 2014, 9:28 a.m., Andreas Sandberg wrote:
src/mem/page_table.hh, line 71
http://reviews.gem5.org/r/2312/diff/2/?file=40432#file40432line71
Any particular reason why these aren't const any more? I kinda like
having constants declared as such since that means the
