Re: [gem5-dev] Review Request 2490: mem: Remove null-check bypassing in Packet::getPtr

2014-11-30 Thread Andreas Hansson via gem5-dev
On Nov. 29, 2014, 8:04 p.m., Steve Reinhardt wrote: The changes to getPtr() look good to me. On the broader topic of zero-sized prefetches, I'm a little confused... I can see a CPU or CPU-like object (i.e., a tester) generate a zero-size prefetch as a touch operation, but then it

Re: [gem5-dev] Review Request 2490: mem: Remove null-check bypassing in Packet::getPtr

2014-11-29 Thread Steve Reinhardt via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2490/#review5568 --- Ship it! The changes to getPtr() look good to me. On the broader topic

Re: [gem5-dev] Review Request 2490: mem: Remove null-check bypassing in Packet::getPtr

2014-11-24 Thread Andreas Hansson via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2490/ --- (Updated Nov. 24, 2014, 12:18 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 2490: mem: Remove null-check bypassing in Packet::getPtr

2014-11-18 Thread Nilay Vaish via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2490/#review5469 --- Overall I am fine with the patch. Can we set the size to 1 when the

Re: [gem5-dev] Review Request 2490: mem: Remove null-check bypassing in Packet::getPtr

2014-11-18 Thread Andreas Hansson via gem5-dev
On Nov. 18, 2014, 3:44 p.m., Nilay Vaish wrote: Overall I am fine with the patch. Can we set the size to 1 when the prefetch request is being created? I don't see any harm in that. It might incur stats changes...that's my main reason for not changing anything. Perhaps it's worth

[gem5-dev] Review Request 2490: mem: Remove null-check bypassing in Packet::getPtr

2014-11-16 Thread Andreas Hansson via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2490/ --- Review request for Default. Repository: gem5 Description --- Changeset