Re: [gem5-dev] Review Request 2514: scons: Make the USE_KVM variable available in C++.

2014-12-17 Thread Andreas Hansson via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2514/#review5692 --- Ship it! Ship It! - Andreas Hansson On Nov. 19, 2014, 6:44 a.m.,

Re: [gem5-dev] Review Request 2514: scons: Make the USE_KVM variable available in C++.

2014-12-17 Thread Andreas Hansson via gem5-dev
On Dec. 17, 2014, 1:41 p.m., Andreas Hansson wrote: Ship It! Actually, looking at the Cirrus device, could we not simply check if KvmVM is nullptr? - Andreas --- This is an automatically generated e-mail. To reply, visit:

Re: [gem5-dev] Review Request 2514: scons: Make the USE_KVM variable available in C++.

2014-12-09 Thread Gabe Black via gem5-dev
On Nov. 19, 2014, 3:33 p.m., Andreas Sandberg wrote: The change itself makes sense, but I'd really prefer if we could avoid conditional compilation and use a kvm-agnostic interface to handle device memory. See my reply in the email thread for RB #2513. Consider this a ship it if it

Re: [gem5-dev] Review Request 2514: scons: Make the USE_KVM variable available in C++.

2014-11-19 Thread Andreas Sandberg via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2514/#review5488 --- The change itself makes sense, but I'd really prefer if we could avoid