Re: [gem5-dev] Review Request 2846: cpu: o3: Merging haltContext with suspendContext

2015-05-29 Thread Joel Hestness
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2846/#review6432 --- Ship it! Looks good. Thanks for investigating where to reset the

Re: [gem5-dev] Review Request 2846: cpu: o3: Merging haltContext with suspendContext

2015-05-28 Thread Alexandru Dutu
On May 27, 2015, 4:21 p.m., Joel Hestness wrote: Thanks for the insightful comments Joel! On May 27, 2015, 4:21 p.m., Joel Hestness wrote: src/arch/x86/isa/microops/specop.isa, line 70 http://reviews.gem5.org/r/2846/diff/1/?file=45418#file45418line70 Can you please set flags

Re: [gem5-dev] Review Request 2846: cpu: o3: Merging haltContext with suspendContext

2015-05-28 Thread Alexandru Dutu
On May 27, 2015, 4:21 p.m., Joel Hestness wrote: src/cpu/o3/cpu.cc, line 754 http://reviews.gem5.org/r/2846/diff/1/?file=45420#file45420line754 Is there a reason not to include code to clear stalls within fetch.squash() and decode.squash()? The stalls[tid] arrays are only

Re: [gem5-dev] Review Request 2846: cpu: o3: Merging haltContext with suspendContext

2015-05-28 Thread Alexandru Dutu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2846/ --- (Updated May 28, 2015, 7:02 p.m.) Review request for Default. Changes ---

Re: [gem5-dev] Review Request 2846: cpu: o3: Merging haltContext with suspendContext

2015-05-27 Thread Joel Hestness
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2846/#review6398 --- src/arch/x86/isa/microops/specop.isa (line 70)

[gem5-dev] Review Request 2846: cpu: o3: Merging haltContext with suspendContext

2015-05-26 Thread Alexandru Dutu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2846/ --- Review request for Default. Repository: gem5 Description --- Changeset

Re: [gem5-dev] Review Request 2846: cpu: o3: Merging haltContext with suspendContext

2015-05-26 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2846/#review6402 --- Ship it! Ship It! - Tony Gutierrez On May 26, 2015, 9:45 a.m.,