Re: [gem5-dev] Review Request 3002: ruby: slicc: fix naming of variables

2015-09-11 Thread Brad Beckmann
> On Sept. 4, 2015, 11:34 p.m., Brad Beckmann wrote: > > So there has been a lot of discussion on this patch, including splitting > > the patch up, but I have not seen a new version of the patch reposted. > > > > Again I really dislike these patches which touch all the .sm files. The > >

Re: [gem5-dev] Review Request 3002: ruby: slicc: fix naming of variables

2015-09-11 Thread Nilay Vaish
> On Sept. 4, 2015, 11:34 p.m., Brad Beckmann wrote: > > So there has been a lot of discussion on this patch, including splitting > > the patch up, but I have not seen a new version of the patch reposted. > > > > Again I really dislike these patches which touch all the .sm files. The > >

Re: [gem5-dev] Review Request 3002: ruby: slicc: fix naming of variables

2015-09-10 Thread Nilay Vaish
> On Sept. 4, 2015, 11:34 p.m., Brad Beckmann wrote: > > So there has been a lot of discussion on this patch, including splitting > > the patch up, but I have not seen a new version of the patch reposted. > > > > Again I really dislike these patches which touch all the .sm files. The > >

Re: [gem5-dev] Review Request 3002: ruby: slicc: fix naming of variables

2015-09-06 Thread Nilay Vaish
> On Sept. 4, 2015, 11:34 p.m., Brad Beckmann wrote: > > So there has been a lot of discussion on this patch, including splitting > > the patch up, but I have not seen a new version of the patch reposted. > > > > Again I really dislike these patches which touch all the .sm files. The > >

Re: [gem5-dev] Review Request 3002: ruby: slicc: fix naming of variables

2015-09-04 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3002/ --- (Updated Sept. 5, 2015, 12:50 a.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3002: ruby: slicc: fix naming of variables

2015-08-30 Thread Nilay Vaish
On Aug. 14, 2015, 2:08 p.m., Joel Hestness wrote: src/mem/slicc/symbols/StateMachine.py, line 609 http://reviews.gem5.org/r/3002/diff/1/?file=48684#file48684line609 A quick grep indicates that the primitive variable tag may no longer be necessary in SLICC. If so, can you remove

Re: [gem5-dev] Review Request 3002: ruby: slicc: fix naming of variables

2015-08-24 Thread Brad Beckmann
On Aug. 13, 2015, 5:59 p.m., Brad Beckmann wrote: Recently we discarded patch 2786 because it optionally allowed SLICC programs to specify whether an object is a pointer or not. Our patch was motivated because PerfectCacheMemory differed from CacheMemory and was a pretty special

Re: [gem5-dev] Review Request 3002: ruby: slicc: fix naming of variables

2015-08-14 Thread Joel Hestness
On Aug. 13, 2015, 5:59 p.m., Brad Beckmann wrote: Recently we discarded patch 2786 because it optionally allowed SLICC programs to specify whether an object is a pointer or not. Our patch was motivated because PerfectCacheMemory differed from CacheMemory and was a pretty special

Re: [gem5-dev] Review Request 3002: ruby: slicc: fix naming of variables

2015-08-14 Thread Joel Hestness
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3002/#review6938 --- I think this is a really smart patch, and hope that Brad will agree.

Re: [gem5-dev] Review Request 3002: ruby: slicc: fix naming of variables

2015-08-13 Thread Brad Beckmann
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3002/#review6937 --- Recently we discarded patch 2786 because it optionally allowed SLICC

Re: [gem5-dev] Review Request 3002: ruby: slicc: fix naming of variables

2015-08-13 Thread Joel Hestness
On Aug. 13, 2015, 5:59 p.m., Brad Beckmann wrote: Recently we discarded patch 2786 because it optionally allowed SLICC programs to specify whether an object is a pointer or not. Our patch was motivated because PerfectCacheMemory differed from CacheMemory and was a pretty special

Re: [gem5-dev] Review Request 3002: ruby: slicc: fix naming of variables

2015-08-13 Thread Brad Beckmann
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3002/#review6946 --- src/mem/slicc/ast/ObjDeclAST.py (line 57)

Re: [gem5-dev] Review Request 3002: ruby: slicc: fix naming of variables

2015-08-13 Thread Brad Beckmann
On Aug. 13, 2015, 5:59 p.m., Brad Beckmann wrote: Recently we discarded patch 2786 because it optionally allowed SLICC programs to specify whether an object is a pointer or not. Our patch was motivated because PerfectCacheMemory differed from CacheMemory and was a pretty special

Re: [gem5-dev] Review Request 3002: ruby: slicc: fix naming of variables

2015-08-13 Thread Nilay Vaish
On Aug. 13, 2015, 5:59 p.m., Brad Beckmann wrote: Recently we discarded patch 2786 because it optionally allowed SLICC programs to specify whether an object is a pointer or not. Our patch was motivated because PerfectCacheMemory differed from CacheMemory and was a pretty special

Re: [gem5-dev] Review Request 3002: ruby: slicc: fix naming of variables

2015-08-13 Thread Nilay Vaish
On Aug. 13, 2015, 5:59 p.m., Brad Beckmann wrote: src/mem/protocol/MOESI_hammer-dir.sm, line 197 http://reviews.gem5.org/r/3002/diff/1/?file=48675#file48675line197 Is moving the global fwd_set variable to a local variable orthogonal to the rest of this patch? You are right. I

Re: [gem5-dev] Review Request 3002: ruby: slicc: fix naming of variables

2015-08-13 Thread Nilay Vaish
On Aug. 13, 2015, 5:59 p.m., Brad Beckmann wrote: Recently we discarded patch 2786 because it optionally allowed SLICC programs to specify whether an object is a pointer or not. Our patch was motivated because PerfectCacheMemory differed from CacheMemory and was a pretty special

[gem5-dev] Review Request 3002: ruby: slicc: fix naming of variables

2015-08-02 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3002/ --- Review request for Default. Repository: gem5 Description --- Changeset