----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3435/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- Changeset 11437:5103da28c1da --------------------------- ruby: consolidate CntrlBase class definition and add method The CntrlBase class was declared in each of the GPU protocols instead using the shared module which was already defined (and equivalent to each definition). Also, the clearBase method is needed for multi-instance ruby support. The bookkeeping information that the class provides leaks across the controller definitions even when the controllers belong to different Ruby systems. The problem only manifests with the GPU protocols because those protocols are the only ones that use the CntrlBase class. Diffs ----- configs/ruby/CntrlBase.py cfad34a15729e1d5e096245f5a80ded6e2c379ca configs/ruby/GPU_RfO.py cfad34a15729e1d5e096245f5a80ded6e2c379ca configs/ruby/GPU_VIPER.py cfad34a15729e1d5e096245f5a80ded6e2c379ca configs/ruby/GPU_VIPER_Baseline.py cfad34a15729e1d5e096245f5a80ded6e2c379ca configs/ruby/GPU_VIPER_Region.py cfad34a15729e1d5e096245f5a80ded6e2c379ca configs/ruby/MOESI_AMD_Base.py cfad34a15729e1d5e096245f5a80ded6e2c379ca Diff: http://reviews.gem5.org/r/3435/diff/ Testing ------- Thanks, Brandon Potter _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
