Re: [gem5-dev] Review Request 3493: dev: Add 'simLength' parameter in EthPacketData

2016-10-19 Thread Andreas Sandberg
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3493/#review8921 --- Ship it! Ship It! - Andreas Sandberg On Oct. 12, 2016, 4:50 p.m.,

Re: [gem5-dev] Review Request 3493: dev: Add 'simLength' parameter in EthPacketData

2016-10-18 Thread Michael LeBeane
> On Oct. 3, 2016, 4:27 p.m., Andreas Sandberg wrote: > > src/dev/net/etherpkt.cc, line 44 > > > > > > I really don't like the way this is breaking checkpoints. > > > > The right thing to do here would be to

Re: [gem5-dev] Review Request 3493: dev: Add 'simLength' parameter in EthPacketData

2016-10-12 Thread Michael LeBeane
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3493/ --- (Updated Oct. 12, 2016, 3:50 p.m.) Review request for Default. Summary (updated)