----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3493/#review8921 -----------------------------------------------------------
Ship it! Ship It! - Andreas Sandberg On Oct. 12, 2016, 4:50 p.m., Michael LeBeane wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3493/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2016, 4:50 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11637:cd6bb67002fa > --------------------------- > dev: Add 'simLength' parameter in EthPacketData > Currently, all the network devices create a 16K buffer for the 'data' field > in EthPacketData, and use 'length' to keep track of the size of the packet > in the buffer. This patch introduces the 'simLength' parameter to > EthPacketData, which is used to hold the effective length of the packet used > for all timing calulations in the simulator. Serialization is performed using > only the useful data in the packet ('length') and not necessarily the entire > original buffer. > > > Diffs > ----- > > src/dev/net/i8254xGBe.cc e92bf392bf4302e2e88e19907e7fc981f59e777d > src/dev/net/ns_gige.cc e92bf392bf4302e2e88e19907e7fc981f59e777d > src/dev/net/pktfifo.cc e92bf392bf4302e2e88e19907e7fc981f59e777d > src/dev/net/dist_etherlink.cc e92bf392bf4302e2e88e19907e7fc981f59e777d > src/dev/net/dist_iface.cc e92bf392bf4302e2e88e19907e7fc981f59e777d > src/dev/net/dist_packet.hh e92bf392bf4302e2e88e19907e7fc981f59e777d > src/dev/net/etherbus.cc e92bf392bf4302e2e88e19907e7fc981f59e777d > src/dev/net/etherlink.cc e92bf392bf4302e2e88e19907e7fc981f59e777d > src/dev/net/etherpkt.hh e92bf392bf4302e2e88e19907e7fc981f59e777d > src/dev/net/etherpkt.cc e92bf392bf4302e2e88e19907e7fc981f59e777d > src/dev/net/etherswitch.cc e92bf392bf4302e2e88e19907e7fc981f59e777d > src/dev/net/ethertap.cc e92bf392bf4302e2e88e19907e7fc981f59e777d > src/dev/net/tcp_iface.cc e92bf392bf4302e2e88e19907e7fc981f59e777d > src/dev/net/sinic.cc e92bf392bf4302e2e88e19907e7fc981f59e777d > > Diff: http://reviews.gem5.org/r/3493/diff/ > > > Testing > ------- > > > Thanks, > > Michael LeBeane > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
