Re: [gem5-dev] Review Request 3662: syscall_emul: [patch 2/22] move SyscallDesc into its own .hh and .cc

2016-10-19 Thread Steve Reinhardt
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3662/#review8939 --- Ship it! Ship It! - Steve Reinhardt On Oct. 19, 2016, 3:30 p.m.,

Re: [gem5-dev] Review Request 3662: syscall_emul: [patch 2/22] move SyscallDesc into its own .hh and .cc

2016-10-19 Thread Brandon Potter
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3662/ --- (Updated Oct. 19, 2016, 10:30 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3662: syscall_emul: [patch 2/22] move SyscallDesc into its own .hh and .cc

2016-10-19 Thread Brandon Potter
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3662/ --- (Updated Oct. 19, 2016, 10:25 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3662: syscall_emul: [patch 2/22] move SyscallDesc into its own .hh and .cc

2016-10-19 Thread Steve Reinhardt
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3662/#review8927 --- src/sim/syscall_desc.hh (line 67)

Re: [gem5-dev] Review Request 3662: syscall_emul: [patch 2/22] move SyscallDesc into its own .hh and .cc

2016-10-19 Thread Steve Reinhardt
> On Oct. 11, 2016, 4:43 p.m., Tony Gutierrez wrote: > > src/sim/syscall_desc.hh, line 66 > > > > > > (void) is not necessary in c++. also this is not gem5 convention. > > Brandon Potter wrote: > I tried to get the same

Re: [gem5-dev] Review Request 3662: syscall_emul: [patch 2/22] move SyscallDesc into its own .hh and .cc

2016-10-17 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3662/#review8884 --- Ship it! Ship It! - Jason Lowe-Power On Oct. 17, 2016, 3:08 p.m.,

Re: [gem5-dev] Review Request 3662: syscall_emul: [patch 2/22] move SyscallDesc into its own .hh and .cc

2016-10-17 Thread Alexandru Dutu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3662/#review8871 --- Ship it! Ship It! - Alexandru Dutu On Oct. 17, 2016, 3:08 p.m.,

Re: [gem5-dev] Review Request 3662: syscall_emul: [patch 2/22] move SyscallDesc into its own .hh and .cc

2016-10-17 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3662/#review8869 --- Ship it! Ship It! - Tony Gutierrez On Oct. 17, 2016, 8:08 a.m.,

Re: [gem5-dev] Review Request 3662: syscall_emul: [patch 2/22] move SyscallDesc into its own .hh and .cc

2016-10-17 Thread Michael LeBeane
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3662/#review8862 --- Ship it! Ship It! - Michael LeBeane On Oct. 17, 2016, 3:08 p.m.,

Re: [gem5-dev] Review Request 3662: syscall_emul: [patch 2/22] move SyscallDesc into its own .hh and .cc

2016-10-17 Thread Brandon Potter
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3662/ --- (Updated Oct. 17, 2016, 3:08 p.m.) Review request for Default. Summary (updated)