Re: [gem5-dev] Review Request 3754: cpu: Simplify the rename interface and use RegId

2017-01-24 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3754/#review9309 --- Ship it! Ship It! - Jason Lowe-Power On Jan. 16, 2017, 11:46 a.m.,

Re: [gem5-dev] Review Request 3754: cpu: Simplify the rename interface and use RegId

2017-01-24 Thread Rekai Gonzalez Alberquilla
> On Jan. 19, 2017, 10:13 p.m., Jason Lowe-Power wrote: > > src/cpu/reg_class_impl.hh, line 1 > > > > > > Why is this an implemenation header file? Because it is something that can/should be inlined, as the control has

Re: [gem5-dev] Review Request 3754: cpu: Simplify the rename interface and use RegId

2017-01-19 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3754/#review9284 --- I've looked through the patch... but I really don't know anything about

[gem5-dev] Review Request 3754: cpu: Simplify the rename interface and use RegId

2017-01-16 Thread Rekai Gonzalez Alberquilla
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3754/ --- Review request for Default. Summary (updated) - cpu: Simplify the