Re: [gem5-dev] Trunk does not build due to recent syscall_emul patch

2016-03-29 Thread Steve Reinhardt
FYI, I posted a couple of patches that should fix this a few days ago: http://reviews.gem5.org/r/3402 http://reviews.gem5.org/r/3403 Just waiting on some reviews before I commit them. Steve On Thu, Mar 24, 2016 at 2:43 PM Andreas Hansson wrote: > Well, looking at the

Re: [gem5-dev] Trunk does not build due to recent syscall_emul patch

2016-03-24 Thread Andreas Hansson
Well, looking at the error message below there is also O_NOATIME, and then quite a bunch of the MAP_* flags. Andreas On 24/03/2016, 21:14, "gem5-dev on behalf of Steve Reinhardt" wrote: >Is it just the MAP_* flags? > >On Thu, Mar 24,

Re: [gem5-dev] Trunk does not build due to recent syscall_emul patch

2016-03-24 Thread Steve Reinhardt
Is it just the MAP_* flags? On Thu, Mar 24, 2016 at 2:12 PM Andreas Hansson wrote: > Hi Steve, > > I suspect that is the whole list. > > Andreas > > On 24/03/2016, 13:40, "gem5-dev on behalf of Steve Reinhardt" >

Re: [gem5-dev] Trunk does not build due to recent syscall_emul patch

2016-03-24 Thread Andreas Hansson
Hi Steve, I suspect that is the whole list. Andreas On 24/03/2016, 13:40, "gem5-dev on behalf of Steve Reinhardt" wrote: >Alternatively, if it's easier for you to just construct a list of the >flags >that you've seen show up as

Re: [gem5-dev] Trunk does not build due to recent syscall_emul patch

2016-03-24 Thread Steve Reinhardt
Alternatively, if it's easier for you to just construct a list of the flags that you've seen show up as undefined on the platforms you compile on, we can add the ifdefs ourselves and commit it, though we'd still only be able to test on the same set of platforms as before. Shouldn't break

Re: [gem5-dev] Trunk does not build due to recent syscall_emul patch

2016-03-24 Thread Steve Reinhardt
Sorry. We tested extensively on the set of platforms that are available to us, but those are all Linux variants. Clearly it's just a matter of referencing OS flags that are undefined on a particular platform, and all that needs to be done is to take the offending { OS::TGT_OS_FLAG, OS_FLAG }

[gem5-dev] Trunk does not build due to recent syscall_emul patch

2016-03-24 Thread Andreas Hansson
Hi all (and Brandon in particular), Unfortunately http://repo.gem5.org/gem5/rev/5ac090acd180 causes build issues on OSX and even certain Linux systems (with older kernels, and also specific kernel configurations). Brandon, could you either back this out, or find some alternative solution to