changeset d1d95f0f4563 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=d1d95f0f4563 description: dev: Remove unused system pointer in the Platform base class
The Platform base class contains a pointer to an instance of the System which is never initialized. This can lead to subtle bugs since some architecture-specific platform implementations contain their own system pointer which is normally used. However, if the platform is accessed through a pointer to its base class, the dangling pointer will be used instead. diffstat: src/dev/platform.hh | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diffs (13 lines): diff -r 94901e131a7f -r d1d95f0f4563 src/dev/platform.hh --- a/src/dev/platform.hh Fri Feb 06 18:01:22 2015 -0800 +++ b/src/dev/platform.hh Wed Feb 11 10:23:22 2015 -0500 @@ -55,9 +55,6 @@ /** Pointer to the interrupt controller */ IntrControl *intrctrl; - /** Pointer to the system for info about the memory system. */ - System *system; - public: typedef PlatformParams Params; Platform(const Params *p); _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev