I've created a Jira ticket for this:
https://gem5.atlassian.net/browse/GEM5-321 I'll get to work on it.
--
Dr. Bobby R. Bruce
Room 2235,
Kemper Hall, UC Davis
Davis,
CA, 95616
web: https://www.bobbybruce.net
On Mon, Feb 10, 2020 at 5:58 AM Jason Lowe-Power
wrote:
> Hi all,
>
> I think we
Hi all,
I think we should solve this problem instead ignoring it. It's good to have
this check as a huge number of reviews are simply "please update the commit
message", which is also a bad experience.
@Bobby: Could you try to figure out a more user-friendly way for the commit
message to be
Gabe,
I just saw your other e-mail (could you please CC me if you respond to this? My
e-mail provider blocks all your e-mails, not even letting reach the spam
box...), and although I did not understand the proper sequence of commands
done, and I have never had an issue when creating commits
Hi Gabe,
Sorry for the inconvenience, but as Bobby pointed out, the commit message is
not discarded, and its backup's location is explicitly stated on a failure. If
it is preferred it could also be printed for ease of access, but when I tried
this locally it clogged the output, making it
It is thrown away if you then attempt to create another commit, assuming
the first one went worked, overwriting COMMIT_EDITMSG. Then when I wrote
the message again it failed again, and then I ran git commit trying to
figure out what happened, and the COMMIT_EDITMSG was thrown away again.
There is
Gabe,
Commit messages are not thrown away but are instead stored in
"./.git/COMMIT_EDITMSG"
if rejected. Perhaps this should be explicitly stated when a commit message
is rejected.
As you may already be aware, this is a result of Daniel's (relatively) new
git commit message checks:
I think until this changes, --no-verify is going to become a permanent
fixture of my commit command line.
Gabe
On Sun, Feb 9, 2020 at 7:20 PM Gabe Black wrote:
> Hi folks. I just spent 10 minutes writing up a commit message, only for it
> to be thrown away because git didn't like the tag I had
