Re: [gem5-dev] Review Request 3585: misc: Remove FullSystem check for networking components

2016-08-17 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3585/#review8647 --- Ship it! Ship It! - Andreas Hansson On Aug. 16, 2016, 10:32 p.m.,

Re: [gem5-dev] Review Request 3604: base: Output all AddrRange parameters to config.ini

2016-08-17 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3604/#review8646 --- Ship it! No objections. We have been thinking of making this simpler,

Re: [gem5-dev] Review Request 3619: kvm: Support timing accesses for KVM cpu

2016-08-17 Thread Andreas Sandberg
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3619/#review8645 --- Thanks for implementing this! Overall, I think this is the right

Re: [gem5-dev] Review Request 3619: kvm: Support timing accesses for KVM cpu

2016-08-17 Thread Michael LeBeane
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3619/ --- (Updated Aug. 17, 2016, 8:07 p.m.) Review request for Default. Changes ---

Re: [gem5-dev] Review Request 3585: misc: Remove FullSystem check for networking components

2016-08-17 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3585/#review8648 --- Ship it! Ship It! - Jason Lowe-Power On Aug. 16, 2016, 10:32 p.m.,

Re: [gem5-dev] Review Request 3586: dev: Exit correctly in dist-gem5

2016-08-17 Thread Mohammad Alian
> On Aug. 16, 2016, 9:26 p.m., Mohammad Alian wrote: > > Thanks for this fix. Just one issue that I think still is not resolved for > > the termination of dist-gem5 simulations. Maybe Gabor also has an opinoin > > on this. > > When one of the gem5 processes (nodes) disconnects from message

Re: [gem5-dev] Review Request 3586: dev: Exit correctly in dist-gem5

2016-08-17 Thread Michael LeBeane
> On Aug. 16, 2016, 9:26 p.m., Mohammad Alian wrote: > > Thanks for this fix. Just one issue that I think still is not resolved for > > the termination of dist-gem5 simulations. Maybe Gabor also has an opinoin > > on this. > > When one of the gem5 processes (nodes) disconnects from message

Re: [gem5-dev] Review Request 3586: dev: Exit correctly in dist-gem5

2016-08-17 Thread Gabor Dozsa
> On Aug. 16, 2016, 9:26 p.m., Mohammad Alian wrote: > > Thanks for this fix. Just one issue that I think still is not resolved for > > the termination of dist-gem5 simulations. Maybe Gabor also has an opinoin > > on this. > > When one of the gem5 processes (nodes) disconnects from message

Re: [gem5-dev] Review Request 3619: kvm: Support timing accesses for KVM cpu

2016-08-17 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3619/#review8652 --- Overall it looks great. Some concerns regarding packet ordering and

Re: [gem5-dev] Review Request 3619: kvm: Support timing accesses for KVM cpu

2016-08-17 Thread Michael LeBeane
> On Aug. 17, 2016, 10:05 p.m., Andreas Hansson wrote: > > src/cpu/kvm/base.cc, line 228 > > > > > > Conceptually this is not very nice, as it assumes infinite throughput. > > > > I see how we save an even this

[gem5-dev] Cron <m5test@zizzer> /z/m5/regression/do-regression quick

2016-08-17 Thread Cron Daemon
* build/ALPHA/tests/opt/quick/se/00.hello/alpha/tru64/o3-timing: passed. * build/ALPHA/tests/opt/quick/se/03.learning-gem5/alpha/linux/learning-gem5-p1-simple: passed. * build/ALPHA/tests/opt/quick/se/01.hello-2T-smt/alpha/linux/o3-timing-mt: passed. *

Re: [gem5-dev] Review Request 3590: Add a DmaCallback class to DmaDevice

2016-08-17 Thread Andreas Sandberg
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3590/#review8644 --- Ship it! Ship It! - Andreas Sandberg On Aug. 16, 2016, 11:31 p.m.,