----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3619/#review8652 -----------------------------------------------------------
Overall it looks great. Some concerns regarding packet ordering and flow-control handling. src/cpu/kvm/base.hh (line 589) <http://reviews.gem5.org/r/3619/#comment7500> a stack? src/cpu/kvm/base.hh (line 592) <http://reviews.gem5.org/r/3619/#comment7499> unsigned int? src/cpu/kvm/base.cc (line 189) <http://reviews.gem5.org/r/3619/#comment7501> if we already have queued packets, should this not be added FIFO? also, if we are waiting for a retry, we should not attempt to send a new packet src/cpu/kvm/base.cc (line 210) <http://reviews.gem5.org/r/3619/#comment7502> This is odd. We did not receive a retry, we received a response. We should not call sendTiming again until we get a retry. It only wastes cycles as we will make no progress. src/cpu/kvm/base.cc (line 228) <http://reviews.gem5.org/r/3619/#comment7503> Conceptually this is not very nice, as it assumes infinite throughput. I see how we save an even this way, but I am tempted to suggest the inclusion of an even rather. - Andreas Hansson On Aug. 17, 2016, 8:07 p.m., Michael LeBeane wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3619/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2016, 8:07 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11561:4595cc3848fc > --------------------------- > kvm: Support timing accesses for KVM cpu > This patch enables timing accesses for KVM cpu. A new state, > RunningMMIOPending, is added to indicate that there are outstanding timing > requests generated by KVM in the system. KVM's tick() is disabled and the > simulation does not enter into KVM until all outstanding timing requests have > completed. The main motivation for this is to allow KVM CPU to perform MMIO > in Ruby, since Ruby does not support atomic accesses. > > > Diffs > ----- > > src/cpu/kvm/base.hh 91f58918a76abf1a1dedcaa70a9b95789da7b88c > src/cpu/kvm/base.cc 91f58918a76abf1a1dedcaa70a9b95789da7b88c > src/cpu/kvm/x86_cpu.cc 91f58918a76abf1a1dedcaa70a9b95789da7b88c > > Diff: http://reviews.gem5.org/r/3619/diff/ > > > Testing > ------- > > > Thanks, > > Michael LeBeane > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
