* build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/minor-timing passed.
* build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/o3-timing passed.
* build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/simple-timing passed.
*
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2499/
---
(Updated Nov. 26, 2014, 10:05 a.m.)
Review request for Default.
Repository: gem5
On Nov. 25, 2014, 10:11 p.m., Nilay Vaish wrote:
src/mem/packet.hh, line 884
http://reviews.gem5.org/r/2499/diff/1/?file=42571#file42571line884
We need better explanation here. What do you mean by nature of
copying static pointers into forwarded packets?
I have added far more
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2523/#review5552
---
I thought the style guide said there were supposed to be spaces around
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2521/#review5553
---
Ship it!
The keyword needs updating, for the rest it looks fine.
-
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2520/#review5554
---
src/dev/x86/i8042.cc
http://reviews.gem5.org/r/2520/#comment4981
On Nov. 26, 2014, 10:45 a.m., Andreas Hansson wrote:
I thought the style guide said there were supposed to be spaces around
operators and assignments, or am I missing something?
I don't think the style guide says, or at least not that I see. I may be
tending to the style we use at work.
On Nov. 26, 2014, 10:49 a.m., Andreas Hansson wrote:
src/dev/x86/i8042.cc, line 261
http://reviews.gem5.org/r/2520/diff/1/?file=42720#file42720line261
for (auto k : keys)
bufferData(k, 1)
What is this sorcery? :-) Seriously though, what's this from? Does gcc 0.1 or
On Nov. 26, 2014, 10:49 a.m., Andreas Hansson wrote:
src/dev/x86/i8042.cc, line 261
http://reviews.gem5.org/r/2520/diff/1/?file=42720#file42720line261
for (auto k : keys)
bufferData(k, 1)
Gabe Black wrote:
What is this sorcery? :-) Seriously though, what's this
On Nov. 26, 2014, 10:45 a.m., Andreas Hansson wrote:
I thought the style guide said there were supposed to be spaces around
operators and assignments, or am I missing something?
Gabe Black wrote:
I don't think the style guide says, or at least not that I see. I may be
tending to
On Nov. 26, 2014, 10:45 a.m., Andreas Hansson wrote:
I thought the style guide said there were supposed to be spaces around
operators and assignments, or am I missing something?
Gabe Black wrote:
I don't think the style guide says, or at least not that I see. I may be
tending to
I just ran into some issues with kvm on x86. It seems like changeset
1bd64b294fe4 (x86: add LongModeAddressSize function to cpuid) breaks
Linux running in kvm. It seems like the offending change makes cpuid
report the virtual and physical address length as 255 bits, which
clearly doesn't make
I already fixed it. The change should be checked in, I think.
Gabe
On Nov 26, 2014 5:52 AM, Andreas Sandberg via gem5-dev gem5-dev@gem5.org
wrote:
I just ran into some issues with kvm on x86. It seems like changeset
1bd64b294fe4 (x86: add LongModeAddressSize function to cpuid) breaks
Linux
Thanks! I should have checked the upstream commit log.
//Andreas
On 26/11/14 13:54, Gabe Black via gem5-dev wrote:
I already fixed it. The change should be checked in, I think.
Gabe
On Nov 26, 2014 5:52 AM, Andreas Sandberg via gem5-dev gem5-dev@gem5.org
wrote:
I just ran into some issues
On Wed, Nov 26, 2014 at 4:30 AM, Gabe Black via gem5-dev gem5-dev@gem5.org
wrote:
Just to make sure we're all on the same page, I removed the spaces here
because these are default values for arguments. My brain might have just
pattern matched and applied a rule for named function arguments
Hi Andreas,
Sorry for the late reply, I have missed your email. I will investigate more the
issues with memory controller refresh events and let you know what I find out.
Best regards,
Alex
___
gem5-dev mailing list
gem5-dev@gem5.org
16 matches
Mail list logo
