Re: [gem5-dev] Review Request 2519: x86: i8042: Give the keyboard controller a little TLC.

2014-12-21 Thread Ali Saidi via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2519/#review5700 --- Ship it! seems fine to me, although I can't say I know the code well -

Re: [gem5-dev] Review Request 2525: x86: Add a cirrus graphics adapter to x86 systems.

2014-12-21 Thread Ali Saidi via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2525/#review5701 --- Ship it! Seems fine... Anyone who deals with Ruby OK? - Ali Saidi On

Re: [gem5-dev] Review Request 2565: arm: Clean up and document decoder API

2014-12-21 Thread Andreas Hansson via gem5-dev
On Dec. 12, 2014, 10:21 p.m., Gabe Black wrote: src/arch/arm/decoder.cc, line 61 http://reviews.gem5.org/r/2565/diff/1/?file=43028#file43028line61 If I'm remembering correctly, I think I put these in the .hh so that they could be easily inlined by callers, although I can't quite

[gem5-dev] Christmas commit

2014-12-21 Thread Andreas Hansson via gem5-dev
Hi all, I intend to push the following patches next week (a proper Christmas commit that is). Let me know if you have any comments or need additional time to review the proposed changes. Happy holidays, everyone. Andreas # SimPoint fixes http://reviews.gem5.org/r/2516/ # PMU filtering

[gem5-dev] Cron m5test@zizzer /z/m5/regression/do-regression --scratch all

2014-12-21 Thread Cron Daemon via gem5-dev
* build/SPARC/tests/opt/long/fs/80.solaris-boot/sparc/solaris/t1000-simple-atomic CHANGED! * build/ARM/tests/opt/long/fs/10.linux-boot/arm/linux/realview-o3-dual CHANGED! scons: *** Error 1 scons: *** Error 1 *