----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2519/#review5700 -----------------------------------------------------------
Ship it! seems fine to me, although I can't say I know the code well - Ali Saidi On Dec. 17, 2014, 7:35 a.m., Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2519/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2014, 7:35 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10612:740dbb64ce34 > --------------------------- > x86: i8042: Give the keyboard controller a little TLC. > > This CL fixes a few minor bugs, and fills out the general implementation a bit > so that it can more readily support actually returning keyboard input. > > > Diffs > ----- > > src/dev/x86/i8042.hh a0cb57e1c072965dcdd51465beff37b264b41424 > src/dev/x86/i8042.cc a0cb57e1c072965dcdd51465beff37b264b41424 > > Diff: http://reviews.gem5.org/r/2519/diff/ > > > Testing > ------- > > > Thanks, > > Gabe Black > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
