Re: [gem5-dev] gem5.opt => opt/gem5?

2017-11-20 Thread Gabe Black
The opt and debug variants would still be separated, just in different directories instead of with different extensions, ie foo.do and foo.o => debug/foo.o and opt/foo.o. Gabe On Nov 20, 2017 9:36 PM, "Sam Xi" wrote: > How would this work from the perspective of the object files and > increment

Re: [gem5-dev] gem5.opt => opt/gem5?

2017-11-20 Thread Sam Xi
How would this work from the perspective of the object files and incremental builds? Suppose I build the opt variant and then the debug variant, change a file, then rebuild the opt variant. Would the entire opt variant need to be rebuilt because the debug variant blew away all of those object files

[gem5-dev] Change in public/gem5[master]: sim: Fix need to save address space info during serialization.

2017-11-20 Thread Austin Harris (Gerrit)
Hello Gabe Black, Jason Lowe-Power, Brandon Potter, I'd like you to reexamine a change. Please visit https://gem5-review.googlesource.com/5901 to look at the new patch set (#2). Change subject: sim: Fix need to save address space info during serialization. ..

[gem5-dev] gem5.opt => opt/gem5?

2017-11-20 Thread Gabe Black
Hi folks. I've been digging around in the scons files, and I was thinking about the possibility of treating opt, fast, debug, etc., as actual variants from the scons perspective instead of having them all live in the same directory but with different extensions. I think the biggest difference this

[gem5-dev] Change in public/gem5[master]: scons: Switch from "guards" to "tags" on source files.

2017-11-20 Thread Gabe Black (Gerrit)
Hello Jason Lowe-Power, Andreas Sandberg, I'd like you to reexamine a change. Please visit https://gem5-review.googlesource.com/5822 to look at the new patch set (#2). Change subject: scons: Switch from "guards" to "tags" on source files. ...

Re: [gem5-dev] [EXT] Re: testing framework

2017-11-20 Thread Gabe Black
What I would minimally like to see is for people to run the unit tests that already exist. Clearly that hasn't been happening since one of them hasn't compiled since 2014 (now fixed). We need our tests to test something specific, say whether or not it worked (not leave interpretation up to the read

Re: [gem5-dev] [EXT] Re: testing framework

2017-11-20 Thread Potter, Brandon
I also support adding unit tests (and possibly a code coverage checker to identify weak points). Ideally, we'd add unit tests for the entire simulator, but we should probably put something into place for new code requiring some type of unit tests. Otherwise, only a subset of the submissions will

[gem5-dev] Change in public/gem5[master]: sim: Fix need to save address space info during serialization.

2017-11-20 Thread Austin Harris (Gerrit)
Austin Harris has uploaded this change for review. ( https://gem5-review.googlesource.com/5901 Change subject: sim: Fix need to save address space info during serialization. .. sim: Fix need to save address space info duri

[gem5-dev] Change in public/gem5[master]: arch-arm: Ensure counters keep events on checkpoint resume

2017-11-20 Thread Andreas Sandberg (Gerrit)
Andreas Sandberg has submitted this change and it was merged. ( https://gem5-review.googlesource.com/5761 ) Change subject: arch-arm: Ensure counters keep events on checkpoint resume .. arch-arm: Ensure counters keep events on

[gem5-dev] Change in public/gem5[master]: cpu: Make automatic transition to OFF optional

2017-11-20 Thread Andreas Sandberg (Gerrit)
Andreas Sandberg has submitted this change and it was merged. ( https://gem5-review.googlesource.com/5741 ) Change subject: cpu: Make automatic transition to OFF optional .. cpu: Make automatic transition to OFF optional Add

Re: [gem5-dev] [EXT] Re: testing framework

2017-11-20 Thread Jason Lowe-Power
I'm all for unit tests. GTest seems fine, but I'm not a huge fan of its syntax. Although, that shouldn't stop us from having unit tests!! What's the state of getting whimsy pushed in? From my side, it's ready to go. The only thing on my to do list that I would have liked to finish up before pushin

[gem5-dev] Change in public/gem5[master]: cpu-o3: Prevent cpu from suspending if it is already draining

2017-11-20 Thread Nikos Nikoleris (Gerrit)
Hello Andreas Sandberg, I'd like you to do a code review. Please visit https://gem5-review.googlesource.com/5881 to review the following change. Change subject: cpu-o3: Prevent cpu from suspending if it is already draining ...

[gem5-dev] Change in public/gem5[master]: cpu: Make automatic transition to OFF optional

2017-11-20 Thread Andreas Sandberg (Gerrit)
Hello Jason Lowe-Power, I'd like you to reexamine a change. Please visit https://gem5-review.googlesource.com/5741 to look at the new patch set (#3). Change subject: cpu: Make automatic transition to OFF optional .. cpu:

[gem5-dev] Change in public/gem5[master]: pwr: Adds logic to enter power gating for the cpu model

2017-11-20 Thread Andreas Sandberg (Gerrit)
Andreas Sandberg has submitted this change and it was merged. ( https://gem5-review.googlesource.com/3969 ) Change subject: pwr: Adds logic to enter power gating for the cpu model .. pwr: Adds logic to enter power gating for t

[gem5-dev] Change in public/gem5[master]: arch-arm: Fix MCR/MRC disassemble

2017-11-20 Thread Giacomo Travaglini (Gerrit)
Hello Nikos Nikoleris, I'd like you to do a code review. Please visit https://gem5-review.googlesource.com/5862 to review the following change. Change subject: arch-arm: Fix MCR/MRC disassemble .. arch-arm: Fix MCR/MRC d

[gem5-dev] Change in public/gem5[master]: arch-arm: Fix MSR/MRS disassemble

2017-11-20 Thread Giacomo Travaglini (Gerrit)
Hello Nikos Nikoleris, I'd like you to do a code review. Please visit https://gem5-review.googlesource.com/5861 to review the following change. Change subject: arch-arm: Fix MSR/MRS disassemble .. arch-arm: Fix MSR/MRS d

[gem5-dev] Cron /z/m5/regression/do-regression quick

2017-11-20 Thread Cron Daemon
* build/RISCV/tests/opt/quick/se/00.hello/riscv/linux/minor-timing: FAILED! *** diff[config.json]: SKIPPED* build/RISCV/tests/opt/quick/se/00.hello/riscv/linux/o3-timing: FAILED! * build/RISCV/tests/opt/quick/se/00.hello/riscv/linux/simple-atomic: FAILED! * build/RISCV/tests/opt/qu