Bobby R. Bruce has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/41913 )
Change subject: arch-riscv,misc: Add missing overrides for clang compilation
..
arch-riscv,misc: Add missing overrides for clang compilation
The Clang compiler returns "missing override" errors without these.
Change-Id: I62af6c338b000123c924f0b3205551579bd5aeb4
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/41913
Reviewed-by: Gabe Black
Reviewed-by: Hoa Nguyen
Maintainer: Bobby R. Bruce
Tested-by: kokoro
---
M src/arch/riscv/isa.hh
M src/dev/riscv/clint.hh
M src/dev/riscv/rtc.hh
3 files changed, 7 insertions(+), 5 deletions(-)
Approvals:
Hoa Nguyen: Looks good to me, approved
Gabe Black: Looks good to me, approved
Bobby R. Bruce: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/arch/riscv/isa.hh b/src/arch/riscv/isa.hh
index 1c5dac3..7f03a17 100644
--- a/src/arch/riscv/isa.hh
+++ b/src/arch/riscv/isa.hh
@@ -97,8 +97,8 @@
bool inUserMode() const override { return true; }
-void serialize(CheckpointOut ) const;
-void unserialize(CheckpointIn );
+void serialize(CheckpointOut ) const override;
+void unserialize(CheckpointIn ) override;
ISA(const Params );
};
diff --git a/src/dev/riscv/clint.hh b/src/dev/riscv/clint.hh
index 7b1745c..1f213ce 100644
--- a/src/dev/riscv/clint.hh
+++ b/src/dev/riscv/clint.hh
@@ -139,7 +139,8 @@
* SimObject functions
*/
void init() override;
-Port & getPort(const std::string _name, PortID idx=InvalidPortID);
+Port & getPort(const std::string _name,
+ PortID idx=InvalidPortID) override;
void serialize(CheckpointOut ) const override;
void unserialize(CheckpointIn ) override;
diff --git a/src/dev/riscv/rtc.hh b/src/dev/riscv/rtc.hh
index bfd9071..42a2d29 100644
--- a/src/dev/riscv/rtc.hh
+++ b/src/dev/riscv/rtc.hh
@@ -70,9 +70,10 @@
RiscvRTC(const Params );
-Port & getPort(const std::string _name, PortID idx=InvalidPortID);
+Port & getPort(const std::string _name,
+ PortID idx=InvalidPortID) override;
-void startup();
+void startup() override;
void serialize(CheckpointOut ) const override;
void unserialize(CheckpointIn ) override;
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/41913
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I62af6c338b000123c924f0b3205551579bd5aeb4
Gerrit-Change-Number: 41913
Gerrit-PatchSet: 2
Gerrit-Owner: Bobby R. Bruce
Gerrit-Reviewer: Ayaz Akram
Gerrit-Reviewer: Bobby R. Bruce
Gerrit-Reviewer: Gabe Black
Gerrit-Reviewer: Hoa Nguyen
Gerrit-Reviewer: Jason Lowe-Power
Gerrit-Reviewer: Peter Yuen
Gerrit-Reviewer: kokoro
Gerrit-MessageType: merged
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
