Hsuan Hsu has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/30917 )
Change subject: cpu-kvm: Initialize _hasKernelIRQChip in the constructor
......................................................................
cpu-kvm: Initialize _hasKernelIRQChip in the constructor
This class member was only correctly set to true when using an in-kernel
interrupt controller, but was un-initialized when trying to use a user-
space one and would cause trouble.
JIRA: https://gem5.atlassian.net/browse/GEM5-663
Change-Id: I71b052c6da7e8790b05a15c07e7933bc4f912785
Signed-off-by: Hsuan Hsu <hsuan....@mediatek.com>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/30917
Reviewed-by: Giacomo Travaglini <giacomo.travagl...@arm.com>
Reviewed-by: Andreas Sandberg <andreas.sandb...@arm.com>
Maintainer: Giacomo Travaglini <giacomo.travagl...@arm.com>
Maintainer: Andreas Sandberg <andreas.sandb...@arm.com>
Tested-by: kokoro <noreply+kok...@google.com>
---
M src/cpu/kvm/vm.cc
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Andreas Sandberg: Looks good to me, approved; Looks good to me, approved
Giacomo Travaglini: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/cpu/kvm/vm.cc b/src/cpu/kvm/vm.cc
index 720548c..4640ca1 100644
--- a/src/cpu/kvm/vm.cc
+++ b/src/cpu/kvm/vm.cc
@@ -294,6 +294,7 @@
kvm(new Kvm()), system(nullptr),
vmFD(kvm->createVM()),
started(false),
+ _hasKernelIRQChip(false),
nextVCPUID(0)
{
maxMemorySlot = kvm->capNumMemSlots();
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/30917
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I71b052c6da7e8790b05a15c07e7933bc4f912785
Gerrit-Change-Number: 30917
Gerrit-PatchSet: 8
Gerrit-Owner: Hsuan Hsu <kugwa2...@gmail.com>
Gerrit-Reviewer: Andreas Sandberg <andreas.sandb...@arm.com>
Gerrit-Reviewer: Gabe Black <gabebl...@google.com>
Gerrit-Reviewer: Giacomo Travaglini <giacomo.travagl...@arm.com>
Gerrit-Reviewer: Hsuan Hsu <kugwa2...@gmail.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
