Daniel Carvalho has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/38495 )
Change subject: mem-ruby: Fix const copy of addr range in AbstractController
......................................................................
mem-ruby: Fix const copy of addr range in AbstractController
Clang 10 throws the following error:
loop variable 'addr_range' of type 'const AddrRange' creates a
copy from type 'const AddrRange' [-Werror,-Wrange-loop-construct]
note: use reference type 'const AddrRange &' to prevent copying
Issue introduced by c7fabb979c09864ab47ae848381d6797b45a4cc6.
Change-Id: I43e8d613eb5069d5ce9cb12ddec18cba0a3847f6
Signed-off-by: Daniel R. Carvalho <oda...@yahoo.com.br>
---
M src/mem/ruby/slicc_interface/AbstractController.cc
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mem/ruby/slicc_interface/AbstractController.cc
b/src/mem/ruby/slicc_interface/AbstractController.cc
index 1e8d8e0..ba2075a 100644
--- a/src/mem/ruby/slicc_interface/AbstractController.cc
+++ b/src/mem/ruby/slicc_interface/AbstractController.cc
@@ -87,7 +87,7 @@
for (auto abs_cntrl : params().downstream_destinations) {
MachineID mid = abs_cntrl->getMachineID();
const AddrRangeList &ranges = abs_cntrl->getAddrRanges();
- for (const auto addr_range : ranges) {
+ for (const auto &addr_range : ranges) {
auto i = downstreamAddrMap.intersects(addr_range);
if (i == downstreamAddrMap.end()) {
i = downstreamAddrMap.insert(addr_range, AddrMapEntry());
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/38495
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I43e8d613eb5069d5ce9cb12ddec18cba0a3847f6
Gerrit-Change-Number: 38495
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Carvalho <oda...@yahoo.com.br>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
