Daniel Carvalho has uploaded this change for review. (
https://gem5-review.googlesource.com/8883
Change subject: mem-cache: Make getCandidates a const function
......................................................................
mem-cache: Make getCandidates a const function
getCandidates() should not be able to modify the contents of the object, as
it is simply a getter.
Change-Id: I4db75e54389a759444fdb5a929f62ef22fb2f213
---
M src/mem/cache/tags/base.hh
M src/mem/cache/tags/base_set_assoc.hh
M src/mem/cache/tags/fa_lru.cc
M src/mem/cache/tags/fa_lru.hh
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/mem/cache/tags/base.hh b/src/mem/cache/tags/base.hh
index 1b06abc..778fffe 100644
--- a/src/mem/cache/tags/base.hh
+++ b/src/mem/cache/tags/base.hh
@@ -288,7 +288,7 @@
* @param addr The addr to a find replacement candidates for.
* @return The replacement candidates.
*/
- virtual ReplacementCandidates getCandidates(Addr addr) = 0;
+ virtual ReplacementCandidates getCandidates(Addr addr) const = 0;
virtual int extractSet(Addr addr) const = 0;
diff --git a/src/mem/cache/tags/base_set_assoc.hh
b/src/mem/cache/tags/base_set_assoc.hh
index df19726..27a3734 100644
--- a/src/mem/cache/tags/base_set_assoc.hh
+++ b/src/mem/cache/tags/base_set_assoc.hh
@@ -192,7 +192,7 @@
* @param addr The addr to a find replacement candidates for.
* @return The replacement candidates.
*/
- ReplacementCandidates getCandidates(Addr addr) override
+ ReplacementCandidates getCandidates(Addr addr) const override
{
ReplacementCandidates cands;
diff --git a/src/mem/cache/tags/fa_lru.cc b/src/mem/cache/tags/fa_lru.cc
index 8fcc947..7ad31cc 100644
--- a/src/mem/cache/tags/fa_lru.cc
+++ b/src/mem/cache/tags/fa_lru.cc
@@ -243,7 +243,7 @@
}
ReplacementCandidates
-FALRU::getCandidates(Addr addr)
+FALRU::getCandidates(Addr addr) const
{
ReplacementCandidates cands;
diff --git a/src/mem/cache/tags/fa_lru.hh b/src/mem/cache/tags/fa_lru.hh
index b5f95ed..e4fd277 100644
--- a/src/mem/cache/tags/fa_lru.hh
+++ b/src/mem/cache/tags/fa_lru.hh
@@ -206,7 +206,7 @@
* @param pkt The request to a find replacement candidates for.
* @return The replacement candidates.
*/
- ReplacementCandidates getCandidates(Addr addr) override;
+ ReplacementCandidates getCandidates(Addr addr) const override;
void insertBlock(PacketPtr pkt, CacheBlk *blk) override;
--
To view, visit https://gem5-review.googlesource.com/8883
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I4db75e54389a759444fdb5a929f62ef22fb2f213
Gerrit-Change-Number: 8883
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Carvalho <oda...@yahoo.com.br>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev
